Re: [PATCH] githooks.txt: use correct "reference-transaction" hook name

[Patrick Steinhardt <ps@pks.im>]

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Hi Bojun,

On Fri, Jul 24, 2020 at 01:57:57PM +0000, starlord via GitGitGadget wrote:
> From: Bojun Chen <bojun.cbj@alibaba-inc.com>
> 
> The "reference transaction" hook was introduced in commit 6754159767
> (refs: implement reference transaction hook, 2020-06-19). The name of
> the hook is declared as "reference-transaction" in "refs.c" and
> testcases, but the name declared in "githooks.txt" is different.
> 
> Signed-off-by: Bojun Chen <bojun.cbj@alibaba-inc.com>

Indeed, thanks for catching this!

Reviewed-by: Patrick Steinhardt <ps@pks.im>

Patrick

> ---
>     githooks.txt: use correct "reference-transaction" hook name
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-681%2FBerger7%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-681/Berger7/master-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/681
> 
>  Documentation/githooks.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index 642471109f..31b601e4bc 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -404,8 +404,8 @@ Both standard output and standard error output are forwarded to
>  `git send-pack` on the other end, so you can simply `echo` messages
>  for the user.
>  
> -ref-transaction
> -~~~~~~~~~~~~~~~
> +reference-transaction
> +~~~~~~~~~~~~~~~~~~~~~
>  
>  This hook is invoked by any Git command that performs reference
>  updates. It executes whenever a reference transaction is prepared,
> 
> base-commit: 3d20111cbd42c9ef3116bb629838bcbfea508cda
> -- 
> gitgitgadget

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]