From: Dominique Martinet <asmadeus@codewreck.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Tomcsányi, Domonkos" <domi@tomcsanyi.net>,
"Garrit Franke" <garritfranke@gmail.com>,
"WireGuard mailing list" <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Adding support for reloading configuration via systemd
Date: Fri, 24 Jul 2020 16:46:05 +0200 [thread overview]
Message-ID: <20200724144605.GA1897@nautica> (raw)
In-Reply-To: <CAHmME9qX9h9GKCEXfLiU4=AJ-v6CSWEFCcV5Xy54gBefXdy=Vg@mail.gmail.com>
Jason A. Donenfeld wrote on Fri, Jul 24, 2020:
> Great, good to know. Made some small adjustments and committed this as:
> https://git.zx2c4.com/wireguard-tools/commit/?id=a66219fa107e1bf0a03ebbbc405879c1f0a826c5
diff --git a/src/systemd/wg-quick@.service
b/src/systemd/wg-quick@.service
index a9cbb58..dbdab44 100644
--- a/src/systemd/wg-quick@.service
+++ b/src/systemd/wg-quick@.service
@@ -15,6 +15,7 @@ Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/bin/wg-quick up %i
ExecStop=/usr/bin/wg-quick down %i
+ExecReload=/bin/bash -c 'exec /usr/bin/wg syncconf %i <(exec /usr/bin/wg-quick strip %i)'
FWIW, bash (and zsh, ksh etc) will optimise the last command call of a
script to not fork, `bash -c 'exec foo'` is the same as `bash -c 'foo'`
(for some reason it doesn't in the subshell though so that one makes a
difference; you can check with e.g. `strace -f -e clone bash -c ...`)
Simpler shells e.g. dash or busybox ash don't, but they don't support
the pipe substitution syntax either so I guess it doesn't matter here.
--
Dominique
next prev parent reply other threads:[~2020-07-24 14:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR02MB52169D6F055314DCD03746EDE6760@VI1PR02MB5216.eurprd02.prod.outlook.com>
2020-07-23 14:10 ` [PATCH] Adding support for reloading configuration via systemd Tomcsanyi, Domonkos
2020-07-24 9:14 ` Jason A. Donenfeld
2020-07-24 9:25 ` Garrit Franke
2020-07-24 9:27 ` Garrit Franke
2020-07-24 9:29 ` Jason A. Donenfeld
2020-07-24 13:09 ` Tomcsányi, Domonkos
2020-07-24 14:26 ` Jason A. Donenfeld
2020-07-24 14:46 ` Dominique Martinet [this message]
2020-07-24 14:49 ` Jason A. Donenfeld
2020-07-24 9:54 ` Matthias Urlichs
2020-07-24 10:52 ` Stefan Tatschner
2020-07-24 11:00 ` Matthias Urlichs
2020-07-25 12:16 ` Tore Anderson
2020-07-27 15:51 ` Jason A. Donenfeld
2020-07-27 20:04 ` Tore Anderson
2020-07-28 9:03 ` Jason A. Donenfeld
2020-07-28 9:54 ` Tore Anderson
2020-07-28 11:55 ` Jason A. Donenfeld
2020-07-28 12:17 ` Tore Anderson
2020-07-28 12:17 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724144605.GA1897@nautica \
--to=asmadeus@codewreck.org \
--cc=Jason@zx2c4.com \
--cc=domi@tomcsanyi.net \
--cc=garritfranke@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.