From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F143C433E0 for ; Fri, 24 Jul 2020 15:34:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DD4420737 for ; Fri, 24 Jul 2020 15:34:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbgGXPer (ORCPT ); Fri, 24 Jul 2020 11:34:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53932 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726455AbgGXPer (ORCPT ); Fri, 24 Jul 2020 11:34:47 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jyzif-006h4x-1L; Fri, 24 Jul 2020 17:34:45 +0200 Date: Fri, 24 Jul 2020 17:34:45 +0200 From: Andrew Lunn To: Andre.Edich@microchip.com Cc: Parthiban.Veerasooran@microchip.com, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, steve.glendinning@shawell.net Subject: Re: [PATCH net-next v2 3/6] smsc95xx: add PAL support to use external PHY drivers Message-ID: <20200724153445.GG1594328@lunn.ch> References: <20200723115507.26194-1-andre.edich@microchip.com> <20200723115507.26194-4-andre.edich@microchip.com> <20200723223956.GL1553578@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > +static void smsc95xx_handle_link_change(struct net_device *net) > > > +{ > > > + phy_print_status(net->phydev); > > > > So the MAC does not care about the speed? The pause configuration? > > Duplex? > > Now, I'm wondering how those "care about speed", "pause", and "duplex" > work in the current smsc95xx. I guess, we did not touch any of those > activities with our patches. Yes, this patchset itself is not necessarily wrong. It seems more like the driver could be broken with respect to these things. It is something you might want to put on your TODO list to look at later. Andrew