From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4C8BC433E1 for ; Fri, 24 Jul 2020 16:27:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D85D206D8 for ; Fri, 24 Jul 2020 16:27:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726701AbgGXQ1N (ORCPT ); Fri, 24 Jul 2020 12:27:13 -0400 Received: from verein.lst.de ([213.95.11.211]:36298 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgGXQ1M (ORCPT ); Fri, 24 Jul 2020 12:27:12 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id ACA5968AFE; Fri, 24 Jul 2020 18:27:09 +0200 (CEST) Date: Fri, 24 Jul 2020 18:27:09 +0200 From: Christoph Hellwig To: Amit Pundir Cc: Christoph Hellwig , Nicolas Saenz Julienne , Marek Szyprowski , Robin Murphy , David Rientjes , linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com, iommu@lists.linux-foundation.org, lkml , John Stultz , Sumit Semwal Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA Message-ID: <20200724162709.GA15051@lst.de> References: <011994f8a717a00dcd9ed7682a1ddeb421c2c43f.camel@suse.de> <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> <6db722947546221ed99d3f473f78e1a6de65d7d6.camel@suse.de> <0dc1e922bf87fa73790e7471b3974528dd261486.camel@suse.de> <20200724134114.GA3152@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 24, 2020 at 09:49:17PM +0530, Amit Pundir wrote: > On Fri, 24 Jul 2020 at 19:11, Christoph Hellwig wrote: > > > > Yes, the iommu is an interesting case, and the current code is > > wrong for that. Can you try the patch below? It contains a modified > > version of Nicolas' patch to try CMA again for the expansion and a new > > (for now hackish) way to not apply the addressability check for dma-iommu > > allocations. > > Thank you. The below patch worked on today's linux/master (f37e99aca03f). Ok, I'll try to massage it into a few cleaner patches over the weekend and will send them to you again for retesting. Thanks a lot for your patience! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85FEC433E0 for ; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF767206D8 for ; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF767206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 98CFB888A4; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t-lG2kcfihom; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 23D5487AB5; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 06B1BC004E; Fri, 24 Jul 2020 16:27:16 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 32B45C004C for ; Fri, 24 Jul 2020 16:27:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2E4F388896 for ; Fri, 24 Jul 2020 16:27:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GO5ZRmDHK9Mu for ; Fri, 24 Jul 2020 16:27:14 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by hemlock.osuosl.org (Postfix) with ESMTPS id C87BF87AB5 for ; Fri, 24 Jul 2020 16:27:13 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id ACA5968AFE; Fri, 24 Jul 2020 18:27:09 +0200 (CEST) Date: Fri, 24 Jul 2020 18:27:09 +0200 From: Christoph Hellwig To: Amit Pundir Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA Message-ID: <20200724162709.GA15051@lst.de> References: <011994f8a717a00dcd9ed7682a1ddeb421c2c43f.camel@suse.de> <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> <6db722947546221ed99d3f473f78e1a6de65d7d6.camel@suse.de> <0dc1e922bf87fa73790e7471b3974528dd261486.camel@suse.de> <20200724134114.GA3152@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Cc: lkml , jeremy.linton@arm.com, Sumit Semwal , iommu@lists.linux-foundation.org, John Stultz , linux-rpi-kernel@lists.infradead.org, David Rientjes , Robin Murphy , Christoph Hellwig X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Fri, Jul 24, 2020 at 09:49:17PM +0530, Amit Pundir wrote: > On Fri, 24 Jul 2020 at 19:11, Christoph Hellwig wrote: > > > > Yes, the iommu is an interesting case, and the current code is > > wrong for that. Can you try the patch below? It contains a modified > > version of Nicolas' patch to try CMA again for the expansion and a new > > (for now hackish) way to not apply the addressability check for dma-iommu > > allocations. > > Thank you. The below patch worked on today's linux/master (f37e99aca03f). Ok, I'll try to massage it into a few cleaner patches over the weekend and will send them to you again for retesting. Thanks a lot for your patience! _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu