From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] mvebu: bubt: Drop dead code
Date: Fri, 24 Jul 2020 17:13:17 -0400 [thread overview]
Message-ID: <20200724211317.2678-1-trini@konsulko.com> (raw)
The code around CONFIG_SYS_MMC_ENV_PART has been untested since merge.
This can be seen by it referencing 'mmc->part_num' which was migrated
elsewhere prior to this code being merged.
Cc: Joel Johnson <mrjoel@lixil.net>
Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
cmd/mvebu/bubt.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c
index a27b0df8ae78..85ae588676fe 100644
--- a/cmd/mvebu/bubt.c
+++ b/cmd/mvebu/bubt.c
@@ -176,16 +176,6 @@ static int mmc_burn_image(size_t image_size)
return err;
}
-#ifdef CONFIG_SYS_MMC_ENV_PART
- if (mmc->part_num != CONFIG_SYS_MMC_ENV_PART) {
- err = mmc_switch_part(mmc_dev_num, CONFIG_SYS_MMC_ENV_PART);
- if (err) {
- printf("MMC partition switch failed\n");
- return err;
- }
- }
-#endif
-
/* SD reserves LBA-0 for MBR and boots from LBA-1,
* MMC/eMMC boots from LBA-0
*/
@@ -217,11 +207,6 @@ static int mmc_burn_image(size_t image_size)
}
printf("Done!\n");
-#ifdef CONFIG_SYS_MMC_ENV_PART
- if (mmc->part_num != CONFIG_SYS_MMC_ENV_PART)
- mmc_switch_part(mmc_dev_num, mmc->part_num);
-#endif
-
return 0;
}
--
2.17.1
next reply other threads:[~2020-07-24 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 21:13 Tom Rini [this message]
2020-07-25 11:38 ` [PATCH] mvebu: bubt: Drop dead code Stefan Roese
2020-07-25 12:59 ` Tom Rini
2020-07-30 6:50 ` Stefan Roese
2020-08-06 12:08 ` Stefan Roese
2020-08-06 14:27 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724211317.2678-1-trini@konsulko.com \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.