All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: u-boot@lists.denx.de
Subject: [PATCH 4/9] common/usb.c: Work around keyboard reporting "USB device not accepting new address"
Date: Fri, 24 Jul 2020 14:50:44 -0700	[thread overview]
Message-ID: <20200724215049.163379-5-jason.wessel@windriver.com> (raw)
In-Reply-To: <20200724215049.163379-1-jason.wessel@windriver.com>

When resetting the rpi3 board sometimes it will display:
     USB device not accepting new address (error=0)

After the message appears, the usb keyboard will not work.  It seems
that the configuration actually did succeed however.  Checking the
device status for a return code of zero and continuing allows the usb
keyboard and other usb devices to work function.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 common/usb.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/common/usb.c b/common/usb.c
index aad13fd9c5..0eb5d40a2d 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -1054,11 +1054,12 @@ static int usb_prepare_device(struct usb_device *dev, int addr, bool do_read,
 	dev->devnum = addr;
 
 	err = usb_set_address(dev); /* set address */
-
-	if (err < 0) {
+	if (err < 0)
+		debug("\n       usb_set_address return < 0\n");
+	if (err < 0 && dev->status != 0) {
 		printf("\n      USB device not accepting new address " \
 			"(error=%lX)\n", dev->status);
-		return err;
+			return err;
 	}
 
 	mdelay(10);	/* Let the SET_ADDRESS settle */
-- 
2.17.1

  parent reply	other threads:[~2020-07-24 21:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 21:50 [PULL][PATCH 0/9] Raspberry pi improvements qemu/usb/ethernet Jason Wessel
2020-07-24 21:50 ` [PATCH 1/9] fs/fat/fat.c: Do not perform zero block reads if there are no blocks left Jason Wessel
2020-07-25 15:27   ` Heinrich Schuchardt
2020-07-24 21:50 ` [PATCH 2/9] xhci: Add polling support for USB keyboards Jason Wessel
2020-07-24 21:50 ` [PATCH 3/9] usb_kbd: succeed even if no interrupt is pending Jason Wessel
2020-07-24 21:50 ` Jason Wessel [this message]
2020-07-24 21:50 ` [PATCH 5/9] xhci-ring.c: Add the poll_pend state to properly abort transactions Jason Wessel
2020-08-20  8:26   ` Bin Meng
2020-08-24  3:35     ` Jason Wessel
2020-07-24 21:50 ` [PATCH 6/9] xhci-ring: Fix crash when issuing "usb reset" Jason Wessel
2020-07-24 21:50 ` [PATCH 7/9] usb.c: Add a retry in the usb_prepare_device() Jason Wessel
2020-07-24 21:50 ` [PATCH 8/9] bcmgenet: fix DMA buffer management Jason Wessel
2020-07-24 21:50 ` [PATCH 9/9] bcmgenet: Add support for rgmii-rxid Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200724215049.163379-5-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.