From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DDEC433E0 for ; Sat, 25 Jul 2020 12:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A3B2206C1 for ; Sat, 25 Jul 2020 12:01:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="PPNCdzhy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbgGYMBv (ORCPT ); Sat, 25 Jul 2020 08:01:51 -0400 Received: from rere.qmqm.pl ([91.227.64.183]:29317 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726583AbgGYMBv (ORCPT ); Sat, 25 Jul 2020 08:01:51 -0400 Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4BDPn81jwXz4D; Sat, 25 Jul 2020 14:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1595678509; bh=w3jUGDxRIp+sGpE9bEyj0oc+ewSofeGPQslarzeKxxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PPNCdzhyzVxX03mIEivhG7d/l2lFQD2BCi4mXt9uALM0rUoA3As8RN4hksjdd9FYl /ZTPDoAlxYg+lRbB/iSg4TQVhZ/DGCMOOIS3GHG1+fF6j2muJrefXUANdfObiX4alB Pt/YVFHIwSKttoxv+geGRe/fz1TtLgYdZ6ZQoRxBxB9r5aVBc22MpyyiqWvfeIHnjV SPYtgHdNAfeNXAUq0y2rvG317NDE1ThkfGi+addFjm/fKwZov6HKJHzzpVMsHwpmH3 eibaAFS81VCVyWKs0cyh5ZTwxa7KKeI7F3kyzrNnh852vUCE4GmWvNo1lFikhp0vw8 nGT2jBMykX3Fg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at mail Date: Sat, 25 Jul 2020 14:01:47 +0200 From: =?iso-8859-2?B?TWljaGGzoE1pcm9zs2F3?= To: Rohit K Bharadwaj Cc: marvin24@posteo.de, gregkh@linuxfoundation.org, p.zabel@pengutronix.de, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, Dan Carpenter Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary Message-ID: <20200725120146.GB26689@qmqm.qmqm.pl> References: <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (which is deprecated) to secondary without breaking the driver The relevant I2C and SMBus standards use master/slave terminology. Why are you changing the names to something unfamiliar? If the reason are the recent coding-style changes, then please note they are about avoiding introducing *NEW* uses of the specific words and not about blindly replacing existing occurrences. Best Regards Michał Mirosław From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=BAYES_05,DKIM_ADSP_ALL, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548FEC433DF for ; Sat, 25 Jul 2020 12:07:11 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4D1F20674 for ; Sat, 25 Jul 2020 12:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=rere.qmqm.pl header.i=@rere.qmqm.pl header.b="PPNCdzhy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D4D1F20674 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rere.qmqm.pl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B3C67867B9; Sat, 25 Jul 2020 12:07:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MMHiz4-aYPQy; Sat, 25 Jul 2020 12:07:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id F1E66864EF; Sat, 25 Jul 2020 12:07:09 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 6B00D1BF36C for ; Sat, 25 Jul 2020 12:07:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 65CC72036E for ; Sat, 25 Jul 2020 12:07:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YlaUqyoDgPIb for ; Sat, 25 Jul 2020 12:07:08 +0000 (UTC) X-Greylist: delayed 00:05:14 by SQLgrey-1.7.6 Received: from rere.qmqm.pl (rere.qmqm.pl [91.227.64.183]) by silver.osuosl.org (Postfix) with ESMTPS id 127F920496 for ; Sat, 25 Jul 2020 12:07:08 +0000 (UTC) Received: from remote.user (localhost [127.0.0.1]) by rere.qmqm.pl (Postfix) with ESMTPSA id 4BDPn81jwXz4D; Sat, 25 Jul 2020 14:01:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rere.qmqm.pl; s=1; t=1595678509; bh=w3jUGDxRIp+sGpE9bEyj0oc+ewSofeGPQslarzeKxxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PPNCdzhyzVxX03mIEivhG7d/l2lFQD2BCi4mXt9uALM0rUoA3As8RN4hksjdd9FYl /ZTPDoAlxYg+lRbB/iSg4TQVhZ/DGCMOOIS3GHG1+fF6j2muJrefXUANdfObiX4alB Pt/YVFHIwSKttoxv+geGRe/fz1TtLgYdZ6ZQoRxBxB9r5aVBc22MpyyiqWvfeIHnjV SPYtgHdNAfeNXAUq0y2rvG317NDE1ThkfGi+addFjm/fKwZov6HKJHzzpVMsHwpmH3 eibaAFS81VCVyWKs0cyh5ZTwxa7KKeI7F3kyzrNnh852vUCE4GmWvNo1lFikhp0vw8 nGT2jBMykX3Fg== X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at mail Date: Sat, 25 Jul 2020 14:01:47 +0200 From: =?iso-8859-2?B?TWljaGGzoE1pcm9zs2F3?= To: Rohit K Bharadwaj Subject: Re: [PATCH v4] staging: nvec: change usage of slave to secondary Message-ID: <20200725120146.GB26689@qmqm.qmqm.pl> References: <20200724043633.7755-1-bharadwaj.rohit8@gmail.com> <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200725062938.15388-1-bharadwaj.rohit8@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, Dan Carpenter , p.zabel@pengutronix.de, linux-tegra@vger.kernel.org, ac100@lists.launchpad.net Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: > changed usage of slave (which is deprecated) to secondary without breakin= g the driver The relevant I2C and SMBus standards use master/slave terminology. Why are you changing the names to something unfamiliar? If the reason are the recent coding-style changes, then please note they are about avoiding introducing *NEW* uses of the specific words and not about blindly replacing existing occurrences. Best Regards Micha=B3=A0Miros=B3aw _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel