From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C93C433E0 for ; Sun, 26 Jul 2020 09:51:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F1B22065C for ; Sun, 26 Jul 2020 09:51:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="TjHzSRO0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726820AbgGZJvy (ORCPT ); Sun, 26 Jul 2020 05:51:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbgGZJvy (ORCPT ); Sun, 26 Jul 2020 05:51:54 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C758C0619D2 for ; Sun, 26 Jul 2020 02:51:54 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id x5so10926225wmi.2 for ; Sun, 26 Jul 2020 02:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oEbIDSC1rXRtLVhm/ydu++g4Gbu31ygS4ObIAOgDsuI=; b=TjHzSRO0qj8pH/Ell4cZdrTHTTT5Pcn79M/VP86Na/C1ezMCDK3B4F+JTDwxvSxXqq WLLFrVc1W7pEskjeilBNLtWE3X+CPqzgp+OeDXDh80OCrH6GbGFL2t8QBEXhAyEU8vEz 6e1VrBWy9N2YFIw996WWrKAmMvxLmJPBg9+vKf9HoaUZHQwP0jGm732zARsQ7Yct1mNp NCVnR1Pts9tFOXA+hAAshZqLHNW0OXrFGbjTkvzgj0HvVPLFbU2jrOPxereE/lgBrdEO IIUi7ZJ7Pn9+wzgsQLkRLenfgwCuXDpMe/fDsEqZHqP716COFzjIjmCPwZRQGHErfLPG 0GiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oEbIDSC1rXRtLVhm/ydu++g4Gbu31ygS4ObIAOgDsuI=; b=UaUbcwVP2kOvYDokDup85HPC3Hw8s0hZ/7bOOR2USk76Y2ENVg70dIOQj6g71q+3JP zsL+uFeh6R25dgFL3ItNoRV8RP4VMvu8ws4hvK5EfOSOcCKNBbhW9rRLeuAU2wYd8yJ9 rRHZbnWcG3YoBnGJaDB8HienuYmYL2t2TzwV3mUOprLie6qido1EI6ooWkOx+EayXnX4 YuLkR6Ay/OWIU+Vrg3mXcj6OKmWiCXQ/eCWgmG3w8+Orkbh0yVP1E/xHHA9uJBfmhqDp 8syYWir7Lg9klxQWN0oqt1zynBF4Ex6dK+OWbJPLTx4l3szmlVSy9/85PAlOt9Z/Abyt qbBg== X-Gm-Message-State: AOAM532abzJAhhaYgqCnGXt6HYT36ILFlJAlVz6J8HsI+yFNsJaA2Seh AqRulPtIPwT9rOnC0wUka0Zurg== X-Google-Smtp-Source: ABdhPJyd2i2prFENiOohjTGObmcV1kDbVuCsR8PDtL8TH2kqkeX4yAQxHQRi1z1oMxYhKTU9ApArvQ== X-Received: by 2002:a1c:e244:: with SMTP id z65mr8187502wmg.34.1595757112204; Sun, 26 Jul 2020 02:51:52 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id t2sm13192830wma.43.2020.07.26.02.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jul 2020 02:51:51 -0700 (PDT) Date: Sun, 26 Jul 2020 11:51:50 +0200 From: Jiri Pirko To: Vadym Kochan Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Ido Schimmel , Andrew Lunn , Oleksandr Mazur , Serhiy Boiko , Serhiy Pshyk , Volodymyr Mytnyk , Taras Chornyi , Andrii Savka , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mickey Rachamim Subject: Re: [net-next v3 2/6] net: marvell: prestera: Add PCI interface support Message-ID: <20200726095150.GH2216@nanopsycho> References: <20200725150651.17029-1-vadym.kochan@plvision.eu> <20200725150651.17029-3-vadym.kochan@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200725150651.17029-3-vadym.kochan@plvision.eu> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sat, Jul 25, 2020 at 05:06:47PM CEST, vadym.kochan@plvision.eu wrote: >Add PCI interface driver for Prestera Switch ASICs family devices, which >provides: > > - Firmware loading mechanism > - Requests & events handling to/from the firmware > - Access to the firmware on the bus level > >The firmware has to be loaded each time device is reset. The driver is >loading it from: > > /lib/firmware/marvell/prestera_fw-v{MAJOR}.{MINOR}.img > >The full firmware image version is located within internal header and >consists of 3 numbers - MAJOR.MINOR.PATCH. Additionally, driver has >hard-coded minimum supported firmware version which it can work with: > > MAJOR - reflects the support on ABI level between driver and loaded > firmware, this number should be the same for driver and loaded > firmware. > > MINOR - this is the minimum supported version between driver and the > firmware. > > PATCH - indicates only fixes, firmware ABI is not changed. > >Firmware image file name contains only MAJOR and MINOR numbers to make >driver be compatible with any PATCH version. > >Signed-off-by: Oleksandr Mazur >Signed-off-by: Vadym Kochan Looks fine. Acked-by: Jiri Pirko