Hi Kees, I love your patch! Yet something to improve: [auto build test ERROR on v5.8-rc4] [also build test ERROR on next-20200724] [cannot apply to driver-core/driver-core-testing integrity/next-integrity security/next-testing linus/master v5.8-rc6 v5.8-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Kees-Cook/Introduce-partial-kernel_read_file-support/20200725-054631 base: dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258 config: i386-allmodconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/dmi.h:5, from drivers/firmware/efi/embedded-firmware.c:8: >> drivers/firmware/efi/embedded-firmware.c:25:38: error: static declaration of 'efi_embedded_fw_list' follows non-static declaration 25 | EFI_EMBEDDED_FW_VISIBILITY LIST_HEAD(efi_embedded_fw_list); | ^~~~~~~~~~~~~~~~~~~~ include/linux/list.h:24:19: note: in definition of macro 'LIST_HEAD' 24 | struct list_head name = LIST_HEAD_INIT(name) | ^~~~ In file included from drivers/firmware/efi/embedded-firmware.c:17: drivers/firmware/efi/embedded-firmware.h:16:25: note: previous declaration of 'efi_embedded_fw_list' was here 16 | extern struct list_head efi_embedded_fw_list; | ^~~~~~~~~~~~~~~~~~~~ >> drivers/firmware/efi/embedded-firmware.c:26:33: error: static declaration of 'efi_embedded_fw_checked' follows non-static declaration 26 | EFI_EMBEDDED_FW_VISIBILITY bool efi_embedded_fw_checked; | ^~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/firmware/efi/embedded-firmware.c:17: drivers/firmware/efi/embedded-firmware.h:17:13: note: previous declaration of 'efi_embedded_fw_checked' was here 17 | extern bool efi_embedded_fw_checked; | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/efi_embedded_fw_list +25 drivers/firmware/efi/embedded-firmware.c 24 > 25 EFI_EMBEDDED_FW_VISIBILITY LIST_HEAD(efi_embedded_fw_list); > 26 EFI_EMBEDDED_FW_VISIBILITY bool efi_embedded_fw_checked; 27 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org