From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0DE1C433E0 for ; Mon, 27 Jul 2020 12:02:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E9EE2075D for ; Mon, 27 Jul 2020 12:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbgG0MCn (ORCPT ); Mon, 27 Jul 2020 08:02:43 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51656 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbgG0MCn (ORCPT ); Mon, 27 Jul 2020 08:02:43 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 913E31C0BE1; Mon, 27 Jul 2020 14:02:40 +0200 (CEST) Date: Mon, 27 Jul 2020 14:02:40 +0200 From: Pavel Machek To: Martin Kepplinger Cc: robh@kernel.org, kernel@puri.sm, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org, Anson.Huang@nxp.com, agx@sigxcpu.org, angus@akkea.ca, broonie@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Baluta Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Message-ID: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> References: <20200721153225.7593-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2hoj2bazgzddsthw" Content-Disposition: inline In-Reply-To: <20200721153225.7593-1-martin.kepplinger@puri.sm> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2hoj2bazgzddsthw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > + pwmleds { > + compatible =3D "pwm-leds"; > + > + blue { > + label =3D "blue:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm2 0 50000>; > + }; > + > + green { > + label =3D "green:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm4 0 50000>; > + }; > + > + red { > + label =3D "red:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm3 0 50000>; > + }; > + }; Can we postpone this? 1) green:status is not really name used anywhere else 2) this should really use multicolor framework, as it is single LED, not three of them. Fixing that in future will be hard :-(. Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --2hoj2bazgzddsthw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXx7CYAAKCRAw5/Bqldv6 8kwGAKCjvSashqZQsiQnPTLTZogcToiYPgCgp6uRaz1bOz+Xt/QNSsFRPZJqGzw= =QEJS -----END PGP SIGNATURE----- --2hoj2bazgzddsthw-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A1DC433E1 for ; Mon, 27 Jul 2020 12:04:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45A3420714 for ; Mon, 27 Jul 2020 12:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zJ1MYEod" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45A3420714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YgJqVlaj4KYX+972ZHSRDxKknL9aK9vWuz86iK3kfJs=; b=zJ1MYEodVrWwxiu6AlgLVVujk JfeS5eNokWpFoEzTRL21sbaYBOl0I9gOJTRSb7+A0iNbsYU0fuFwexLhCkw8z2EvloVtZlm8VmADS z3+GdLaV7UpetZFvUt5Ap+fAj1XHPr1RMeMN5Rbpo13AEJBjzpCb48uzNmuZYQqCcZ0txrigBLBrY N/gUopnDYF+vqvnPlxk2QCb1Daul3oJd+NiiiSQw9N9JxXhohsYFYVpIha6gyZ5NO8yIGwChr4ebe EcjL9ijmudPRU8nFWHpbmcQnxk5CnZmJQFIHHYCxXi3blrVLR34ZjuZ+dHocA8YhibxScOYfdfe0O UTVi/caSg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k01qA-00022B-LE; Mon, 27 Jul 2020 12:02:46 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k01q8-00021Y-7s for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 12:02:45 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 913E31C0BE1; Mon, 27 Jul 2020 14:02:40 +0200 (CEST) Date: Mon, 27 Jul 2020 14:02:40 +0200 From: Pavel Machek To: Martin Kepplinger Subject: Re: [PATCH v4 1/3] arm64: dts: Add a device tree for the Librem 5 phone Message-ID: <20200727120240.bnivbjbfkjouucg4@duo.ucw.cz> References: <20200721153225.7593-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 In-Reply-To: <20200721153225.7593-1-martin.kepplinger@puri.sm> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_080244_394359_0CD77C74 X-CRM114-Status: GOOD ( 11.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Baluta , robh@kernel.org, kernel@puri.sm, Anson.Huang@nxp.com, devicetree@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, mchehab@kernel.org, festevam@gmail.com, agx@sigxcpu.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2432320042785545721==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2432320042785545721== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2hoj2bazgzddsthw" Content-Disposition: inline --2hoj2bazgzddsthw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > + pwmleds { > + compatible =3D "pwm-leds"; > + > + blue { > + label =3D "blue:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm2 0 50000>; > + }; > + > + green { > + label =3D "green:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm4 0 50000>; > + }; > + > + red { > + label =3D "red:status"; > + max-brightness =3D <248>; > + pwms =3D <&pwm3 0 50000>; > + }; > + }; Can we postpone this? 1) green:status is not really name used anywhere else 2) this should really use multicolor framework, as it is single LED, not three of them. Fixing that in future will be hard :-(. Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --2hoj2bazgzddsthw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXx7CYAAKCRAw5/Bqldv6 8kwGAKCjvSashqZQsiQnPTLTZogcToiYPgCgp6uRaz1bOz+Xt/QNSsFRPZJqGzw= =QEJS -----END PGP SIGNATURE----- --2hoj2bazgzddsthw-- --===============2432320042785545721== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2432320042785545721==--