All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Pavel Machek <pavel@ucw.cz>
Cc: jack@suse.com, linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] udf: use common error code for unclean filesystem
Date: Mon, 27 Jul 2020 14:12:50 +0200	[thread overview]
Message-ID: <20200727121250.GN23179@quack2.suse.cz> (raw)
In-Reply-To: <20200726075828.GA26460@duo.ucw.cz>

On Sun 26-07-20 09:58:28, Pavel Machek wrote:
> 
> Use common error code for unclean filesystem, and warn when
> incosistency is detected.
> 
> Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>

So this is going in the right direction but there are *much* more places
that would need a similar treatment (furthermore I'd prefer to use the
EFSCORRUPTED redefine of EUCLEAN as other filesystems do). Any reason why
you converted this particular place?

								Honza

> 
> diff --git a/fs/udf/inode.c b/fs/udf/inode.c
> index adaba8e8b326..8e74c7b5b8d0 100644
> --- a/fs/udf/inode.c
> +++ b/fs/udf/inode.c
> @@ -1395,7 +1395,10 @@ static int udf_read_inode(struct inode *inode, bool hidden_inode)
>  	if (iinfo->i_alloc_type != ICBTAG_FLAG_AD_SHORT &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_LONG &&
>  	    iinfo->i_alloc_type != ICBTAG_FLAG_AD_IN_ICB) {
> -		ret = -EIO;
> +		ret = -EUCLEAN;
> +		udf_err(inode->i_sb, "invalid allocation type: %u\n",
> +			iinfo->i_alloc_type);
> +
>  		goto out;
>  	}
>  	iinfo->i_unique = 0;
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2020-07-27 12:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26  7:58 [PATCH] udf: use common error code for unclean filesystem Pavel Machek
2020-07-27 12:12 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727121250.GN23179@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=jack@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.