From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1D0C433EC for ; Mon, 27 Jul 2020 13:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2D0B206D8 for ; Mon, 27 Jul 2020 13:10:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tfe0RUHc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728632AbgG0NKZ (ORCPT ); Mon, 27 Jul 2020 09:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728141AbgG0NKY (ORCPT ); Mon, 27 Jul 2020 09:10:24 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26CF0C061794; Mon, 27 Jul 2020 06:10:24 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id e8so9474370pgc.5; Mon, 27 Jul 2020 06:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m8ss2q7X9z9vWtUgWZuhapv2kDOMmjklHJYu5RbP5UQ=; b=tfe0RUHcG6oEB/pYDfPsKbNlouoLw0dJgAttdqMZmC+zxCa/y4vF/dDFzGevJjNZvH cBQT3JQLt5EnDjE4rTePPuKCj1AaL56IC2TphWX1/5fnCdys4Rl/wDYqdE0Qi7uRvYE6 0oK7ZkmnNGgA7wJSRU5NcJt+rshEcFyoMSukxUhyoB1IfeHhivqMO0bGgkHWwxLSSt62 sEnNrtGDxf5e/i0e+pnAbhSsh0jYdYT8ORkwoFoPOQUxBHU1Pgg1vIYL4E+rGViAKCpM F2fuW8Dg2ZEun0pd/DnorX8w3ZC5o4jVcSlfDl60+7kOdWxBRnomw/s5TkiuhPv/loXX S/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m8ss2q7X9z9vWtUgWZuhapv2kDOMmjklHJYu5RbP5UQ=; b=GiXSJBBthCRDBXjc9L9rWGlJ8JsmF6LE8zl4Lx7qBp1BJQ6+44s1ugrOG+WhMk4wPI WWJcKGMSQwqNA5ZBeWhuwNjygvK+3Mp9bbhPkjCmcN4VTDJjjb0msHIfL9m2Skj3DIi+ EDmGklieXBDWUYHZGjFzR1zHpMI64XAhnDH5nYrGn4JWd9Klw7qjsJ/PhXXcWFbJTQE4 8GkM6qIcV7T83eMEsieB3573UVV/aRe4kXxvQwdNZ5nPf3BegYUUiDbwIfIvpZOzbSBb JTohgLifxaDKKD6UctT+y5q7f5YGWRESQDqnxlEwpZfAmD7r52cp/Y1ZK3dRw6mCN7Y8 X2yA== X-Gm-Message-State: AOAM532AiSDuQj5uYCQyOtSTG1+D/7V0JGxEwq+qJe0rgJKj23zzmoLx aAB+Fg7tbdqNoH2RyzXO0WPiA+/QQboJzQ== X-Google-Smtp-Source: ABdhPJyLY2OZt4FGCKBTtRcO9W18r2z79wDn+b8Jv3UNdFD4X2mpSxav3uGwaI20ww39In/zyxqTBw== X-Received: by 2002:aa7:94a7:: with SMTP id a7mr19562705pfl.83.1595855423688; Mon, 27 Jul 2020 06:10:23 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id e15sm14802124pgt.17.2020.07.27.06.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 06:10:23 -0700 (PDT) Date: Mon, 27 Jul 2020 18:38:58 +0530 From: Vaibhav Gupta To: Andy Shevchenko Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mark Brown , linux-spi , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan , "Rafael J. Wysocki" Subject: Re: [PATCH v1] spi: spi-topcliff-pch: use generic power management Message-ID: <20200727130858.GB82098@gmail.com> References: <20200724223746.GA1538991@bjorn-Precision-5520> <20200727070652.GA5400@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > wrote: > > ... > > > > The only problem here, is that the 2nd is already in the Mark's tree > > > and he doesn't do rebases. > > > So, it will be the other way around. > > > > > Concluding from yours and Bjorn's suggestion, I will drop the > > device_wakeup_disable() call form .resume() and send the fix. I will also track > > the drivers who got similar upgrades and went un-noticed. > > Thanks for doing this! > > > As Bjorn mentioned, the problem is that I don't have hardware to test, so I just > > replicated the legacy behaviour in generic by replacing > > pci_enable_wake(....,false) with device_wakeup_disable(). > > > > So, from now, while upgrading drivers with generic PM, should I completely drop > > the pci_enable_wake(....,false) calls if both .suspend() and .resume() try to > > wakeup-disable the device? > > I guess the best approach is to rely on the PCI core to do the right thing. > But mention this change in the commit message that we will have a > track of the changes properly. > Okay. Thanks ! Vaibhav Gupta > -- > With Best Regards, > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41C70C433EA for ; Mon, 27 Jul 2020 13:10:29 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15FB3206D8 for ; Mon, 27 Jul 2020 13:10:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tfe0RUHc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15FB3206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id DA16620461; Mon, 27 Jul 2020 13:10:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tgh2wuqg54Oz; Mon, 27 Jul 2020 13:10:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 6E616203B5; Mon, 27 Jul 2020 13:10:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 63EB9C0050; Mon, 27 Jul 2020 13:10:28 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 398A5C004D for ; Mon, 27 Jul 2020 13:10:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 28F2085E8A for ; Mon, 27 Jul 2020 13:10:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DjuJ9Ro_6i81 for ; Mon, 27 Jul 2020 13:10:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 1F53C85E60 for ; Mon, 27 Jul 2020 13:10:25 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id j20so9036102pfe.5 for ; Mon, 27 Jul 2020 06:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=m8ss2q7X9z9vWtUgWZuhapv2kDOMmjklHJYu5RbP5UQ=; b=tfe0RUHcG6oEB/pYDfPsKbNlouoLw0dJgAttdqMZmC+zxCa/y4vF/dDFzGevJjNZvH cBQT3JQLt5EnDjE4rTePPuKCj1AaL56IC2TphWX1/5fnCdys4Rl/wDYqdE0Qi7uRvYE6 0oK7ZkmnNGgA7wJSRU5NcJt+rshEcFyoMSukxUhyoB1IfeHhivqMO0bGgkHWwxLSSt62 sEnNrtGDxf5e/i0e+pnAbhSsh0jYdYT8ORkwoFoPOQUxBHU1Pgg1vIYL4E+rGViAKCpM F2fuW8Dg2ZEun0pd/DnorX8w3ZC5o4jVcSlfDl60+7kOdWxBRnomw/s5TkiuhPv/loXX S/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=m8ss2q7X9z9vWtUgWZuhapv2kDOMmjklHJYu5RbP5UQ=; b=MHJ8vNLaWL5UXlqc4yUM6zEMQDE/DJBmN7q+Tgp5CJfOlHI/ZfiAVXewbKGn/UyCyd F9aoWJvvWLR9byQy6U4FpwaeZDrvIP5c6tHzASdywvOjcm1hOtBkunxg8cU/KrasOaOf 41qQR8YS5RzRYGcsrGYQGTzvOlnRUSFOTJpWaeMUwNyP/W8djuuH0anliep72pDMdI1F RL/wgVSobRj0XXBIKlIVVKYpnyVWm5vzFVPYYFZQTiP6LMoJCSGfvNKgC3rrd6YrQKel UpnimIbZbQ9EhAiv+t9rCBpGF6NPBWy118n9dqqrF/Kq346STXYEXuhJZ2sJvU1X/Hhn tIAA== X-Gm-Message-State: AOAM530jrFzOXD/X3AECNz3n34t7OBHCG4PeY058AnbpFc8tRRO6JUIu rUATkxDaHPqac4M+quSSmyI= X-Google-Smtp-Source: ABdhPJyLY2OZt4FGCKBTtRcO9W18r2z79wDn+b8Jv3UNdFD4X2mpSxav3uGwaI20ww39In/zyxqTBw== X-Received: by 2002:aa7:94a7:: with SMTP id a7mr19562705pfl.83.1595855423688; Mon, 27 Jul 2020 06:10:23 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id e15sm14802124pgt.17.2020.07.27.06.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 06:10:23 -0700 (PDT) Date: Mon, 27 Jul 2020 18:38:58 +0530 From: Vaibhav Gupta To: Andy Shevchenko Message-ID: <20200727130858.GB82098@gmail.com> References: <20200724223746.GA1538991@bjorn-Precision-5520> <20200727070652.GA5400@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , linux-spi , Mark Brown , Bjorn Helgaas , Bjorn Helgaas , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v1] spi: spi-topcliff-pch: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Jul 27, 2020 at 02:12:16PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 10:08 AM Vaibhav Gupta wrote: > > On Sat, Jul 25, 2020 at 01:44:44PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko > > > wrote: > > ... > > > > The only problem here, is that the 2nd is already in the Mark's tree > > > and he doesn't do rebases. > > > So, it will be the other way around. > > > > > Concluding from yours and Bjorn's suggestion, I will drop the > > device_wakeup_disable() call form .resume() and send the fix. I will also track > > the drivers who got similar upgrades and went un-noticed. > > Thanks for doing this! > > > As Bjorn mentioned, the problem is that I don't have hardware to test, so I just > > replicated the legacy behaviour in generic by replacing > > pci_enable_wake(....,false) with device_wakeup_disable(). > > > > So, from now, while upgrading drivers with generic PM, should I completely drop > > the pci_enable_wake(....,false) calls if both .suspend() and .resume() try to > > wakeup-disable the device? > > I guess the best approach is to rely on the PCI core to do the right thing. > But mention this change in the commit message that we will have a > track of the changes properly. > Okay. Thanks ! Vaibhav Gupta > -- > With Best Regards, > Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees