From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Mon, 27 Jul 2020 15:30:48 +0200 Subject: [PATCH 8/8] Initial Pine64 Pinephone support In-Reply-To: <20200722141840.143379-9-pbrobinson@gmail.com> References: <20200722141840.143379-1-pbrobinson@gmail.com> <20200722141840.143379-9-pbrobinson@gmail.com> Message-ID: <20200727133048.q4b6yt2gpyevizt4@gilmour.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On Wed, Jul 22, 2020 at 03:18:40PM +0100, Peter Robinson wrote: > The Pine64 Pinephone is a smartphone based on the AllWinner A64 SoC. > It has the following features: > * 2GB LPDDR3 SDRAM > * 5.95 inch 1440x720 HD IPS capacitive touchscreen > * 16GB eMMC, mSD slot > * Quectel EG25 LTE Modem > * Realtek RTL8723CS WiFi/BT > * Front and read cameras > * Accelerometer, gyro, proximity, ambient light, compass sensors > * A USB Type-C, USB Host, DisplayPort alt mode output, 15W 5V 3A Quick Charge, follows USB PD specification > > Signed-off-by: Peter Robinson > --- > arch/arm/Kconfig | 2 +- > configs/pinephone_defconfig | 38 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 39 insertions(+), 1 deletion(-) > create mode 100644 configs/pinephone_defconfig > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index e16fe03887..636ba26938 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -1004,7 +1004,7 @@ config ARCH_SUNXI > bool "Support sunxi (Allwinner) SoCs" > select BINMAN > select CMD_GPIO > - select CMD_MMC if MMC > +select CMD_MMC if MMC That looks like a typo? > select CMD_USB if DISTRO_DEFAULTS > select CLK > select DM > diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig > new file mode 100644 > index 0000000000..d5750aa954 > --- /dev/null > +++ b/configs/pinephone_defconfig > @@ -0,0 +1,38 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_SPL=y > +CONFIG_MACH_SUN50I=y > +CONFIG_SUNXI_DRAM_LPDDR3_STOCK=y > +CONFIG_DRAM_CLK=552 > +CONFIG_DRAM_ZQ=3881949 > +CONFIG_NR_DRAM_BANKS=1 > +CONFIG_MMC_SUNXI_SLOT_EXTRA=2 > +CONFIG_R_I2C_ENABLE=y > +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > +# CONFIG_SPL_SPI_SUNXI is not set > +# CONFIG_SPL_DOS_PARTITION is not set > +# CONFIG_SPL_EFI_PARTITION is not set > +CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pinephone-1.1" > +CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.0" > +CONFIG_SYS_RELOC_GD_ENV_ADDR=y > +CONFIG_DM_REGULATOR=y > +CONFIG_DM_REGULATOR_FIXED=y > +CONFIG_DM_PWM=y > +CONFIG_PWM_SUNXI=y > +CONFIG_CMD_GPIO=y > +CONFIG_CMD_GPT=y > +CONFIG_CMD_I2C=y > +CONFIG_CMD_MMC=y > +# CONFIG_CMD_MII is not set > +# CONFIG_CMD_NFS is not set > +# CONFIG_DM_ETH is not set > +# CONFIG_PHY is not set > +# CONFIG_PHY_GIGE is not set > +# CONFIG_SUN8I_EMAC is not set > +# CONFIG_PHY_REALTEK is not set > +# CONFIG_CMD_SF is not set > +# CONFIG_SPI is not set > +# CONFIG_DM_SPI is not set > +# CONFIG_SPI_FLASH is not set > +# CONFIG_SPI_MEM is not set > +# CONFIG_DM_SPI_FLASH is not set I'm not entirely sure why we need to deviate from the default that much here. Some options should definitely be disabled (like SUN8I_EMAC), but I'm not really sure why it's enabled in the first place, and why we need to disable the other network related options (PHY, PHY_GIGE, PHY_REALTEK). They shouldn't even be enabled in the first place. Similarly, CMD_GPIO, CMD_GPT should be enabled by default. (and I'm not sure why PWM_SUNXI is here in the first place?) Maxime -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: