From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0D8C433EC for ; Mon, 27 Jul 2020 14:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D97620838 for ; Mon, 27 Jul 2020 14:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859090; bh=Q4cadmrLiQ8Sgn8VtoMDa7rmURrrqoBih88lvGYqX5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eKK5XroqeefEuqRpvudCUJaZIi3mlqm5s2uGFqvBVk5k1Po17zji74XqkgUkOcDMS ovXMZGL7VH83UabdCsYO//YZzUZGcfB2CmhHrC0TWmiaO3Owuk48O8/HWobysxXx0o GhwzCwx8ipRN+MATxcD/kN/OmcGaf1s+sSX20KtQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730024AbgG0OL2 (ORCPT ); Mon, 27 Jul 2020 10:11:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:34936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728654AbgG0OLX (ORCPT ); Mon, 27 Jul 2020 10:11:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEF302173E; Mon, 27 Jul 2020 14:11:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859082; bh=Q4cadmrLiQ8Sgn8VtoMDa7rmURrrqoBih88lvGYqX5U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IbSWLaux4Yr17IBKpzBS0IEBxM88MOgcQ3lXhAO3SfH3rDx0qN2LaYuMXu8yaRThB Fqu4i7XMQ4zwFCuwNRDwSEYMeh0I/IYVWFGoPcGVl4b2FgrLIcc74/CDB+nYmL0i3Y i7NucsSgjGSAIJMNd2g5mkvLzhKlO616J9z/9sDE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wang Hai , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 32/86] net: smc91x: Fix possible memory leak in smc_drv_probe() Date: Mon, 27 Jul 2020 16:04:06 +0200 Message-Id: <20200727134916.051392393@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134914.312934924@linuxfoundation.org> References: <20200727134914.312934924@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Hai [ Upstream commit bca9749b1aa23d964d3ab930938af66dbf887f15 ] If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) should be called to free the ndev created earlier. Otherwise, a memleak will occur. Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/smsc/smc91x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 8d6cff8bd1622..0f870ed5a9c8c 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -2287,7 +2287,7 @@ static int smc_drv_probe(struct platform_device *pdev) ret = try_toggle_control_gpio(&pdev->dev, &lp->power_gpio, "power", 0, 0, 100); if (ret) - return ret; + goto out_free_netdev; /* * Optional reset GPIO configured? Minimum 100 ns reset needed @@ -2296,7 +2296,7 @@ static int smc_drv_probe(struct platform_device *pdev) ret = try_toggle_control_gpio(&pdev->dev, &lp->reset_gpio, "reset", 0, 0, 100); if (ret) - return ret; + goto out_free_netdev; /* * Need to wait for optional EEPROM to load, max 750 us according -- 2.25.1