From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C9D3C433EB for ; Mon, 27 Jul 2020 14:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E10A021775 for ; Mon, 27 Jul 2020 14:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859117; bh=3d40csHXYgAn1gKXI/bGgNGTJZgUioqvbt1dNEOH83A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=luUEpptrRfrOUiFk4el2fWkPGZHQfqNPCHGJfCsSjpb84Rciqb2EjyZmJcpZTpWgQ ZP3SBKgAl8sP/VOCE2jGWmy+PaVKo99Z2ZZvAOZMPF8Z+h4FDXrh9rv8MCYX+qdp4U tbLHEMC82+wRXbRrYP5AhV/aNTcgC9nfbKUDH1jU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730098AbgG0OLz (ORCPT ); Mon, 27 Jul 2020 10:11:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:35802 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729274AbgG0OLx (ORCPT ); Mon, 27 Jul 2020 10:11:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 28B6920838; Mon, 27 Jul 2020 14:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595859113; bh=3d40csHXYgAn1gKXI/bGgNGTJZgUioqvbt1dNEOH83A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vo7zG8UnvvX9X93xxLqzVL04UGZEjDHm5oU7Lavqc1LTONoOioYJi3QVI67FCTRmJ sbxq41gAyBMQU8SJht2dnO+otLC3PAPTFfylLMygMtaaYJb0CN4X1a1pFdFTQ3vQXv ZDMYcIHKIoFfrksNm/4OahYqzL8j6NSPjsckBpf4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Forest Crossman Subject: [PATCH 4.19 63/86] usb: xhci: Fix ASM2142/ASM3142 DMA addressing Date: Mon, 27 Jul 2020 16:04:37 +0200 Message-Id: <20200727134917.589434945@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200727134914.312934924@linuxfoundation.org> References: <20200727134914.312934924@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Forest Crossman commit dbb0897e805f2ab1b8bc358f6c3d878a376b8897 upstream. The ASM2142/ASM3142 (same PCI IDs) does not support full 64-bit DMA addresses, which can cause silent memory corruption or IOMMU errors on platforms that use the upper bits. Add the XHCI_NO_64BIT_SUPPORT quirk to fix this issue. Signed-off-by: Forest Crossman Cc: stable Link: https://lore.kernel.org/r/20200717112734.328432-1-cyrozap@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-pci.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -231,6 +231,9 @@ static void xhci_pci_quirks(struct devic if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == 0x1142) xhci->quirks |= XHCI_TRUST_TX_LENGTH; + if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && + pdev->device == 0x2142) + xhci->quirks |= XHCI_NO_64BIT_SUPPORT; if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA && pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI)