From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6A16C433EA for ; Mon, 27 Jul 2020 14:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE253207FC for ; Mon, 27 Jul 2020 14:32:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="IJ6z7XlW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731334AbgG0Oce (ORCPT ); Mon, 27 Jul 2020 10:32:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730722AbgG0OS5 (ORCPT ); Mon, 27 Jul 2020 10:18:57 -0400 Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1981C0619D4 for ; Mon, 27 Jul 2020 07:18:56 -0700 (PDT) Received: by mail-qt1-x843.google.com with SMTP id x12so3760913qtp.1 for ; Mon, 27 Jul 2020 07:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pdmKQetK0QLJ8rFRGpIDAlZksqbKSxwq3s5x5iSj/6k=; b=IJ6z7XlWdHP11wN6ofEIEZ8eiR6sqBYmqASCFE7tsyV0XaLFN6UBCLhSDxG3ZtxFiB 6UUQmZZQPtZ5gWL5TR/BbzcqU4PRy1rsZs1ydjdNLg3DukK8x+zI+T5IrylXKZcJrp7X wgzsam6DyjyXmTzlExIy6Gz+ESwjakDY8S7H+WJNUPiGauBejJX9bL1UdYuOeP4pj6DE upJWQuBQhzHG9jhW6jTcUmhVdyytehsFjMWOs5NLeA9zWbEPdR+c2Lh3HlXUFaiIaFfI c4NcJMTaVP+qgpPKCcMERNPi8R+BSrrTeP2DhEflbq++A2XpC+Qam2kcKEcY1g6hCLWg xxXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pdmKQetK0QLJ8rFRGpIDAlZksqbKSxwq3s5x5iSj/6k=; b=IK3Z2C5HD8HBakFHJt9/ddxT2MWWozBfcxX69KlBCKiLr54LrLZzR4gRhFV4s2RGMD d4oqEQEWhYPTI1oEqFmmPGZ9oLw+zvG2kZ6Bt1PLBdP6OWk/PBnQnP37rTfF7sdTHu0d 1dUkCLOuSpgEMqRI5MyBM5491lEI92u5UqIBat8PhNbVr4g1TrTr51WjEJHOwsrPxXFs obP0XJOwHAm+SPyb/jrD6kgcAUux/fmH6RcH5/CIGVpc66d7rem5iE307eTy1y5R+WY3 dS1g2WI24+1a3l0sp69vcfGxfiLtw2iKbNPmfZe1cGBkDYawLeYkJ0AxPT/iUDCDw2pE 09LA== X-Gm-Message-State: AOAM5303kXUHPTZFGIHIjexIGb0gwFFpd0i19J/VseSUOVTB/62S2UZy Nmlkicn9pjKpKmk7XwKaMSR+8w== X-Google-Smtp-Source: ABdhPJy130C3D8M0rAarkjKcRWiHNErupodcdoc3UEhXmIRDecJWWcdT53d/lQhoGpyYSerZL6QGHQ== X-Received: by 2002:ac8:7a95:: with SMTP id x21mr7959782qtr.135.1595859535983; Mon, 27 Jul 2020 07:18:55 -0700 (PDT) Received: from lca.pw (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id k24sm14790073qtb.26.2020.07.27.07.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:18:55 -0700 (PDT) Date: Mon, 27 Jul 2020 10:18:48 -0400 From: Qian Cai To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Russell King , Thara Gopinath , Sudeep Holla , Amit Daniel Kachhap , Daniel Lezcano , Viresh Kumar , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann Subject: Re: [PATCH v2 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry Message-ID: <20200727141825.GA4174@lca.pw> References: <20200712165917.9168-1-valentin.schneider@arm.com> <20200712165917.9168-3-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200712165917.9168-3-valentin.schneider@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 12, 2020 at 05:59:16PM +0100, Valentin Schneider wrote: > As Russell pointed out [1], this option is severely lacking in the > documentation department, and figuring out if one has the required > dependencies to benefit from turning it on is not straightforward. > > Make it non user-visible, and add a bit of help to it. While at it, make it > depend on CPU_FREQ_THERMAL. > > [1]: https://lkml.kernel.org/r/20200603173150.GB1551@shell.armlinux.org.uk > > Signed-off-by: Valentin Schneider > --- > init/Kconfig | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 0498af567f70..0a97d85568b2 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -492,8 +492,21 @@ config HAVE_SCHED_AVG_IRQ > depends on SMP > > config SCHED_THERMAL_PRESSURE > - bool "Enable periodic averaging of thermal pressure" > + bool > depends on SMP > + depends on CPU_FREQ_THERMAL > + help > + Select this option to enable thermal pressure accounting in the > + scheduler. Thermal pressure is the value conveyed to the scheduler > + that reflects the reduction in CPU compute capacity resulted from > + thermal throttling. Thermal throttling occurs when the performance of > + a CPU is capped due to high operating temperatures. > + > + If selected, the scheduler will be able to balance tasks accordingly, > + i.e. put less load on throttled CPUs than on non/less throttled ones. > + > + This requires the architecture to implement > + arch_set_thermal_pressure() and arch_get_thermal_pressure(). > > config BSD_PROCESS_ACCT > bool "BSD Process Accounting" > -- On arm64 linux-next (20200727), https://gitlab.com/cailca/linux-mm/-/blob/master/arm64.config WARNING: unmet direct dependencies detected for SCHED_THERMAL_PRESSURE Depends on [n]: SMP [=y] && CPU_FREQ_THERMAL [=n] Selected by [y]: - ARM64 [=y] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62597C433F7 for ; Mon, 27 Jul 2020 14:20:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3293A2173E for ; Mon, 27 Jul 2020 14:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ai2F5/Iy"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="IJ6z7XlW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3293A2173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lcDUTpDLVmTyC4NlIDhj9YSZbi3+x89Z3hQv/RZmH14=; b=Ai2F5/IyiOW9Kjchc330lR7w1 6emtvo2/VtA/uJq3x83hhg6gMoOorFTbhVzczIv9tgUptimr/NvK89T9P0A13Zd2yf4VG1/fVIIvI HPUssriB3rWjBNTEVrCmblcjx8Waz5LDB1YpzlW31POStNW8R/UwZFRWtqPQh2wDDwsJ0zIwZoLNW MoWy1uU0dCFDXYUjoYzCequE48onIIVboXwTBmL3mbqqBc2+NhPXWhCIOWLaHT4lbVfPGNk2/+GB7 FJLBwj2vFk31v0uXi3T6DYy/w/97Ks1+OUjlu6JYNSfb0+DgbPHIFM7XvuPjc82GWEv9vfrGoTU8K PsUil4b0Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k03y0-0007Aa-6G; Mon, 27 Jul 2020 14:19:00 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k03xy-00079N-C4 for linux-arm-kernel@lists.infradead.org; Mon, 27 Jul 2020 14:18:59 +0000 Received: by mail-qt1-x842.google.com with SMTP id k18so12255839qtm.10 for ; Mon, 27 Jul 2020 07:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pdmKQetK0QLJ8rFRGpIDAlZksqbKSxwq3s5x5iSj/6k=; b=IJ6z7XlWdHP11wN6ofEIEZ8eiR6sqBYmqASCFE7tsyV0XaLFN6UBCLhSDxG3ZtxFiB 6UUQmZZQPtZ5gWL5TR/BbzcqU4PRy1rsZs1ydjdNLg3DukK8x+zI+T5IrylXKZcJrp7X wgzsam6DyjyXmTzlExIy6Gz+ESwjakDY8S7H+WJNUPiGauBejJX9bL1UdYuOeP4pj6DE upJWQuBQhzHG9jhW6jTcUmhVdyytehsFjMWOs5NLeA9zWbEPdR+c2Lh3HlXUFaiIaFfI c4NcJMTaVP+qgpPKCcMERNPi8R+BSrrTeP2DhEflbq++A2XpC+Qam2kcKEcY1g6hCLWg xxXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pdmKQetK0QLJ8rFRGpIDAlZksqbKSxwq3s5x5iSj/6k=; b=QejyqQu8K4oI9YC/0bQI/7FkNmEulFGYoAksLmDJMrGopxmP6lYpFlj6PvikmOZN5l 0hFw22wvf5sXr3ptOv8MYaELZCLIheIB0Qx6DnisDA0bMoaoD9Le5FBlx87JdJ/lvKKZ KuVe08r1/DJaaiBZrfX5jgg0TNkeoNR8aXU/lslcoj2ToPWD0yh2VAWwohb+pDGHOwS4 0weoVPCzLOpqFXaJ+WrvIoe8ciyhzbAUx3BztOWJ3xC7A4DpuIsHDzRhnRbv8aCg6K6a nrjVRVUAWZbnHjLKsSJ7UOr8sspYX+yVkD8/NJFIz8A5Yka2my1ft+uPlX6M4oj6Zbmw CGTg== X-Gm-Message-State: AOAM531OVIUUeghU0OZzIHCI7r7TumOoeO2hd2kvJ9scLzedKpNAk5ks A62db8ZtFoKBPCcZWjlS++/uZA== X-Google-Smtp-Source: ABdhPJy130C3D8M0rAarkjKcRWiHNErupodcdoc3UEhXmIRDecJWWcdT53d/lQhoGpyYSerZL6QGHQ== X-Received: by 2002:ac8:7a95:: with SMTP id x21mr7959782qtr.135.1595859535983; Mon, 27 Jul 2020 07:18:55 -0700 (PDT) Received: from lca.pw (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id k24sm14790073qtb.26.2020.07.27.07.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 07:18:55 -0700 (PDT) Date: Mon, 27 Jul 2020 10:18:48 -0400 From: Qian Cai To: Valentin Schneider Subject: Re: [PATCH v2 2/3] sched: Cleanup SCHED_THERMAL_PRESSURE kconfig entry Message-ID: <20200727141825.GA4174@lca.pw> References: <20200712165917.9168-1-valentin.schneider@arm.com> <20200712165917.9168-3-valentin.schneider@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200712165917.9168-3-valentin.schneider@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200727_101858_541197_B332FD9D X-CRM114-Status: GOOD ( 23.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Vincent Guittot , linux-pm@vger.kernel.org, Peter Zijlstra , Viresh Kumar , Amit Daniel Kachhap , Daniel Lezcano , Russell King , Thara Gopinath , linux-kernel@vger.kernel.org, Sudeep Holla , Dietmar Eggemann , Ingo Molnar , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jul 12, 2020 at 05:59:16PM +0100, Valentin Schneider wrote: > As Russell pointed out [1], this option is severely lacking in the > documentation department, and figuring out if one has the required > dependencies to benefit from turning it on is not straightforward. > > Make it non user-visible, and add a bit of help to it. While at it, make it > depend on CPU_FREQ_THERMAL. > > [1]: https://lkml.kernel.org/r/20200603173150.GB1551@shell.armlinux.org.uk > > Signed-off-by: Valentin Schneider > --- > init/Kconfig | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/init/Kconfig b/init/Kconfig > index 0498af567f70..0a97d85568b2 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -492,8 +492,21 @@ config HAVE_SCHED_AVG_IRQ > depends on SMP > > config SCHED_THERMAL_PRESSURE > - bool "Enable periodic averaging of thermal pressure" > + bool > depends on SMP > + depends on CPU_FREQ_THERMAL > + help > + Select this option to enable thermal pressure accounting in the > + scheduler. Thermal pressure is the value conveyed to the scheduler > + that reflects the reduction in CPU compute capacity resulted from > + thermal throttling. Thermal throttling occurs when the performance of > + a CPU is capped due to high operating temperatures. > + > + If selected, the scheduler will be able to balance tasks accordingly, > + i.e. put less load on throttled CPUs than on non/less throttled ones. > + > + This requires the architecture to implement > + arch_set_thermal_pressure() and arch_get_thermal_pressure(). > > config BSD_PROCESS_ACCT > bool "BSD Process Accounting" > -- On arm64 linux-next (20200727), https://gitlab.com/cailca/linux-mm/-/blob/master/arm64.config WARNING: unmet direct dependencies detected for SCHED_THERMAL_PRESSURE Depends on [n]: SMP [=y] && CPU_FREQ_THERMAL [=n] Selected by [y]: - ARM64 [=y] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel