From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=+GcV=BG=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 35868C433DF
	for <linux-kernel@archiver.kernel.org>; Mon, 27 Jul 2020 16:50:06 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 0B8F82074F
	for <linux-kernel@archiver.kernel.org>; Mon, 27 Jul 2020 16:50:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1595868606;
	bh=22XFLIm9G+RbCnMxSWD699xCqAJWa1TDuzMcG089LAY=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=0EvTcNqgltnkDanldmS8kqcbKmhUdT7za4DGjTI7w6IdeLA6bRalICgUWbRRgKw6q
	 Bh+qqKTuZCt4vIkh2VsiUsugiHKjRwrI/Iv2dybi30Jsfi1zPcsVeQYGzLab8KzyyE
	 UaHe2QFd+Bt7+Gk6+fqi2Oz/CwEAox6MKwpWKu3E=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729331AbgG0QuD (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 27 Jul 2020 12:50:03 -0400
Received: from mail.kernel.org ([198.145.29.99]:40376 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728305AbgG0QuC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 27 Jul 2020 12:50:02 -0400
Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id EF3072075A;
        Mon, 27 Jul 2020 16:50:01 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1595868602;
        bh=22XFLIm9G+RbCnMxSWD699xCqAJWa1TDuzMcG089LAY=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=Jhtp3RJWFY+48yj4sM2R/8F9nVBtUNZeL6wdQkMMwq6Qn9msZ1jhhJldtc/KzwB3r
         oL4hDwrm9HsYibBd2P9mYuo9CUsVJqsx18KaqVYviEWqF5wYXahBpNvyUuS36Wb3Ec
         KcW844ZuH3X238JwAk/fFR+WhlSsK+I24mqDsZEs=
Date:   Mon, 27 Jul 2020 09:50:00 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     linux-nilfs@vger.kernel.org,
        Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW
Message-ID: <20200727165000.GH1138@sol.localdomain>
References: <20200628070152.820311-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200628070152.820311-1-ebiggers@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> unlock_new_inode() is only meant to be called after a new inode has
> already been inserted into the hash table.  But nilfs_new_inode() can
> call it even before it has inserted the inode, triggering the WARNING in
> unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
> inode has the I_NEW flag set, indicating that it's in the table.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Ping.  Ryusuke, any interest in taking this patch?

- Eric