From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9833C433EB for ; Tue, 28 Jul 2020 06:39:13 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 56ED02177B for ; Tue, 28 Jul 2020 06:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="D+qVieX4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56ED02177B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 528921C1F4; Tue, 28 Jul 2020 08:35:53 +0200 (CEST) Received: from mail-wr1-f97.google.com (mail-wr1-f97.google.com [209.85.221.97]) by dpdk.org (Postfix) with ESMTP id 9BEC51C0DA for ; Tue, 28 Jul 2020 08:35:31 +0200 (CEST) Received: by mail-wr1-f97.google.com with SMTP id b6so17079894wrs.11 for ; Mon, 27 Jul 2020 23:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N1XtpJDfxLDEuuV4CN9/AmoMOYj2FDHNRu0BbYJOM+4=; b=D+qVieX4I4szZRQ7s2/Jj040LGp8BmSUUAt/jS3D4D6DQzA/WoflEd9wLShgA+htft Nh4jvrvcIGbrTKixbTm24KfvNgTbpvppI5RI5mbRGQa/53DZ49seL67Bp93hCTl/NG94 5VfIiEngzFMYSZ7OTzdHf3Ubrezm5n0Vg9F7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=N1XtpJDfxLDEuuV4CN9/AmoMOYj2FDHNRu0BbYJOM+4=; b=qFLdL46s1XHOR1FD9u05tuCFon0giXEtnr1dK9zoN4BQeTYgFSA8Ua6x7hZ+RFh5rN rjCCvx+6ae352giQzj7goj0RBMsNt5Bv+QSyO3f2+qhT+JKCPOMKyRGcLPOeJXlxvqS+ D/K0dgXZ2ZT17aIKGqPC3M3HmB/zhmzaIj2Cwg/WVx1gWvKb0IVVUV/ojTHQZ8NAUQdl Q8ZEj2JH8Mm9ajzm6swn+fEG34FhuWhm10Moik1Nc47wBusO8gWKbgqnTE6hOIAusHWQ g/abxk5VrkVQSgiLJU061uT3xnq0QESZbW6nmy8aqgmiBhPKaXcI6ciw3Bpu0e9IA5Du Gx/A== X-Gm-Message-State: AOAM533lwmzzMPujub81/Q2jJeahObxWBPVOoNqMf/2OY6SMxzXccFim iCzOcthpMM01rRn//yB7x67L9WFolC0PwL2E3HhNXwAXWrPSMtsNZ39pbafWPG0/Z8F78iujMwu AOLnINRGPJxc8op0T/cORBHEGheFeWlFv+SzI/vgcCPJfdzktjzRK1KZWlWZR8RxKvTFMx/QPXQ XQxA== X-Google-Smtp-Source: ABdhPJzWEyIzOGPgFPjJbx7ZfqHgXbnH9TadofrC9TJQYCR0zgWHGRhi48JSRksmq/faDARFBSFeNg7LPH/s X-Received: by 2002:adf:e550:: with SMTP id z16mr7156157wrm.329.1595918131210; Mon, 27 Jul 2020 23:35:31 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id r16sm30828wmh.29.2020.07.27.23.35.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2020 23:35:31 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Mon, 27 Jul 2020 23:34:38 -0700 Message-Id: <20200728063439.23114-22-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200728063439.23114-1-ajit.khaparde@broadcom.com> References: <20200728063439.23114-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 21/22] net/bnxt: fix if condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The if condition in bnxt_restore_mac_filters needs to check for the result of logical AND. But it was not doing it resulting in an incorrect check. Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index dfc4b4190..510a0d9e0 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -4372,7 +4372,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp) uint16_t i; int rc; - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) return 0; rc = bnxt_dev_info_get_op(dev, &dev_info); -- 2.21.1 (Apple Git-122.3)