All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roi Dayan <roid@mellanox.com>
To: netdev@vger.kernel.org
Cc: pablo@netfilter.org, Paul Blakey <paulb@mellanox.com>,
	Oz Shlomo <ozsh@mellanox.com>, Roi Dayan <roid@mellanox.com>
Subject: [PATCH net 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems
Date: Tue, 28 Jul 2020 14:57:57 +0300	[thread overview]
Message-ID: <20200728115759.426667-1-roid@mellanox.com> (raw)

On heavily loaded systems the GC can take time to go over all existing
conns and reset their timeout. At that time other calls like from
nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as
expired. To fix this when we set the offload bit we should also reset
the timeout instead of counting on GC to finish first iteration over
all conns before the initial timeout.

First commit is to expose the function that updates the timeout.
Second commit is to use it from act_ct.

Roi Dayan (2):
  netfilter: conntrack: Move nf_ct_offload_timeout to header file
  net/sched: act_ct: Set offload timeout when setting the offload bit

 include/net/netfilter/nf_conntrack.h | 12 ++++++++++++
 net/netfilter/nf_conntrack_core.c    | 12 ------------
 net/sched/act_ct.c                   |  2 ++
 3 files changed, 14 insertions(+), 12 deletions(-)

-- 
2.8.4


             reply	other threads:[~2020-07-28 11:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 11:57 Roi Dayan [this message]
2020-07-28 11:57 ` [PATCH net 1/2] netfilter: conntrack: Move nf_ct_offload_timeout to header file Roi Dayan
2020-07-28 11:57 ` [PATCH net 2/2] net/sched: act_ct: Set offload timeout when setting the offload bit Roi Dayan
2020-07-28 14:42   ` Marcelo Ricardo Leitner
2020-07-29 12:55     ` Roi Dayan
2020-07-29 17:10       ` Marcelo Ricardo Leitner
2020-08-03  7:21         ` Roi Dayan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728115759.426667-1-roid@mellanox.com \
    --to=roid@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ozsh@mellanox.com \
    --cc=pablo@netfilter.org \
    --cc=paulb@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.