From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E9A1C433DF for ; Tue, 28 Jul 2020 20:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED2AD2070B for ; Tue, 28 Jul 2020 20:14:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595967268; bh=oghM882DMjZDxEioymAmlnNFQOgo8v4qOv8PXLu1OKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=A1Z2vyADzz39VyfM1mO2IsNkqrdGc7/ZCiOUSz/fD/SO7sJPiBVrp5LaRRTbOwREU yeVzCQpMka0+TbKXxCzjx66OaRcLlKqwztHUsNLBd0/YY8++lIspv+1b8phlUOVLJU vSFFz7tRfrsC+FH1sibt0d4VKL0X/s9W0OrV2ie8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728613AbgG1UO1 (ORCPT ); Tue, 28 Jul 2020 16:14:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:46694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728149AbgG1UOZ (ORCPT ); Tue, 28 Jul 2020 16:14:25 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 172B820656; Tue, 28 Jul 2020 20:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595967265; bh=oghM882DMjZDxEioymAmlnNFQOgo8v4qOv8PXLu1OKI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=U3aKrGZGWufHVYkrpzNh6xc5rFRVFf0j6FyhjHkkLW+e4GrK0Gmb+3PNYALHKNaR7 4qq6Y6p4e78tj/WOtYmCJ67H+gS1Sl2PSbwi9/1MMew5bmQ6XnS99EDK0ML/z4jIOB +tL+dsOa9MwlfnJn0zPluWMhJWRHIuoS/Q+GZF20= Date: Tue, 28 Jul 2020 13:14:23 -0700 From: Jakub Kicinski To: Tony Nguyen Cc: davem@davemloft.net, Li RongQing , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jeffrey.t.kirsher@intel.com, Andrew Bowers Subject: Re: [net-next 2/6] i40e: prefetch struct page of Rx buffer conditionally Message-ID: <20200728131423.2430b3f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200728190842.1284145-3-anthony.l.nguyen@intel.com> References: <20200728190842.1284145-1-anthony.l.nguyen@intel.com> <20200728190842.1284145-3-anthony.l.nguyen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 28 Jul 2020 12:08:38 -0700 Tony Nguyen wrote: > From: Li RongQing > > page_address() accesses struct page only when WANT_PAGE_VIRTUAL > or HASHED_PAGE_VIRTUAL is defined, otherwise it returns address > based on offset, so we prefetch it conditionally > > Signed-off-by: Li RongQing > Tested-by: Andrew Bowers > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c > index 3e5c566ceb01..5d408fe26063 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c > @@ -1953,7 +1953,9 @@ static struct i40e_rx_buffer *i40e_get_rx_buffer(struct i40e_ring *rx_ring, > struct i40e_rx_buffer *rx_buffer; > > rx_buffer = i40e_rx_bi(rx_ring, rx_ring->next_to_clean); > +#if defined(WANT_PAGE_VIRTUAL) || defined(HASHED_PAGE_VIRTUAL) > prefetchw(rx_buffer->page); > +#endif Looks like something that belongs in a common header not (potentially multiple) C sources.