From: Bjorn Helgaas <helgaas@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: vc: Fix kerneldoc
Date: Tue, 28 Jul 2020 12:23:59 -0500 [thread overview]
Message-ID: <20200728172359.GA1846504@bjorn-Precision-5520> (raw)
In-Reply-To: <20200728171045.28606-1-krzk@kernel.org>
Patch looks fine, but can you run "git log --oneline drivers/pci/vc.c"
and match the subject line style?
On Tue, Jul 28, 2020 at 07:10:45PM +0200, Krzysztof Kozlowski wrote:
> Fix W=1 compile warnings (invalid kerneldoc):
>
> drivers/pci/vc.c:188: warning: Excess function parameter 'name' description in 'pci_vc_do_save_buffer'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/pci/vc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/vc.c b/drivers/pci/vc.c
> index 5486f8768c86..5fc59ac31145 100644
> --- a/drivers/pci/vc.c
> +++ b/drivers/pci/vc.c
> @@ -172,7 +172,6 @@ static void pci_vc_enable(struct pci_dev *dev, int pos, int res)
> * @dev: device
> * @pos: starting position of VC capability (VC/VC9/MFVC)
> * @save_state: buffer for save/restore
> - * @name: for error message
> * @save: if provided a buffer, this indicates what to do with it
> *
> * Walking Virtual Channel config space to size, save, or restore it
> --
> 2.17.1
>
prev parent reply other threads:[~2020-07-28 17:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 17:10 [PATCH] pci: vc: Fix kerneldoc Krzysztof Kozlowski
2020-07-28 17:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728172359.GA1846504@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.