From: Sebastian Reichel <sre@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: afd@ti.com, pali@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org
Subject: Re: [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561 Battery monitor
Date: Tue, 28 Jul 2020 20:17:55 +0200 [thread overview]
Message-ID: <20200728181755.6bkhp7j3cqtpooof@earth.universe> (raw)
In-Reply-To: <20200728141113.31518-2-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]
Hi,
On Tue, Jul 28, 2020 at 09:11:11AM -0500, Dan Murphy wrote:
> Add the Texas Instruments BQ27561 battery monitor. The register address
> map is laid out the same as compared to other devices within the file.
> The battery status register has differing bits to determine if the
> battery is full, discharging or dead.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
> drivers/power/supply/bq27xxx_battery.c | 68 +++++++++++++++++++++-
> drivers/power/supply/bq27xxx_battery_i2c.c | 2 +
> include/linux/power/bq27xxx_battery.h | 1 +
> 3 files changed, 70 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 942c92127b6d..654d38bcd7e0 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -43,6 +43,7 @@
> * http://www.ti.com/product/bq27411-g1
> * http://www.ti.com/product/bq27441-g1
> * http://www.ti.com/product/bq27621-g1
> + * https://www.ti.com/lit/gpn/bq27z561
Applying this failed, because I applied a patch converting the
http urls to https. I would have fixed this silently, but it made
me notice the chip name is bq27z561 instead of simply bq27561.
You named it without the 'z' everywhere, is there a reason?
Searching for bq27561 basically only finds your patches and
you decided not to drop the z for the bq28z610.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-28 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 14:11 [PATCH v4 1/4] dt-bindings: power: Add BQ27561 compatible Dan Murphy
2020-07-28 14:11 ` [PATCH v4 2/4] power: supply: bq27xxx_battery: Add the BQ27561 Battery monitor Dan Murphy
2020-07-28 18:17 ` Sebastian Reichel [this message]
2020-07-28 18:56 ` Dan Murphy
2020-07-28 14:11 ` [PATCH v4 3/4] dt-bindings: power: Add BQ28z610 compatible Dan Murphy
2020-07-28 14:11 ` [PATCH v4 4/4] power: supply: bq27xxx_battery: Add the BQ28z610 Battery monitor Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728181755.6bkhp7j3cqtpooof@earth.universe \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.