From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8281C433DF for ; Wed, 29 Jul 2020 03:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87A882074B for ; Wed, 29 Jul 2020 03:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbgG2Dia (ORCPT ); Tue, 28 Jul 2020 23:38:30 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:58090 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726245AbgG2Dia (ORCPT ); Tue, 28 Jul 2020 23:38:30 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1k0cv9-0002BV-04; Wed, 29 Jul 2020 13:38:24 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Wed, 29 Jul 2020 13:38:22 +1000 Date: Wed, 29 Jul 2020 13:38:22 +1000 From: Herbert Xu To: Eric Biggers Cc: Ard Biesheuvel , Stephan Mueller , Linux Crypto Mailing List Subject: Re: [v3 PATCH 8/31] crypto: skcipher - Initialise requests to zero Message-ID: <20200729033822.GA8440@gondor.apana.org.au> References: <20200728071746.GA22352@gondor.apana.org.au> <20200728171059.GA4053562@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728171059.GA4053562@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jul 28, 2020 at 10:10:59AM -0700, Eric Biggers wrote: > > Does this really work? Some users allocate memory themselves without using > *_request_alloc(). Yes good point. I will instead add a second request flag used to indicate that we should retain the internal state. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt