All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-kernel@vger.kernel.org, Oded Gabbay <oded.gabbay@gmail.com>,
	Omer Shpigelman <oshpigelman@habana.ai>,
	Tomer Tayar <ttayar@habana.ai>,
	Moti Haimovski <mhaimovski@habana.ai>,
	Ofir Bitton <obitton@habana.ai>, Ben Segal <bpsegal20@gmail.com>,
	Christine Gharzuzi <cgharzuzi@habana.ai>,
	Pawel Piskorski <ppiskorski@habana.ai>
Subject: Re: [PATCH] habanalabs: fix up absolute include instructions
Date: Wed, 29 Jul 2020 07:58:04 +0200	[thread overview]
Message-ID: <20200729055804.GA438924@kroah.com> (raw)
In-Reply-To: <20200729080938.29fc5ef8@canb.auug.org.au>

On Wed, Jul 29, 2020 at 08:09:38AM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> On Tue, 28 Jul 2020 19:18:51 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> >
> > diff --git a/drivers/misc/habanalabs/common/Makefile b/drivers/misc/habanalabs/common/Makefile
> > index 97d03b5c8683..b984bfa4face 100644
> > --- a/drivers/misc/habanalabs/common/Makefile
> > +++ b/drivers/misc/habanalabs/common/Makefile
> > @@ -1,6 +1,4 @@
> >  # SPDX-License-Identifier: GPL-2.0-only
> > -subdir-ccflags-y += -I$(src)/common
> 
> I've seen oter places use
> 
> subdir-ccflags-y += -I$(srcdir)/$(src)/common
> 
> which would probably work as well.  i.e. just change this in the
> Makefiles rather than every source file.

I hate seeing odd ccflags stuff in Makefiles as it can catch you "by
surprise" as to what exactly is happening when looking at .c code.

But yes, your change would also work.

thanks,

greg k-h

  reply	other threads:[~2020-07-29  5:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28 17:18 [PATCH] habanalabs: fix up absolute include instructions Greg Kroah-Hartman
2020-07-28 22:09 ` Stephen Rothwell
2020-07-29  5:58   ` Greg Kroah-Hartman [this message]
2020-07-28 23:27 ` kernel test robot
2020-07-28 23:27   ` kernel test robot
2020-07-29  0:03 ` kernel test robot
2020-07-29  0:03   ` kernel test robot
2020-07-29  0:03 ` [RFC PATCH] habanalabs: goya_ctx_init() can be static kernel test robot
2020-07-29  0:03   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729055804.GA438924@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bpsegal20@gmail.com \
    --cc=cgharzuzi@habana.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhaimovski@habana.ai \
    --cc=obitton@habana.ai \
    --cc=oded.gabbay@gmail.com \
    --cc=oshpigelman@habana.ai \
    --cc=ppiskorski@habana.ai \
    --cc=sfr@canb.auug.org.au \
    --cc=ttayar@habana.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.