From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B5DC433E0 for ; Wed, 29 Jul 2020 06:04:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D9CA207F5 for ; Wed, 29 Jul 2020 06:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbgG2GEF (ORCPT ); Wed, 29 Jul 2020 02:04:05 -0400 Received: from verein.lst.de ([213.95.11.211]:51036 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726047AbgG2GEF (ORCPT ); Wed, 29 Jul 2020 02:04:05 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 72F0968B05; Wed, 29 Jul 2020 08:04:01 +0200 (CEST) Date: Wed, 29 Jul 2020 08:04:01 +0200 From: Christoph Hellwig To: David Miller Cc: hch@lst.de, jengelh@inai.de, idosch@idosch.org, Jason@zx2c4.com, David.Laight@ACULAB.COM, netdev@vger.kernel.org Subject: Re: [PATCH 4/4] net: improve the user pointer check in init_user_sockptr Message-ID: <20200729060401.GD31113@lst.de> References: <20200728063643.396100-1-hch@lst.de> <20200728063643.396100-5-hch@lst.de> <20200728.130111.2163106097158516623.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728.130111.2163106097158516623.davem@davemloft.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 28, 2020 at 01:01:11PM -0700, David Miller wrote: > From: Christoph Hellwig > Date: Tue, 28 Jul 2020 08:36:43 +0200 > > > if (get_user(len, optlen)) > > return -EFAULT; > ^^^^^^^^^^^^^^^^^^^^^^^^^^ > > - err = init_user_sockptr(&optval, user_optval); > > + err = init_user_sockptr(&optval, user_optval, *optlen); > ^^^^^^^^ > > Hmmm? A fixed version was already posted yesterday: https://lore.kernel.org/netdev/20200728163836.562074-1-hch@lst.de/T/#me3e9c7b71e39b4689628ed2e61dec06705344847