From: Marco Felsch <m.felsch@pengutronix.de>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Robin van der Gracht <robin@protonic.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Andreas Pretzsch <apr@cn-eng.de>
Subject: Re: [PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry
Date: Wed, 29 Jul 2020 11:29:01 +0200 [thread overview]
Message-ID: <20200729092901.yfic3vywmnykncod@pengutronix.de> (raw)
In-Reply-To: <23cbd4c0-b53e-d01f-e6d6-b4d2d689bb59@xs4all.nl>
Hi,
On 20-06-25 13:05, Hans Verkuil wrote:
> On 17/09/2019 09:14, Robin van der Gracht wrote:
> > The value for AVID stop is relative to the width of the active video area,
> > not the maximum register value. Zero means equal and a negative value means
> > we're cropping on the right side.
>
> While going through old unreviewed patches I came across this one (sorry Robin,
> your patch fell through the cracks).
>
> Can someone verify/test that this is correct? Marco perhaps?
sorry for my long absence on this. I will test it next week if it is not
already to late.
Regards,
Marco
> Regards,
>
> Hans
>
> >
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > ---
> > drivers/media/i2c/tvp5150.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
> > index f47cb9a023fb..6bc65ab5e8ab 100644
> > --- a/drivers/media/i2c/tvp5150.c
> > +++ b/drivers/media/i2c/tvp5150.c
> > @@ -1231,10 +1231,10 @@ __tvp5150_set_selection(struct v4l2_subdev *sd, struct v4l2_rect rect)
> > regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_ST_LSB,
> > rect.left | (1 << TVP5150_CROP_SHIFT));
> > regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_STP_MSB,
> > - (rect.left + rect.width - TVP5150_MAX_CROP_LEFT) >>
> > + (rect.left + rect.width - TVP5150_H_MAX) >>
> > TVP5150_CROP_SHIFT);
> > regmap_write(decoder->regmap, TVP5150_ACT_VD_CROP_STP_LSB,
> > - rect.left + rect.width - TVP5150_MAX_CROP_LEFT);
> > + rect.left + rect.width - TVP5150_H_MAX);
> > }
> >
> > static int tvp5150_set_selection(struct v4l2_subdev *sd,
> >
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-07-29 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 7:14 [PATCH] media: i2c: tvp5150: Fix horizontal crop stop boundry Robin van der Gracht
2020-06-25 11:05 ` Hans Verkuil
2020-07-29 9:29 ` Marco Felsch [this message]
2020-08-03 7:57 ` robin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729092901.yfic3vywmnykncod@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=apr@cn-eng.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robin@protonic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.