All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jingqi Liu <jingqi.liu@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] docs/nvdimm: add 'pmem=on' for the device dax backend file
Date: Wed, 29 Jul 2020 11:42:41 +0100	[thread overview]
Message-ID: <20200729104241.GE37763@stefanha-x1.localdomain> (raw)
In-Reply-To: <20200715025429.28657-1-jingqi.liu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Wed, Jul 15, 2020 at 10:54:29AM +0800, Jingqi Liu wrote:
> At the end of live migration, QEMU uses msync() to flush the data to
> the backend storage. When the backend file is a character device dax,
> the pages explicitly avoid the page cache. It will return failure from msync().
> The following warning is output.
> 
>     "warning: qemu_ram_msync: failed to sync memory range“
> 
> So we add 'pmem=on' to avoid calling msync(), use the QEMU command line:
> 
>     -object memory-backend-file,id=mem1,pmem=on,mem-path=/dev/dax0.0,size=4G
> 
> Signed-off-by: Jingqi Liu <jingqi.liu@intel.com>
> ---
>  docs/nvdimm.txt | 7 +++++++
>  1 file changed, 7 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-07-29 10:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  2:54 [PATCH] docs/nvdimm: add 'pmem=on' for the device dax backend file Jingqi Liu
2020-07-24  7:15 ` Liu, Jingqi
2020-07-28  1:09 ` Liu, Jingqi
2020-07-29 10:42 ` Stefan Hajnoczi [this message]
2020-07-30  1:02 Jingqi Liu
2020-07-30  5:07 ` Pankaj Gupta
2020-08-03  0:35 Jingqi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729104241.GE37763@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=jingqi.liu@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xiaoguangrong.eric@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.