From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E8EEC433DF for ; Wed, 29 Jul 2020 19:09:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA3CC2075F for ; Wed, 29 Jul 2020 19:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596049741; bh=rbpV2qp3er29+JB9rip/TW1FjAAjVqLcfYeXHXwZePU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=atsfcnC8nF0HFO0M8hGfTm0LnbBYSVmjaIqLpKFehXnalOJCjKFDD/t8b8RHOLKKa VpuqZnJXo9gA8QBH2Vgntw826aI4Gfh0uvj+L2ggXaOjwaVSNAuCkEVLAQwMg08cDr J4ao8kPzv0NAV5F7NOBF0uVbkzohV4aURw4Rb+Dw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgG2TI7 convert rfc822-to-8bit (ORCPT ); Wed, 29 Jul 2020 15:08:59 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:38955 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgG2TI6 (ORCPT ); Wed, 29 Jul 2020 15:08:58 -0400 Received: by mail-ej1-f67.google.com with SMTP id f24so4972711ejx.6; Wed, 29 Jul 2020 12:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Kk6GZ/lJmAXVSU51HkWJo7PA9w7q1gYfnsyVr0WMPOk=; b=JLMz2iC/vIPVcWWEm4JrUKpTuusef8Vp/EgxzHIqjTRyD4XJ3GUnlMaun8M/Jq/Peo YsR5JQ9XKUHfb4lZwLrt2aFCgWs+iwZGyxTJgIfqaAsCRie/kLQ6/8r+foY0mG+ezcLD zVgT5fO5KoHXE0XpkqzTUI5YB39q69Kl3McHzaMbCJhpTYlH9eQ29nSt0CUxb0Xa93NI Upa+TZivwyME//onZqU9B4Tfv69Rs7ha5FiFK77w0nG4utKXX2oJLZbQA+C3sA7TP/jx HVyCAEM6yXlOZXsrL9UDt27rHAE4CW5yMSpLcVPkpejpexhHYMfAhuYPDZQqUqESpnPl /ikg== X-Gm-Message-State: AOAM533P9pkJ+1eDzMCIzKbOUX0WgS3tNOpRjVs4eDAu7wajH9dBS+Vt 3kGYKAP2ttdGI2/XcgZvGrA= X-Google-Smtp-Source: ABdhPJy+cd4Zv9RClGXMrb12WPzglxJiIigi0VSAL6EF6L9FGlqR/jQZQ2fHi+OZEEkZV03WOmvLzQ== X-Received: by 2002:a17:906:6d4d:: with SMTP id a13mr31002287ejt.146.1596049736098; Wed, 29 Jul 2020 12:08:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id m5sm2616809edr.59.2020.07.29.12.08.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 12:08:55 -0700 (PDT) Date: Wed, 29 Jul 2020 21:08:52 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Cc: Guenter Roeck , Russell King , Kukjin Kim , Vincent Sanders , Simtec Linux Team , Kyungmin Park , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Wim Van Sebroeck , Arnd Bergmann , Linus Walleij , linux-kernel , linux-arm-kernel , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, "open list:COMMON CLK FRAMEWORK" , linux-watchdog@vger.kernel.org, Sergio Prado , Marek Szyprowski , Sylwester Nawrocki , Cedric Roux , Lihua Yao Subject: Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG Message-ID: <20200729190852.GA5822@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-6-krzk@kernel.org> <20200729170245.GA177035@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 07:36:38PM +0200, Tomasz Figa wrote: > 2020年7月29日(水) 19:02 Guenter Roeck : > > > > On Wed, Jul 29, 2020 at 06:09:40PM +0200, Krzysztof Kozlowski wrote: > > > A separate Kconfig option HAVE_S3C2410_WATCHDOG for Samsung SoCs does > > > not have sense, because: > > > 1. All ARMv7 and ARMv8 Samsung SoCs have watchdog, > > > 2. All architecture Kconfigs were selecting it (if WATCHDOG framework is > > > chosen), > > > 3. HAVE_S3C2410_WATCHDOG is doing nothing except being a dependency of > > > actual Samsung SoC watchdog driver, which is enabled manually by > > > specific defconfigs. > > > > > > HAVE_S3C2410_WATCHDOG can be safely removed. > > > > > > > That is not really correct. HAVE_S3C2410_WATCHDOG is used to ensure > > that users can only enable S3C2410_WATCHDOG if the watchdog actually > > exists in a system. With this change, it can be enabled for all > > architectures and platforms. > > > > NACK. > > > > Guenter > > > > I'd side with Guenter on this. We better not flood users' screens with > options that are not relevant to their hardware. > > An alternative here could be making CONFIG_S3C2410_WATCHDOG depend on > a general symbol for Samsung SoC support if there is such, but then, > are we 100% sure that all the Samsung SoCs would actually have exactly > this watchdog? If a new one shows up, one would have to bring back > this HAVE_S3C2410_WATCHDOG symbol. Ah, good points. Indeed for all of such SoC drivers we usually just depend on architecture to limit the choices on other architectures. In this case it would be: depends on ARCH_EXYNOS || ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210 || COMPILE_TEST I admit it is pretty long, but we already use this pattern. In shorter version (less ARCH*) for all drivers, in full version also in: drivers/iio/adc/Kconfig drivers/gpu/drm/exynos/Kconfig Have in mind that in general we follow the first approach and only three drivers have still the HAVE_xxx option (also HAVE_S3C2410_I2C and HAVE_S3C_RTC). I can update therefore the "depends" while removing the HAVE_S3C2410_WATCHDOG option or just keep it. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F0EC433DF for ; Wed, 29 Jul 2020 19:10:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7996C2075D for ; Wed, 29 Jul 2020 19:10:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RtebhMvt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7996C2075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OWGjI8w76U/Dv84gEiOA5xNc3+8CfNrutwhK29H0KEc=; b=RtebhMvtAem2D8Ipm1fe+KACG pidVzwfDyfvb9sdbnHqKeRZLjR+bYr7VuaBxt+nYs1uRiWC7BqJyw5YUMkbdNGIXMHieUkNt7GGqX SXlHVsmNmEdj09v+FGe+AsuzH27Qrxcmm8GzbQ1nntkC93Uth5GJzTtISUeFLT7LbXY/SP6CQE+eC IxLEcUc2oYZBtOx8SEMWUlIkLclD/u1KKnttcRNLKHDn9h/f6tbX9GJkf3LX0NRPuaIVMSAHZKGr1 bBIJOR2d68KLMAcAzL/In0zRSSD4tXQvK17PE6MKU9zREtbQtdgUYR0lYHOAfdoQAmgx6ZFCsaC3i sfiBsYmug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0rRk-0003j3-8x; Wed, 29 Jul 2020 19:09:00 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0rRh-0003iJ-9C for linux-arm-kernel@lists.infradead.org; Wed, 29 Jul 2020 19:08:58 +0000 Received: by mail-ej1-f65.google.com with SMTP id bo3so2831537ejb.11 for ; Wed, 29 Jul 2020 12:08:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Kk6GZ/lJmAXVSU51HkWJo7PA9w7q1gYfnsyVr0WMPOk=; b=NsI8slt28jRM/2EjZzH6pAo9pHeUuKrNFT7PvzcOeFPBRt5w+CibiBHSyI5pHXmseC lA16nCgJqR4Ple9F7NBx1DnXlqyjoqNrk6aInIW34lZvtPw62wdgwdeHPOkOdNOjk0GY FSeIHwO6EpmM2AXpfgBsMiJpM27vmizT6y3CQC6TIskaD8DsalI6DNIQmOGui2sVnjJn rMcLscEs0FnYUVDy4QIe9IPYIxJEsQdV7ByA7X0OwbRb7dQTHG0tGrUmKpG/IuXJcyGH iodh+RLHUk/zjH/kmjQcsu6cUvGoucN22TWGfmqcv/ySMsRWQQd08EE0LtVlZ8qU5Dal YsxQ== X-Gm-Message-State: AOAM533lozkancGNZUUv3muoBJhkWRzuLqADcNHCB1YSS7iOOiVhWs+3 nF8pJ2296OT8cr+2e1YY6s0= X-Google-Smtp-Source: ABdhPJy+cd4Zv9RClGXMrb12WPzglxJiIigi0VSAL6EF6L9FGlqR/jQZQ2fHi+OZEEkZV03WOmvLzQ== X-Received: by 2002:a17:906:6d4d:: with SMTP id a13mr31002287ejt.146.1596049736098; Wed, 29 Jul 2020 12:08:56 -0700 (PDT) Received: from kozik-lap ([194.230.155.213]) by smtp.googlemail.com with ESMTPSA id m5sm2616809edr.59.2020.07.29.12.08.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 29 Jul 2020 12:08:55 -0700 (PDT) Date: Wed, 29 Jul 2020 21:08:52 +0200 From: Krzysztof Kozlowski To: Tomasz Figa Subject: Re: [PATCH 5/7] ARM: samsung: Kill useless HAVE_S3C2410_WATCHDOG Message-ID: <20200729190852.GA5822@kozik-lap> References: <20200729160942.28867-1-krzk@kernel.org> <20200729160942.28867-6-krzk@kernel.org> <20200729170245.GA177035@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200729_150857_831580_3AB9F537 X-CRM114-Status: GOOD ( 26.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Linus Walleij , Sylwester Nawrocki , Will Deacon , linux-stm32@st-md-mailman.stormreply.com, Marek Szyprowski , "moderated list:SAMSUNG SOC CLOCK DRIVERS" , Sylwester Nawrocki , Cedric Roux , Russell King , "open list:COMMON CLK FRAMEWORK" , Lihua Yao , Chanwoo Choi , Kukjin Kim , Michael Turquette , Guenter Roeck , Sergio Prado , linux-watchdog@vger.kernel.org, Arnd Bergmann , Wim Van Sebroeck , Simtec Linux Team , linux-arm-kernel , Stephen Boyd , patches@opensource.cirrus.com, Vincent Sanders , linux-kernel , Kyungmin Park Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMjksIDIwMjAgYXQgMDc6MzY6MzhQTSArMDIwMCwgVG9tYXN6IEZpZ2Egd3Jv dGU6Cj4gMjAyMOW5tDfmnIgyOeaXpSjmsLQpIDE5OjAyIEd1ZW50ZXIgUm9lY2sgPGxpbnV4QHJv ZWNrLXVzLm5ldD46Cj4gPgo+ID4gT24gV2VkLCBKdWwgMjksIDIwMjAgYXQgMDY6MDk6NDBQTSAr MDIwMCwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+ID4gQSBzZXBhcmF0ZSBLY29uZmln IG9wdGlvbiBIQVZFX1MzQzI0MTBfV0FUQ0hET0cgZm9yIFNhbXN1bmcgU29DcyBkb2VzCj4gPiA+ IG5vdCBoYXZlIHNlbnNlLCBiZWNhdXNlOgo+ID4gPiAxLiBBbGwgQVJNdjcgYW5kIEFSTXY4IFNh bXN1bmcgU29DcyBoYXZlIHdhdGNoZG9nLAo+ID4gPiAyLiBBbGwgYXJjaGl0ZWN0dXJlIEtjb25m aWdzIHdlcmUgc2VsZWN0aW5nIGl0IChpZiBXQVRDSERPRyBmcmFtZXdvcmsgaXMKPiA+ID4gICAg Y2hvc2VuKSwKPiA+ID4gMy4gSEFWRV9TM0MyNDEwX1dBVENIRE9HIGlzIGRvaW5nIG5vdGhpbmcg ZXhjZXB0IGJlaW5nIGEgZGVwZW5kZW5jeSBvZgo+ID4gPiAgICBhY3R1YWwgU2Ftc3VuZyBTb0Mg d2F0Y2hkb2cgZHJpdmVyLCB3aGljaCBpcyBlbmFibGVkIG1hbnVhbGx5IGJ5Cj4gPiA+ICAgIHNw ZWNpZmljIGRlZmNvbmZpZ3MuCj4gPiA+Cj4gPiA+IEhBVkVfUzNDMjQxMF9XQVRDSERPRyBjYW4g YmUgc2FmZWx5IHJlbW92ZWQuCj4gPiA+Cj4gPgo+ID4gVGhhdCBpcyBub3QgcmVhbGx5IGNvcnJl Y3QuIEhBVkVfUzNDMjQxMF9XQVRDSERPRyBpcyB1c2VkIHRvIGVuc3VyZQo+ID4gdGhhdCB1c2Vy cyBjYW4gb25seSBlbmFibGUgUzNDMjQxMF9XQVRDSERPRyBpZiB0aGUgd2F0Y2hkb2cgYWN0dWFs bHkKPiA+IGV4aXN0cyBpbiBhIHN5c3RlbS4gV2l0aCB0aGlzIGNoYW5nZSwgaXQgY2FuIGJlIGVu YWJsZWQgZm9yIGFsbAo+ID4gYXJjaGl0ZWN0dXJlcyBhbmQgcGxhdGZvcm1zLgo+ID4KPiA+IE5B Q0suCj4gPgo+ID4gR3VlbnRlcgo+ID4KPiAKPiBJJ2Qgc2lkZSB3aXRoIEd1ZW50ZXIgb24gdGhp cy4gV2UgYmV0dGVyIG5vdCBmbG9vZCB1c2Vycycgc2NyZWVucyB3aXRoCj4gb3B0aW9ucyB0aGF0 IGFyZSBub3QgcmVsZXZhbnQgdG8gdGhlaXIgaGFyZHdhcmUuCj4gCj4gQW4gYWx0ZXJuYXRpdmUg aGVyZSBjb3VsZCBiZSBtYWtpbmcgQ09ORklHX1MzQzI0MTBfV0FUQ0hET0cgZGVwZW5kIG9uCj4g YSBnZW5lcmFsIHN5bWJvbCBmb3IgU2Ftc3VuZyBTb0Mgc3VwcG9ydCBpZiB0aGVyZSBpcyBzdWNo LCBidXQgdGhlbiwKPiBhcmUgd2UgMTAwJSBzdXJlIHRoYXQgYWxsIHRoZSBTYW1zdW5nIFNvQ3Mg d291bGQgYWN0dWFsbHkgaGF2ZSBleGFjdGx5Cj4gdGhpcyB3YXRjaGRvZz8gSWYgYSBuZXcgb25l IHNob3dzIHVwLCBvbmUgd291bGQgaGF2ZSB0byBicmluZyBiYWNrCj4gdGhpcyBIQVZFX1MzQzI0 MTBfV0FUQ0hET0cgc3ltYm9sLgoKQWgsIGdvb2QgcG9pbnRzLiBJbmRlZWQgZm9yIGFsbCBvZiBz dWNoIFNvQyBkcml2ZXJzIHdlIHVzdWFsbHkganVzdApkZXBlbmQgb24gYXJjaGl0ZWN0dXJlIHRv IGxpbWl0IHRoZSBjaG9pY2VzIG9uIG90aGVyIGFyY2hpdGVjdHVyZXMuCkluIHRoaXMgY2FzZSBp dCB3b3VsZCBiZToKICAgIGRlcGVuZHMgb24gQVJDSF9FWFlOT1MgfHwgQVJDSF9TM0MyNFhYIHx8 IEFSQ0hfUzNDNjRYWCB8fCBBUkNIX1M1UFYyMTAgfHwgQ09NUElMRV9URVNUCgpJIGFkbWl0IGl0 IGlzIHByZXR0eSBsb25nLCBidXQgd2UgYWxyZWFkeSB1c2UgdGhpcyBwYXR0ZXJuLiBJbiBzaG9y dGVyCnZlcnNpb24gKGxlc3MgQVJDSCopIGZvciBhbGwgZHJpdmVycywgaW4gZnVsbCB2ZXJzaW9u IGFsc28gaW46CmRyaXZlcnMvaWlvL2FkYy9LY29uZmlnCmRyaXZlcnMvZ3B1L2RybS9leHlub3Mv S2NvbmZpZwoKSGF2ZSBpbiBtaW5kIHRoYXQgaW4gZ2VuZXJhbCB3ZSBmb2xsb3cgdGhlIGZpcnN0 IGFwcHJvYWNoIGFuZCBvbmx5IHRocmVlCmRyaXZlcnMgaGF2ZSBzdGlsbCB0aGUgSEFWRV94eHgg b3B0aW9uIChhbHNvIEhBVkVfUzNDMjQxMF9JMkMgYW5kCkhBVkVfUzNDX1JUQykuCgpJIGNhbiB1 cGRhdGUgdGhlcmVmb3JlIHRoZSAiZGVwZW5kcyIgd2hpbGUgcmVtb3ZpbmcgdGhlCkhBVkVfUzND MjQxMF9XQVRDSERPRyBvcHRpb24gb3IganVzdCBrZWVwIGl0LgoKQmVzdCByZWdhcmRzLApLcnp5 c3p0b2YKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==