From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBA0C433E0 for ; Wed, 29 Jul 2020 19:51:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C2202064B for ; Wed, 29 Jul 2020 19:51:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=irrelevant.dk header.i=@irrelevant.dk header.b="bmZn8xcK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C2202064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0s6T-0003DW-I6 for qemu-devel@archiver.kernel.org; Wed, 29 Jul 2020 15:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0s5Q-00021L-RV; Wed, 29 Jul 2020 15:50:01 -0400 Received: from charlie.dont.surf ([128.199.63.193]:34386) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0s5O-0007GY-V0; Wed, 29 Jul 2020 15:50:00 -0400 Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by charlie.dont.surf (Postfix) with ESMTPSA id 09DD3BF616; Wed, 29 Jul 2020 19:49:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=irrelevant.dk; s=default; t=1596052196; bh=y7/j5dCp1hTkN/mNt+1TruYCNBHa8LozMpG+mfzV4bc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bmZn8xcK+r7grY8D7EmSSomrypnois5Q3oLlXq2E0NdwffVBoj99iQQ0LfaIgPLza BfNi2EqL0MHODc4/L6YuncqCBNINHnmwhRNrwkWn+ARsB0CgIX7kfreKPCHT18viv8 +mBShFZgyssOCe9OH8PLAdHAyig39jt3JqZv8tT0edYXwDZPCMUfHjOAPv7FjPt5kh rUydd5xh9fdByCeMO4hAFTn47qJwNOQn5HL0d4BFDrhc4Xs/Wk+k4cpcL2iSSHVTWf 4/VwJqnP4uCvaKiRUi7X23/QysW+BJlGrAoGF+pokupKoEIM/2anNmfwghgZbKfz5x pQJjjllHVqNqw== Date: Wed, 29 Jul 2020 21:49:54 +0200 From: Klaus Jensen To: Minwoo Im Subject: Re: [PATCH 06/16] hw/block/nvme: pass request along for tracing Message-ID: <20200729194954.GC293496@apples.localdomain> References: <20200720113748.322965-1-its@irrelevant.dk> <20200720113748.322965-7-its@irrelevant.dk> <20200729154936.GE14876@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200729154936.GE14876@localhost.localdomain> Received-SPF: pass client-ip=128.199.63.193; envelope-from=its@irrelevant.dk; helo=charlie.dont.surf X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 14:23:15 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Maxim Levitsky Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Jul 30 00:49, Minwoo Im wrote: > Klaus, > > On 20-07-20 13:37:38, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Pass along the NvmeRequest in various functions since it is very useful > > for tracing. > > One doubt here. > This patch has put NvmeRequest argument to the nvme_map_prp() to trace > the request's command id. But can we just trace the cid before this > kind of prp mapping, somewhere like nvme_process_sq() level. Then we > can figure out the tracing for the prp mapping is from which request. > > Tracing for cid is definitely great, but feels like too much cost to > pass argument to trace 'cid' in the middle of the dma mapping stage. > Good point Minwoo. I ended up dropping the patch and just replacing it with a patch that adds tracing to nvme_map_prp.