From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4CEC433E0 for ; Wed, 29 Jul 2020 20:07:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD4F720658 for ; Wed, 29 Jul 2020 20:07:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ISrlF6kh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgG2UHK (ORCPT ); Wed, 29 Jul 2020 16:07:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:20495 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726645AbgG2UHK (ORCPT ); Wed, 29 Jul 2020 16:07:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596053229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TetWfEfY/6XryPkTZ6kYeEY9wBFtpZgH4Dbq4eezLjs=; b=ISrlF6khWgCWca3SNU8tJqGnSZ111DKLiwAjFYF4a6yJ0TwZzVhMitxEXdXkF0Jq69tg3y 2mJQLZycwhsIS6twY3a7rqH6MdmEKUoaK0qElSx6hEC1q8ZMSPsabzaluyiKN7RFhHHXFQ f63+ctwGaRfXoUJQdNol1vNoINf+xIY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-GBofMUcCPTy2b52YpO_dSA-1; Wed, 29 Jul 2020 16:07:04 -0400 X-MC-Unique: GBofMUcCPTy2b52YpO_dSA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29E27102C7F1; Wed, 29 Jul 2020 20:07:02 +0000 (UTC) Received: from krava (unknown [10.40.193.247]) by smtp.corp.redhat.com (Postfix) with SMTP id BF13519C71; Wed, 29 Jul 2020 20:06:58 +0000 (UTC) Date: Wed, 29 Jul 2020 22:06:57 +0200 From: Jiri Olsa To: Andrii Nakryiko Cc: Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , bpf , Song Liu , Yonghong Song , Martin KaFai Lau , David Miller , John Fastabend , Wenbo Zhang , KP Singh , Brendan Gregg , Florent Revest , Al Viro Subject: Re: [PATCH v8 bpf-next 01/13] selftests/bpf: Fix resolve_btfids test Message-ID: <20200729200657.GP1319041@krava> References: <20200722211223.1055107-1-jolsa@kernel.org> <20200722211223.1055107-2-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Jul 28, 2020 at 01:27:49PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 22, 2020 at 2:13 PM Jiri Olsa wrote: > > > > The linux/btf_ids.h header is now using CONFIG_DEBUG_INFO_BTF > > config, so we need to have it defined when it's available. > > > > Signed-off-by: Jiri Olsa > > --- > > sure, why not actually after rebase I realized Yonghong added CONFIG_DEBUG_INFO_BTF define in: d8dfe5bfe856 ("tools/bpf: Sync btf_ids.h to tools") I think including 'autoconf.h' is more clean, on the other hand I don't think we'd get clean selftest compile without CONFIG_DEBUG_INFO_BTF should we keep the #define instead? thanks, jirka > > Acked-by: Andrii Nakryiko > > > tools/testing/selftests/bpf/prog_tests/resolve_btfids.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c > > index 3b127cab4864..101785b49f7e 100644 > > --- a/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c > > +++ b/tools/testing/selftests/bpf/prog_tests/resolve_btfids.c > > @@ -1,5 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0 > > > > +#include "autoconf.h" > > #include > > #include > > #include > > -- > > 2.25.4 > > >