All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Bryan.Whitehead@microchip.com
Cc: netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
	andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
	linux@armlinux.org.uk
Subject: Re: [PATCH v2 net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy drivers
Date: Thu, 30 Jul 2020 16:36:17 -0700 (PDT)	[thread overview]
Message-ID: <20200730.163617.337691110259436047.davem@davemloft.net> (raw)
In-Reply-To: <1595870308-19041-1-git-send-email-Bryan.Whitehead@microchip.com>

From: Bryan Whitehead <Bryan.Whitehead@microchip.com>
Date: Mon, 27 Jul 2020 13:18:28 -0400

> @@ -929,6 +929,77 @@ static bool vsc8574_is_serdes_init(struct phy_device *phydev)
>  }
>  
>  /* bus->mdio_lock should be locked when using this function */
> +/* Page should already be set to MSCC_PHY_PAGE_EXTENDED_GPIO */
> +static int vsc8574_micro_command(struct phy_device *phydev, u16 command)
 ...
> +/* bus->mdio_lock should be locked when using this function */

Please don't dup this comment, it's not appropriate.

Thank you.

  reply	other threads:[~2020-07-30 23:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 17:18 [PATCH v2 net-next] mscc: Add LCPLL Reset to VSC8574 Family of phy drivers Bryan Whitehead
2020-07-30 23:36 ` David Miller [this message]
2020-07-30 23:40   ` Florian Fainelli
2020-07-31 15:09     ` Bryan.Whitehead

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200730.163617.337691110259436047.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Bryan.Whitehead@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.