From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E21C4C433DF for ; Thu, 30 Jul 2020 09:06:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF84D2082E for ; Thu, 30 Jul 2020 09:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596099985; bh=ieC3UQSH9xTQQlFP1mBTpQK8Jaet0JuMdqnPvTiLzSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qoFy0vxyLrAlJNjBR4L7bORTtUrYq+Aa465dQQ1D7mQRdrfK0YSqFRRj6FqmiZh5l 7Yl2+KCa/X/miLMQnYSrRRN7Bw0Us5Aa4xlCgATeFxsQaZwfJ3Y5k6VXFqwG6fAyOu /OWtovkMn2lM1Q+6x0ucUt/rt0UuOK2zbLUnBnZs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729302AbgG3JGY (ORCPT ); Thu, 30 Jul 2020 05:06:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:42144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728528AbgG3JGX (ORCPT ); Thu, 30 Jul 2020 05:06:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFDC92072A; Thu, 30 Jul 2020 09:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596099983; bh=ieC3UQSH9xTQQlFP1mBTpQK8Jaet0JuMdqnPvTiLzSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z/OlMNCjgJjVCDEAUFFVbS7j9qnE79NsrCIar3YE+oLzkykZo4SyLPjtjBmvhhkcD T9PkgtjWLgbnsiDPD6gD6YwuUd+7hajjK66mABoLrTUlc/yFV744DxvWyv+/e12Zv2 o7cXTtiuU4bHGqJbB2DKVrNBS9iI30MBTfDZpeMY= Date: Thu, 30 Jul 2020 11:06:12 +0200 From: Greg KH To: madvenka@linux.microsoft.com Cc: kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, oleg@redhat.com, x86@kernel.org Subject: Re: [PATCH v1 2/4] [RFC] x86/trampfd: Provide support for the trampoline file descriptor Message-ID: <20200730090612.GA900546@kroah.com> References: <20200728131050.24443-1-madvenka@linux.microsoft.com> <20200728131050.24443-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200728131050.24443-3-madvenka@linux.microsoft.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2020 at 08:10:48AM -0500, madvenka@linux.microsoft.com wrote: > +EXPORT_SYMBOL_GPL(trampfd_valid_regs); Why are all of these exported? I don't see a module user in this series, or did I miss it somehow? EXPORT_SYMBOL* is only needed for symbols to be used by modules, not by code that is built into the kernel. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71ACC433DF for ; Thu, 30 Jul 2020 09:07:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8EAA2072A for ; Thu, 30 Jul 2020 09:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JqRVAToj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z/OlMNCj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8EAA2072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jp6Dcw3Z7XjDewfhj5Qbwvi5nwTo0LsW9kG00x3BoQg=; b=JqRVATojzXM2bxVJjmtLlSuun WPI7Jxhl5p/jcd07vjDcVyPyh3ARCQiX23DRriNXkziDf7eBcifbRSryXOVtrx7T2DArjcj5XQZjl JoUTktMjw3D0oRvUiHrsaZ/sTvLRdl2UhwUXI9C3tWJI7WqGZMMMApceAyjYAE+ec1K9WzCpTOUTM SYUUT5RgXdYOAKu9IapBBIoe7pjZh5hgzyS9hPig+10hmKSSQPqIMs3Hnq0Ja3F9pzsFSH2AX10ip TS1cmiLWvRn7vLFfsZkZ6CnwM+JGk6PO3UoYMb28SHyZfALdplYmYxx7WMlEmCiwIKrWFBY3DBMar oifOvZ4MA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k14WB-0002MY-0O; Thu, 30 Jul 2020 09:06:27 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k14W8-0002LG-Bk for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2020 09:06:25 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CFDC92072A; Thu, 30 Jul 2020 09:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596099983; bh=ieC3UQSH9xTQQlFP1mBTpQK8Jaet0JuMdqnPvTiLzSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Z/OlMNCjgJjVCDEAUFFVbS7j9qnE79NsrCIar3YE+oLzkykZo4SyLPjtjBmvhhkcD T9PkgtjWLgbnsiDPD6gD6YwuUd+7hajjK66mABoLrTUlc/yFV744DxvWyv+/e12Zv2 o7cXTtiuU4bHGqJbB2DKVrNBS9iI30MBTfDZpeMY= Date: Thu, 30 Jul 2020 11:06:12 +0200 From: Greg KH To: madvenka@linux.microsoft.com Subject: Re: [PATCH v1 2/4] [RFC] x86/trampfd: Provide support for the trampoline file descriptor Message-ID: <20200730090612.GA900546@kroah.com> References: <20200728131050.24443-1-madvenka@linux.microsoft.com> <20200728131050.24443-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200728131050.24443-3-madvenka@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200730_050624_523827_F8450B21 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, oleg@redhat.com, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 28, 2020 at 08:10:48AM -0500, madvenka@linux.microsoft.com wrote: > +EXPORT_SYMBOL_GPL(trampfd_valid_regs); Why are all of these exported? I don't see a module user in this series, or did I miss it somehow? EXPORT_SYMBOL* is only needed for symbols to be used by modules, not by code that is built into the kernel. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel