From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E317BC433E0 for ; Thu, 30 Jul 2020 15:27:32 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE7972082E for ; Thu, 30 Jul 2020 15:27:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE7972082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5553E203D9; Thu, 30 Jul 2020 15:27:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IR7Xs6oYidMb; Thu, 30 Jul 2020 15:27:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id EA12C20395; Thu, 30 Jul 2020 15:27:29 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D5B231BF3F6 for ; Thu, 30 Jul 2020 15:27:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D1C3B86BA3 for ; Thu, 30 Jul 2020 15:27:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id awrnUmYAczZR for ; Thu, 30 Jul 2020 15:27:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 5A2D786B89 for ; Thu, 30 Jul 2020 15:27:27 +0000 (UTC) IronPort-SDR: iysZfWlEFnrHyOD1iF21KuzNXCRuiY72Ks5tWRvOz7MCC3Zt+5poeBHD2qRy61mkNrHiUlModx L+TpmtlajvWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="213153621" X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="213153621" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 08:27:26 -0700 IronPort-SDR: g26yV/Su8scGfgM7S0/8ZPISJHutMfb1t1jnXeOJyXX3Naq2QYt6irX9HUQsLHTPvr8f9Yacrr zCXStoHCMcTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,414,1589266800"; d="scan'208";a="290912874" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 30 Jul 2020 08:27:25 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A8375119; Thu, 30 Jul 2020 18:27:24 +0300 (EEST) From: Andy Shevchenko To: Sven Van Asbroeck , devel@driverdev.osuosl.org, Greg Kroah-Hartman Subject: [PATCH v1] staging: fieldbus: Use %pM format specifier for MAC addresses Date: Thu, 30 Jul 2020 18:27:24 +0300 Message-Id: <20200730152724.39250-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Convert to %pM instead of using custom code. While here, replace one time use structure by buffer on stack. Signed-off-by: Andy Shevchenko --- drivers/staging/fieldbus/anybuss/hms-profinet.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/staging/fieldbus/anybuss/hms-profinet.c b/drivers/staging/fieldbus/anybuss/hms-profinet.c index 31c43a0a5776..505480fb281d 100644 --- a/drivers/staging/fieldbus/anybuss/hms-profinet.c +++ b/drivers/staging/fieldbus/anybuss/hms-profinet.c @@ -26,10 +26,6 @@ * exactly as advertised. */ -struct msg_mac_addr { - u8 addr[6]; -}; - struct profi_priv { struct fieldbus_dev fbdev; struct anybuss_client *client; @@ -59,17 +55,13 @@ static int profi_id_get(struct fieldbus_dev *fbdev, char *buf, size_t max_size) { struct profi_priv *priv = container_of(fbdev, struct profi_priv, fbdev); - struct msg_mac_addr response; + u8 mac[ETH_ALEN]; int ret; - ret = anybuss_recv_msg(priv->client, 0x0010, &response, - sizeof(response)); + ret = anybuss_recv_msg(priv->client, 0x0010, &mac, sizeof(mac)); if (ret < 0) return ret; - return snprintf(buf, max_size, "%02X:%02X:%02X:%02X:%02X:%02X\n", - response.addr[0], response.addr[1], - response.addr[2], response.addr[3], - response.addr[4], response.addr[5]); + return snprintf(buf, max_size, "%pM\n", mac); } static bool profi_enable_get(struct fieldbus_dev *fbdev) -- 2.27.0 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel