From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1k1G7E-0005Ac-2O for mharc-grub-devel@gnu.org; Thu, 30 Jul 2020 17:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58052) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1G7C-0005AW-Ke for grub-devel@gnu.org; Thu, 30 Jul 2020 17:29:26 -0400 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:54226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k1G7A-00042M-G0 for grub-devel@gnu.org; Thu, 30 Jul 2020 17:29:26 -0400 Received: by mail-pj1-x1042.google.com with SMTP id a9so5357477pjd.3 for ; Thu, 30 Jul 2020 14:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=AqCSflY6HzEDyIWi0bEWwGUwpQbPaXYhLNvARvHiHDs=; b=KjUsU5aRZr4YRJ9HPZHsQTF61lP+u0ty7uV0sKVRse874Iy+MIfWoDJwicTUqOLZzI Vxq5Pf+mXG9XAj6Aj4QWlesfuy/8z0hvSNWYVg9hqcj8KYSE7r1VMxV7UapEeSUliJs/ 8DMOXJ58MmBH2mG4cK6bI6KbH3MMXZhkLDTfrkeffNsbkzXLigHyEvoFw6eibKbnjGj2 iJDgwrxSyHOlxcmS8+sDFsfl467UxkkgFxb5Zh6R+u8fQU1SDKPf0dlCYBWqB7OvLepq U/9LezzSE14P4/UgtkY6Yox6QZbTCiVb9ym51zHmErk5m3bnVN1YxKhPVs7vWBdeIE4f KNkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=AqCSflY6HzEDyIWi0bEWwGUwpQbPaXYhLNvARvHiHDs=; b=cJ+MDS8JWiSufnGkyefcuh0vUI20RrO2BiYBczjeqxjKR3gZlgmKtiQ4YUb32wJBJu 3IvAEGPONsV39zpWf5YsBKNMwUxH2SUSPcsnDhof2w6ZAVnx0BY6DqkSkguVrjDiD743 wCbrunzt45wFArNCJ2Qa4LKUAutj0EgXFA4yXht5CuP5jj1cpKuwTt3/OHGQGZf4r9ma 9siprYQv6WGVZiDSZq1z6kGomFfUpLQ9r34swp3586qU4rbba0qFUC05GbmJlkVxBeFW +K5jnL+Pgwn0VBVUq8lrjQK29kouHgLDOruTEuRMr5agqQaxdIy16AVbCXFpBkFtVvBX YBvw== X-Gm-Message-State: AOAM532xLSW+ZdFYrF4AUf+6E83hWjKOswbM9r7fHPE5KfNGEdMvcO2b ypbxERo0zjVxsLJ9ohrYVt5HRQ== X-Google-Smtp-Source: ABdhPJwkCOwXYnnCxwjjC8EfRABjVFKWAB5kMaBIdxPyy0BAVj9yaObCy6KyLJjMVgd6EgWKKJc3eg== X-Received: by 2002:a63:955c:: with SMTP id t28mr801344pgn.18.1596144562827; Thu, 30 Jul 2020 14:29:22 -0700 (PDT) Received: from crass-HP-ZBook-15-G2 ([189.216.105.24]) by smtp.gmail.com with ESMTPSA id x67sm1781507pfd.81.2020.07.30.14.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 14:29:22 -0700 (PDT) Date: Thu, 30 Jul 2020 16:29:09 -0500 From: Glenn Washburn To: Patrick Steinhardt Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH 07/17] cryptodisk,luks: Allow special processing for comparing UUIDs. Message-ID: <20200730162909.1eeef46c@crass-HP-ZBook-15-G2> In-Reply-To: <20200730152412.GC39309@tanuki.pks.im> References: <20200730152412.GC39309@tanuki.pks.im> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1042; envelope-from=development@efficientek.com; helo=mail-pj1-x1042.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 21:29:27 -0000 On Thu, 30 Jul 2020 17:24:12 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:12PM -0500, development@efficientek.com > wrote: > > From: Glenn Washburn > > > > Create grub_uuidcasecmp to compare UUIDs in a case-insensitive > > manner and that ignores '-' characters. This is backwards > > compatible with the old LUKS1 code that stored and compared against > > UUIDs without dashes. However, the new LUKS2 code stores and > > compares UUIDs that contain dashes. Really, the UUID comparison > > shouldn't care about the dashes, as this change implements. Now > > your old scripts will continue to work with UUIDs without dashes, > > but you may choose to use UUIDs with dashes now too for both LUKS1 > > and LUKS2. > > FYI, this is crossing with my own patchset to implement probing > support for LUKS2 [1]. I do like that we start becoming agnostic of > those dashes now, though, as it really is kind of annoying to handle > as a user. > > 1: https://lists.gnu.org/archive/html/grub-devel/2020-05/msg00235.html Yep, I saw your patch and like that it brings into alignment LUKS1 and LUKS2 UUID handling. Unfortunately, LUKS UUID handling is also different than FS UUID handling, which uses dashes. So not only is the current behavior annoying, its also confusing. I've been bitten by this a couple times. This change brings LUKS* UUID handling into alignment with FS UUID handling and is backwards compatible with current LUKS handling. Since your patch set hasn't been committed, would you be opposed to dropping that patch?