From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1k1GZu-0004Nb-Qi for mharc-grub-devel@gnu.org; Thu, 30 Jul 2020 17:59:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1GZt-0004NT-92 for grub-devel@gnu.org; Thu, 30 Jul 2020 17:59:05 -0400 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:34805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k1GZq-0007zq-I0 for grub-devel@gnu.org; Thu, 30 Jul 2020 17:59:04 -0400 Received: by mail-pj1-x1042.google.com with SMTP id c10so2848636pjn.1 for ; Thu, 30 Jul 2020 14:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=PhA62VzJ8pXV4FvCQ7y/LFIW3ucCJnw36YrK4JPpK2Y=; b=PEWdnnLVREvTZrQ2xFVguMjg8Zn1Lw9aQBEbRjBUpSl6LUFbqpJXFurrnqUxghz5x/ QjA097uRU7xX6XtBtuQBldLDbR8wxrG2IPaH16CJ7YcENJliQdmc0xNNHxIqCcLFZtng vR5zX9lRpOIHS9GukWnRsJuvm7luWb2w2YKrhR4Z5+f4/HwYqien2FEVpI2m8UFYWGjB HOlC+XVVUIpRvJHyKJAwR1doVYUC2SqS9Q+G5if6Vu6wrQVg2matuxdlNcdJeNiMN26O P9AkXf6Ii0YK1hrLjg99SJpden0yEoZlwhAVm2artte1kLuPFdP8M0vkBtSPNxA/3l+Q HcAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=PhA62VzJ8pXV4FvCQ7y/LFIW3ucCJnw36YrK4JPpK2Y=; b=Vudgf+96802XJoEReMCX8XnsIGQo99YLbHSX1XW29cHyfOZPtwfre5Xtp7l6KQXqnF 2bSJdYRwj/7J7wmGolM/vM5ZVya7yE7omLQfsjTiJpMyQUfWOYZTtvSguBsdFF/Jcsw4 jFTcYKq9Qg+2/n+jd19FwHqG88YSskZ+oOLc8pn8sj9VqTRMpK45P8TXdNQOxBdXrByc qUiTSlZ7QhuhIDjY191yJyZ8a1EnkLTTOjh06CP+DmFt33iS/NhrBoD4hhxseew8aJFF Dcvy8Ck3BPpovpY/hA9Lk34wSKBaAWG/1boQd3aUn1dY4uJmxEbieQnIYh4nQDzK98dl s6MA== X-Gm-Message-State: AOAM531BMHMs3h5rKQOHBWsGBlvYx7TpOysREh77/CSeTS51I8/KJfCr yz+taHWOES2fNR+5b62QZprY0A== X-Google-Smtp-Source: ABdhPJxBp+PVpHmgn80vPMT+clYgRhRKrrYTVM5BkLICMk/6RT7asNPKd/WaGFeX0ONgi6XJE8wGVw== X-Received: by 2002:a17:902:b705:: with SMTP id d5mr1087352pls.118.1596146340288; Thu, 30 Jul 2020 14:59:00 -0700 (PDT) Received: from crass-HP-ZBook-15-G2 ([189.216.105.24]) by smtp.gmail.com with ESMTPSA id i21sm7524324pfa.18.2020.07.30.14.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 14:59:00 -0700 (PDT) Date: Thu, 30 Jul 2020 16:58:46 -0500 From: Glenn Washburn To: Patrick Steinhardt Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH 11/17] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors. Message-ID: <20200730165846.527d5b66@crass-HP-ZBook-15-G2> In-Reply-To: <20200730152958.GE39309@tanuki.pks.im> References: <20200730152958.GE39309@tanuki.pks.im> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1042; envelope-from=development@efficientek.com; helo=mail-pj1-x1042.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jul 2020 21:59:05 -0000 On Thu, 30 Jul 2020 17:29:58 +0200 Patrick Steinhardt wrote: > On Wed, Jul 29, 2020 at 04:50:16PM -0500, development@efficientek.com > wrote: > > From: Glenn Washburn > > > > This makes the creates an alignment with grub_disk_t naming of the > > same field and is more intuitive as to how it should be used. > > > > Signed-off-by: Glenn Washburn ... > > --- a/grub-core/disk/luks.c > > +++ b/grub-core/disk/luks.c > > @@ -113,7 +113,7 @@ configure_ciphers (grub_disk_t disk, const char > > *check_uuid, newdev->offset = grub_be_to_cpu32 > > (header.payloadOffset); newdev->source_disk = NULL; > > newdev->log_sector_size = LOG_SECTOR_SIZE; > > - newdev->total_length = grub_disk_get_size (disk) - > > newdev->offset; > > + newdev->total_sectors = grub_disk_get_size (disk) - > > newdev->offset; > > Oh, yes please. Care to add in another patch that does the same for > offset? `offset_sectors` would also be much clearer to me. Yep, I'll add an extra patch for that in the next patch set.