From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: iwd@lists.01.org
Subject: [PATCH 06/13] p2p: Add a null-check before use
Date: Fri, 31 Jul 2020 03:31:29 +0200 [thread overview]
Message-ID: <20200731013136.65057-6-andrew.zaborowski@intel.com> (raw)
In-Reply-To: <20200731013136.65057-1-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
p2p_connection_reset may be called as a result of a WFD service
unregistering and p2p_own_wfd is going to be NULL, don't update
p2p_own_wfd->available in this case.
---
src/p2p.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/p2p.c b/src/p2p.c
index aaecb8ee..06416bd8 100644
--- a/src/p2p.c
+++ b/src/p2p.c
@@ -486,7 +486,9 @@ static void p2p_connection_reset(struct p2p_device *dev)
if (dev->conn_own_wfd) {
l_free(dev->conn_own_wfd);
dev->conn_own_wfd = NULL;
- p2p_own_wfd->available = true;
+
+ if (p2p_own_wfd)
+ p2p_own_wfd->available = true;
}
explicit_bzero(dev->conn_psk, 32);
--
2.25.1
next prev parent reply other threads:[~2020-07-31 1:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 1:31 [PATCH 01/13] frame-xchg: Fix potential use after free Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 02/13] frame-xchg: Improve search for current frame in MLME notify Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 03/13] frame-xchg: Re-add frame_xchg_stop Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 04/13] station: Comment/whitespace fix Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 05/13] p2p: Retry connect on "Previous authentication not valid" Andrew Zaborowski
2020-07-31 1:31 ` Andrew Zaborowski [this message]
2020-07-31 1:31 ` [PATCH 07/13] p2p: Set p2p_own_wfd->available by default Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 08/13] p2p: Use a longer DHCP timeout Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 09/13] wfd-source: Print call trace on error Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 10/13] wfd-source: Support wfd-idr-request Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 11/13] wfd-source: Display some stream properties Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 12/13] wfd-source: Add stream utility buttons Andrew Zaborowski
2020-07-31 1:31 ` [PATCH 13/13] wfd-source: Allow alternative URLs in SETUP request Andrew Zaborowski
2020-07-31 15:40 ` [PATCH 01/13] frame-xchg: Fix potential use after free Denis Kenzior
2020-07-31 18:56 ` Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731013136.65057-6-andrew.zaborowski@intel.com \
--to=andrew.zaborowski@intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.