From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4670C433E0 for ; Fri, 31 Jul 2020 08:50:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E83320656 for ; Fri, 31 Jul 2020 08:50:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RGqSVayG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E83320656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1Qk4-0000pB-OW for qemu-devel@archiver.kernel.org; Fri, 31 Jul 2020 04:50:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k1QjD-0000Iy-ON for qemu-devel@nongnu.org; Fri, 31 Jul 2020 04:49:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44508 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k1QjC-0007Dn-2Z for qemu-devel@nongnu.org; Fri, 31 Jul 2020 04:49:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596185361; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=GPtgb1BNdaexVKli8mvvJpcbFEMY5B592woGV9ATzQ4=; b=RGqSVayGHoN6MXj69xscdXVr4lCZdo9CgVnxXYZlv/UR+UNW5DR6HGdpkBODW7iPXFuICF moP1xS1MslQmiqrJgF1U53M1P52rd71OMaA0Xk1W0+TGEedWWd/WWFsiW8Zxia3TryMZW0 9BVahcuGYP5hv/0S3DMjTg7/7dNg5xk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-__268pHzPEW8y8mWt0U6Xg-1; Fri, 31 Jul 2020 04:49:14 -0400 X-MC-Unique: __268pHzPEW8y8mWt0U6Xg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E37B1005510; Fri, 31 Jul 2020 08:49:13 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A475373027; Fri, 31 Jul 2020 08:49:00 +0000 (UTC) Date: Fri, 31 Jul 2020 09:48:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Subject: Re: [PATCH] schemas: Add vim modeline Message-ID: <20200731084857.GA3518939@redhat.com> References: <20200729185024.121766-1-abologna@redhat.com> <87ime52wxd.fsf@dusky.pond.sub.org> <20200730093732.GB3477223@redhat.com> <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200731071513.GA4707@linux.fritz.box> MIME-Version: 1.0 In-Reply-To: <20200731071513.GA4707@linux.fritz.box> User-Agent: Mutt/1.14.5 (2020-06-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/31 04:39:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Jason Wang , Juan Quintela , Yuval Shaia , Markus Armbruster , qemu-devel@nongnu.org, Gerd Hoffmann , Andrea Bolognani , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 31, 2020 at 09:15:13AM +0200, Kevin Wolf wrote: > Am 30.07.2020 um 17:11 hat Eric Blake geschrieben: > > > The QAPI schema language has two layers: > > > > > > * JSON, with a lexical and a syntactical sub-layer (both in parser.py) > > > > > > * QAPI, with a context-free and a context-dependend sub-layer (in > > > expr.py and schema.py, respectively) > > > > > > Replacing the JSON layer is possible as long as the replacement is > > > sufficiently expressive (not a tall order). > > > > I'm open to the idea, if we want to attempt it, and agree with the > > assessment that it is not a tall order. > > I'm not so sure about that. I mean, it certainly sounds doable if need > be, but getting better syntax highlighting by default in some editors > feels like a pretty weak reason to switch out the complete schema > language. The main compelling reason to me is that we get to throw away our custom written parsing code and use a standard python library. Actually following a standardized document format is a benefit to contributors, over something that looks like a standard format but is actually slightly different as it is our own parser. Automatic correct syntax highlighting is a happy side effect. More interesting is if the editor automatically does the right thing with indentation/formatting when writing schemas. I wont miss the "not allowed a trailing comma after the last field" part of JSON as I always get it wrong. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|