From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E49C433DF for ; Fri, 31 Jul 2020 09:06:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CF092072A for ; Fri, 31 Jul 2020 09:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Un/qHsaj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731990AbgGaJGU (ORCPT ); Fri, 31 Jul 2020 05:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731818AbgGaJGT (ORCPT ); Fri, 31 Jul 2020 05:06:19 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3886AC061574 for ; Fri, 31 Jul 2020 02:06:19 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id a15so27275977wrh.10 for ; Fri, 31 Jul 2020 02:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=Un/qHsajtmNjsOmCb2mnNKCZnsB5UPu6XobhVc6xxd3nqxAzWj6t50hCNgEd4vTdGo mvJ1bgtAOIVAMdbh82+osjwh9TPvAkn4Ge781EHgqcOq3+EeXqkni0j0/1htkPAbUj5f OhrmFEFapzJ0E1to8b0HIKVZ1GQ1szmMS57VdH43oD25bjccRrDHN4W+zbI6C09/k3z0 PDA5t/WdD8bG6gtLLQxi7EJjzT7p72J8GxdLyc81X7vGZMx3UwyiSaXF+/INF6PpgVUY lVsmFIihfDiCS9C4xNgXsYX2hHO/4x7e93WW7twv+zu/pZ5PRfmj4pyHC7kciNooqtIf WGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=JpFHg9Wk2nWZi3AD9hkWuh2rNsCziO/1MhvlUI/U5EXVGMQMk4p4nh3GEzdXj0hfYi DztcaANT3aoVZb9iuQLd2RM4aD90ZujAjLrnDxOvX6DZBCAz3aZdRSW4ou7Pk6CNZU8b sTj6GUu9uzgxCoo2o8NOrEj4gvNzIcjjrRKQWDhZhSh/v2yiIXuXdu3pAPSpz2lrlyhw Ffj19rTAxQaGNBb9j25wERwECXAp1Z2u8gKKRbmTRNIeqv2ZIaT060czjR+7JDl5f/br wCu9fTttXi5hpUoJW/FxLQB/QIOWZJY4r/QjEDhnj1oid41eoJ5Ne8d1Di7TKcFF15v0 0GRg== X-Gm-Message-State: AOAM530mP1G7bb3FvXMPQdfC9kiBZn6v+3g0L2heQFOVJSQ1N+NCw1S8 aVgJ/LqGTgUI3lzh921S2zaJJA== X-Google-Smtp-Source: ABdhPJxvvy10AX5J00BsA51P9Ib9neAMULoBhvxJmXpVuThEekQJMPq47kHsZzAyKsIgo2uMvjo84w== X-Received: by 2002:a5d:6692:: with SMTP id l18mr2555849wru.211.1596186377988; Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id c24sm13316548wrb.11.2020.07.31.02.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Date: Fri, 31 Jul 2020 10:06:15 +0100 From: Lee Jones To: Gene Chen Cc: Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Gene Chen , benjamin.chao@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com Subject: Re: [PATCH v2 9/9] mfd: mt6360: Merge different sub-devices i2c read/write Message-ID: <20200731090615.GK2419169@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-10-git-send-email-gene.chen.richtek@gmail.com> <20200727124306.GP1850026@dell> <20200729101244.GH2419169@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [...] > > > > > > +static const struct regmap_bus mt6360_regmap_bus = { > > > > > > + .read = mt6360_regmap_read, > > > > > > + .write = mt6360_regmap_write, > > > > > > + > > > > > > + /* due to pmic and ldo crc access size limit */ > > > > > > + .max_raw_read = 4, > > > > > > + .max_raw_write = 4, > > > > > > +}; > > > > > > > > > > Why isn't all of the above in a Regmap driver? > > > > > > > > > > > > > Do you means split out like drivers/base/regmap/regmap-ac97.c? > > > > > > Yes, I do. > > > > > > [...] > > > > > > > ACK > > > > After I implement first version of regmap-mt6360.c, I found out ac97 > is a intel standard codec. > If device follow this spec, it can reuse this api. > But regmap-mt6360.c may single use only. > should I try sending patch once to regmap reviewer? Single use is okay. Putting Regmap code into MFD is not okay. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB2E8C433E0 for ; Fri, 31 Jul 2020 09:06:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B40072072A for ; Fri, 31 Jul 2020 09:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PE66VNLh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Un/qHsaj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B40072072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=auEAxA1H77NGxH5suNCwuVneU/WiOWNEbl3qUzwG/eg=; b=PE66VNLhM+xKrsTeZfixcbQhx 7mOACm6osY5umPHszX+dPrCc/31MEmzW6X2iqbkmPq1shfmOsonrh0T96omMUZ9QkGJbUIfZM8fX7 AO9s82aITHo095/H0pf3PGAFlQJhEOQBU3GQdZ0snc+7kfK143Wtx5rw1u8q8zCSHhtZ6GWR5/cZ+ /pkvGxBH4ho+CeaMy6GNmMgIE2IqDGlxZypGsdzM8nvw2vgWaS7OTDJ6A4TMk7ENynD2goeJrooJA gABez2P23mZS0c1oV6/8KHH9v5Ah0F6yy0IhFHkkKM9OVkgYlweroG+w9NO9CBWWPBdsscJvK3Szf I+CB2IpYQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Qze-0005bm-5i; Fri, 31 Jul 2020 09:06:22 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Qza-0005an-SV for linux-mediatek@lists.infradead.org; Fri, 31 Jul 2020 09:06:20 +0000 Received: by mail-wr1-x442.google.com with SMTP id y3so27301046wrl.4 for ; Fri, 31 Jul 2020 02:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=Un/qHsajtmNjsOmCb2mnNKCZnsB5UPu6XobhVc6xxd3nqxAzWj6t50hCNgEd4vTdGo mvJ1bgtAOIVAMdbh82+osjwh9TPvAkn4Ge781EHgqcOq3+EeXqkni0j0/1htkPAbUj5f OhrmFEFapzJ0E1to8b0HIKVZ1GQ1szmMS57VdH43oD25bjccRrDHN4W+zbI6C09/k3z0 PDA5t/WdD8bG6gtLLQxi7EJjzT7p72J8GxdLyc81X7vGZMx3UwyiSaXF+/INF6PpgVUY lVsmFIihfDiCS9C4xNgXsYX2hHO/4x7e93WW7twv+zu/pZ5PRfmj4pyHC7kciNooqtIf WGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=CwGFuOWcD0tMNyMqMlI6D8O5m0B03X5agPVThCAbSfYnF4+MIjXZT0OLTV+HmKfudr 73zjpVzAxx9LNWj53qaNoyWTHAjcglT1IdRyQmHgre33VyqshXF0wVYuD/Ueb35fZ0uq 2/QPFut2gWtzr3Mn5ikEjkS7ssA50yNylZnTZiejyUWcHga6EOjmDvXXQdU/XS5UFa5U Uca7+Z/fXajD0xtEkMeeqvFqboEQlZ0lf5SOIPk2NS/THt1PJtTGGbmd3xbC/V0mxv7U vHedhgZc6ua6ScqrB6wrYjFXdUaeGLoL3xiHA2alC/BjFC43CWDXeJ4cYj5AFnxvoEFv TvAg== X-Gm-Message-State: AOAM5316AFXwdw5UqObM6pbdJp5+jQEv33oXY/saGAxdH1fzoSLRmN/n jLcJx0ztZ7rjiJla72PshRb+fqdAwmQ= X-Google-Smtp-Source: ABdhPJxvvy10AX5J00BsA51P9Ib9neAMULoBhvxJmXpVuThEekQJMPq47kHsZzAyKsIgo2uMvjo84w== X-Received: by 2002:a5d:6692:: with SMTP id l18mr2555849wru.211.1596186377988; Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id c24sm13316548wrb.11.2020.07.31.02.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Date: Fri, 31 Jul 2020 10:06:15 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v2 9/9] mfd: mt6360: Merge different sub-devices i2c read/write Message-ID: <20200731090615.GK2419169@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-10-git-send-email-gene.chen.richtek@gmail.com> <20200727124306.GP1850026@dell> <20200729101244.GH2419169@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_050619_254644_EA558022 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Wy4uLl0KCj4gPiA+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9idXMgbXQ2MzYw X3JlZ21hcF9idXMgPSB7Cj4gPiA+ID4gPiA+ICsgICAgIC5yZWFkICAgICAgICAgICA9IG10NjM2 MF9yZWdtYXBfcmVhZCwKPiA+ID4gPiA+ID4gKyAgICAgLndyaXRlICAgICAgICAgID0gbXQ2MzYw X3JlZ21hcF93cml0ZSwKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICAgICAvKiBkdWUgdG8g cG1pYyBhbmQgbGRvIGNyYyBhY2Nlc3Mgc2l6ZSBsaW1pdCAqLwo+ID4gPiA+ID4gPiArICAgICAu bWF4X3Jhd19yZWFkICAgPSA0LAo+ID4gPiA+ID4gPiArICAgICAubWF4X3Jhd193cml0ZSAgPSA0 LAo+ID4gPiA+ID4gPiArfTsKPiA+ID4gPiA+Cj4gPiA+ID4gPiBXaHkgaXNuJ3QgYWxsIG9mIHRo ZSBhYm92ZSBpbiBhIFJlZ21hcCBkcml2ZXI/Cj4gPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gRG8g eW91IG1lYW5zIHNwbGl0IG91dCBsaWtlIGRyaXZlcnMvYmFzZS9yZWdtYXAvcmVnbWFwLWFjOTcu Yz8KPiA+ID4KPiA+ID4gWWVzLCBJIGRvLgo+ID4gPgo+ID4gPiBbLi4uXQo+ID4gPgo+ID4KPiA+ IEFDSwo+ID4KPiAKPiBBZnRlciBJIGltcGxlbWVudCBmaXJzdCB2ZXJzaW9uIG9mIHJlZ21hcC1t dDYzNjAuYywgSSBmb3VuZCBvdXQgYWM5Nwo+IGlzIGEgaW50ZWwgc3RhbmRhcmQgY29kZWMuCj4g SWYgZGV2aWNlIGZvbGxvdyB0aGlzIHNwZWMsIGl0IGNhbiByZXVzZSB0aGlzIGFwaS4KPiBCdXQg cmVnbWFwLW10NjM2MC5jIG1heSBzaW5nbGUgdXNlIG9ubHkuCj4gc2hvdWxkIEkgdHJ5IHNlbmRp bmcgcGF0Y2ggb25jZSB0byByZWdtYXAgcmV2aWV3ZXI/CgpTaW5nbGUgdXNlIGlzIG9rYXkuICBQ dXR0aW5nIFJlZ21hcCBjb2RlIGludG8gTUZEIGlzIG5vdCBva2F5LgoKLS0gCkxlZSBKb25lcyBb 5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51eC1t ZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DD7C433E1 for ; Fri, 31 Jul 2020 09:07:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A8D720838 for ; Fri, 31 Jul 2020 09:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WvWNHLyn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Un/qHsaj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A8D720838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=d85mb7OcUENxH1UgkKyMfJcNSxSLnlhWU5vrMN2NAho=; b=WvWNHLynD5o3DYYh4N95Pa8Dt hEz0hjQhzs7Fture2q50Fu3AQj8mb/M2ugidAkwzgY544uzDKKHK5AlR3Oc5acsqkRjGtVGDQG2iO 0ZSM3q+DhEXl0igM5Nbz9ZeJmlZKPjoqGTlsn66+VqSna+9Nr15e7Tl0s3a5Qh3zt5IUFRnMROteQ 5GV8Sj67K7MzB5Q7AsSeUI28wD3BzbmEah132YBmteNF0CviY6Lk8NaAg6ak330nUFlb8CU1X9HEm lliPG79NCmNI1IfvjqXOfe0qwLwbylV4rikVCDLDma6FHP2vYnCkmai/MXd/2ULTQlStRk/96oXvn eoG4XlmTw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Qzf-0005c9-Ne; Fri, 31 Jul 2020 09:06:23 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1Qza-0005ao-S5 for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 09:06:20 +0000 Received: by mail-wr1-x441.google.com with SMTP id r4so24334208wrx.9 for ; Fri, 31 Jul 2020 02:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=Un/qHsajtmNjsOmCb2mnNKCZnsB5UPu6XobhVc6xxd3nqxAzWj6t50hCNgEd4vTdGo mvJ1bgtAOIVAMdbh82+osjwh9TPvAkn4Ge781EHgqcOq3+EeXqkni0j0/1htkPAbUj5f OhrmFEFapzJ0E1to8b0HIKVZ1GQ1szmMS57VdH43oD25bjccRrDHN4W+zbI6C09/k3z0 PDA5t/WdD8bG6gtLLQxi7EJjzT7p72J8GxdLyc81X7vGZMx3UwyiSaXF+/INF6PpgVUY lVsmFIihfDiCS9C4xNgXsYX2hHO/4x7e93WW7twv+zu/pZ5PRfmj4pyHC7kciNooqtIf WGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lfnkQfm3GKzU95XwF2JxhE5x/N3AyvhM1u96HkPpQ6s=; b=ZQ8XOehBV14YVWjstnFIBsNu9G3BbRybTZ1+dXS1GcVtpArfGMk+IwQHAZ7z8b+JMS THfPvULy7MHiVheEy6BqOex0ZuqBL5irBTSSXzQpgkeeG54AYn7eT7woFUZMTLMmcle7 ppNveoOyiOEotfrhaw3HlnC8Y06pN2DTZoxIVQ97HvCgY9dmUjD6GdBTMTJIfa72oTGa CV0PVbC/Ov9kzsJZI4OhBjkRXMoyoqKdEgfuyBMp/zfm2RFhSEp5NxFe0dTrwLZfnp90 HWV36xFbB3E5df5UnhozJpMbvlnYFELSj6bfO4YCbxLtS+GxMGbuB28V0GTwG7rKtzHB 4qJQ== X-Gm-Message-State: AOAM530APnoB5rhzdjBVdXKsN6qNF9W9KLTwdZJTVwlOWMpUiHLod4lv DqIuK+e1UCr/01QTjYo5lEDVHg== X-Google-Smtp-Source: ABdhPJxvvy10AX5J00BsA51P9Ib9neAMULoBhvxJmXpVuThEekQJMPq47kHsZzAyKsIgo2uMvjo84w== X-Received: by 2002:a5d:6692:: with SMTP id l18mr2555849wru.211.1596186377988; Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id c24sm13316548wrb.11.2020.07.31.02.06.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 02:06:17 -0700 (PDT) Date: Fri, 31 Jul 2020 10:06:15 +0100 From: Lee Jones To: Gene Chen Subject: Re: [PATCH v2 9/9] mfd: mt6360: Merge different sub-devices i2c read/write Message-ID: <20200731090615.GK2419169@dell> References: <1594983811-25908-1-git-send-email-gene.chen.richtek@gmail.com> <1594983811-25908-10-git-send-email-gene.chen.richtek@gmail.com> <20200727124306.GP1850026@dell> <20200729101244.GH2419169@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_050619_255875_E00B53AB X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gene Chen , linux-kernel@vger.kernel.org, cy_huang@richtek.com, benjamin.chao@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wy4uLl0KCj4gPiA+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHJlZ21hcF9idXMgbXQ2MzYw X3JlZ21hcF9idXMgPSB7Cj4gPiA+ID4gPiA+ICsgICAgIC5yZWFkICAgICAgICAgICA9IG10NjM2 MF9yZWdtYXBfcmVhZCwKPiA+ID4gPiA+ID4gKyAgICAgLndyaXRlICAgICAgICAgID0gbXQ2MzYw X3JlZ21hcF93cml0ZSwKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICAgICAvKiBkdWUgdG8g cG1pYyBhbmQgbGRvIGNyYyBhY2Nlc3Mgc2l6ZSBsaW1pdCAqLwo+ID4gPiA+ID4gPiArICAgICAu bWF4X3Jhd19yZWFkICAgPSA0LAo+ID4gPiA+ID4gPiArICAgICAubWF4X3Jhd193cml0ZSAgPSA0 LAo+ID4gPiA+ID4gPiArfTsKPiA+ID4gPiA+Cj4gPiA+ID4gPiBXaHkgaXNuJ3QgYWxsIG9mIHRo ZSBhYm92ZSBpbiBhIFJlZ21hcCBkcml2ZXI/Cj4gPiA+ID4gPgo+ID4gPiA+Cj4gPiA+ID4gRG8g eW91IG1lYW5zIHNwbGl0IG91dCBsaWtlIGRyaXZlcnMvYmFzZS9yZWdtYXAvcmVnbWFwLWFjOTcu Yz8KPiA+ID4KPiA+ID4gWWVzLCBJIGRvLgo+ID4gPgo+ID4gPiBbLi4uXQo+ID4gPgo+ID4KPiA+ IEFDSwo+ID4KPiAKPiBBZnRlciBJIGltcGxlbWVudCBmaXJzdCB2ZXJzaW9uIG9mIHJlZ21hcC1t dDYzNjAuYywgSSBmb3VuZCBvdXQgYWM5Nwo+IGlzIGEgaW50ZWwgc3RhbmRhcmQgY29kZWMuCj4g SWYgZGV2aWNlIGZvbGxvdyB0aGlzIHNwZWMsIGl0IGNhbiByZXVzZSB0aGlzIGFwaS4KPiBCdXQg cmVnbWFwLW10NjM2MC5jIG1heSBzaW5nbGUgdXNlIG9ubHkuCj4gc2hvdWxkIEkgdHJ5IHNlbmRp bmcgcGF0Y2ggb25jZSB0byByZWdtYXAgcmV2aWV3ZXI/CgpTaW5nbGUgdXNlIGlzIG9rYXkuICBQ dXR0aW5nIFJlZ21hcCBjb2RlIGludG8gTUZEIGlzIG5vdCBva2F5LgoKLS0gCkxlZSBKb25lcyBb 5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGlu YXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5h cm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK