From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree@solarflare.com>
Cc: <linux-net-drivers@solarflare.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 08/11] sfc_ef100: statistics gathering
Date: Fri, 31 Jul 2020 13:27:32 -0700 [thread overview]
Message-ID: <20200731132732.2ddf3db6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <64c11143-4749-5891-85eb-c312f1de721e@solarflare.com>
On Fri, 31 Jul 2020 14:00:24 +0100 Edward Cree wrote:
> + core_stats->rx_packets = stats[EF100_STAT_port_rx_packets];
> + core_stats->tx_packets = stats[EF100_STAT_port_tx_packets];
> + core_stats->rx_bytes = stats[EF100_STAT_port_rx_bytes];
> + core_stats->tx_bytes = stats[EF100_STAT_port_tx_bytes];
> + core_stats->multicast = stats[EF100_STAT_port_rx_multicast];
> + core_stats->rx_crc_errors = stats[EF100_STAT_port_rx_bad];
> + core_stats->rx_frame_errors =
> + stats[EF100_STAT_port_rx_align_error];
> + core_stats->rx_fifo_errors = stats[EF100_STAT_port_rx_overflow];
Since this is a new driver please stop reporting this in ethtool.
They clearly have a perfect match with the standard stats there is
no need for duplication.
next prev parent reply other threads:[~2020-07-31 20:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 12:55 [PATCH v2 net-next 00/11] sfc: driver for EF100 family NICs, part 2 Edward Cree
2020-07-31 12:58 ` [PATCH v2 net-next 01/11] sfc_ef100: check firmware version at start-of-day Edward Cree
2020-07-31 12:58 ` [PATCH v2 net-next 02/11] sfc_ef100: fail the probe if NIC uses unsol_ev credits Edward Cree
2020-07-31 12:58 ` [PATCH v2 net-next 03/11] sfc_ef100: read Design Parameters at probe time Edward Cree
2020-07-31 20:18 ` Jakub Kicinski
2020-08-03 14:33 ` Edward Cree
2020-08-03 21:54 ` Jakub Kicinski
2020-07-31 12:59 ` [PATCH v2 net-next 04/11] sfc_ef100: TX path for EF100 NICs Edward Cree
2020-07-31 19:39 ` Jakub Kicinski
2020-08-03 14:36 ` Edward Cree
2020-07-31 12:59 ` [PATCH v2 net-next 05/11] sfc_ef100: RX filter table management and related gubbins Edward Cree
2020-07-31 12:59 ` [PATCH v2 net-next 06/11] sfc_ef100: RX path for EF100 Edward Cree
2020-07-31 13:00 ` [PATCH v2 net-next 07/11] sfc_ef100: plumb in fini_dmaq Edward Cree
2020-07-31 13:00 ` [PATCH v2 net-next 08/11] sfc_ef100: statistics gathering Edward Cree
2020-07-31 20:27 ` Jakub Kicinski [this message]
2020-07-31 13:00 ` [PATCH v2 net-next 09/11] sfc_ef100: functions for selftests Edward Cree
2020-07-31 13:01 ` [PATCH v2 net-next 10/11] sfc_ef100: read pf_index at probe time Edward Cree
2020-07-31 13:01 ` [PATCH v2 net-next 11/11] sfc_ef100: add nic-type for VFs, and bind to them Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731132732.2ddf3db6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.