Re: [meta-arm] [PATCH] optee-os: replace old pycrypto with pycryptodome - a drop-in replacement

["Jon Mason" <jdmason@kudzu.us>]

On Fri, Jul 31, 2020 at 12:27:14PM -0400, Denys Dmytriyenko wrote:
> On Fri, Jul 31, 2020 at 10:05:56AM -0400, Jon Mason wrote:
> > On Wed, Jul 29, 2020 at 04:54:54PM -0400, Denys Dmytriyenko wrote:
> > > On Mon, Jul 27, 2020 at 02:37:51PM -0400, Denys Dmytriyenko wrote:
> > > > On Thu, Jul 23, 2020 at 05:34:31PM -0400, Denys Dmytriyenko wrote:
> > > > > On Tue, May 19, 2020 at 11:20:14AM -0400, Jon Mason wrote:
> > > > > > On Fri, May 15, 2020 at 12:44:30AM -0700, Diego Sueiro wrote:
> > > > > > > On Fri, May 15, 2020 at 01:31 AM, Denys Dmytriyenko wrote:
> > > > > > > 
> > > > > > > >
> > > > > > > > From: Denys Dmytriyenko <denys@ti.com>
> > > > > > > > 
> > > > > > > > While pycryptodome is a drop-in replacement for the old pycrypto module,
> > > > > > > > pycryptodomex uses a separate namespace to not confict with pycrypto.
> > > > > > > > Unfortunately, optee-os uses both namespaces, hence both variants of
> > > > > > > > pycryptodome and pycryptodomex are needed.
> > > > > > > > 
> > > > > > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > > > > > > 
> > > > > > > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> > > > > > 
> > > > > > Pulled in to the master branch.
> > > > > 
> > > > > Can you please also backport this to dunfell - it is also needed to fully drop 
> > > > > dependency on meta-python in dunfell. Thanks!
> > > > > 
> > > > > http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/commit/?id=06b648821aa3fbbdf7c00724cf3c3cedbb4f0546
> > > > 
> > > > Ping.
> > > 
> > > Just wanted to check if there are any concerns with this backport. Thanks.
> > > 
> > > Denys
> > 
> > Terribly sorry in the delay.  This caused a discussion internally and
> > got lost in the shuffle.  I'll sanity check agin shortly, but there
> > was no issues on dunfell with the patch.  However in testing it, we
> > found that there are still python dependencies in master.  So, I think
> > we can apply to dunfell, but need to revert in master.  I'm currently
> > looking for alternatives to the revert in master.
> 
> Where does the dependency on meta-python in master come from? Is it still from 
> optee? Or is there something else?

TF-M and OPTEE (and GEM5, which is now its own layer).  We know its an
issue and will work on it.

Anyway, the patch is now in dunfell.

Thanks,
Jon

> 
> Denys
> 
> 
> > Thanks,
> > Jon
> > 
> > > 
> > > 
> > > > > > > > ---
> > > > > > > >  meta-arm/recipes-security/optee/optee-os_git.bb | 2 +-
> > > > > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > > > > 
> > > > > > > > diff --git a/meta-arm/recipes-security/optee/optee-os_git.bb
> > > > > > > > b/meta-arm/recipes-security/optee/optee-os_git.bb
> > > > > > > > index dfff6d1..c9847b5 100644
> > > > > > > > --- a/meta-arm/recipes-security/optee/optee-os_git.bb
> > > > > > > > +++ b/meta-arm/recipes-security/optee/optee-os_git.bb
> > > > > > > > @@ -10,7 +10,7 @@ PV = "3.8.0+git${SRCPV}"
> > > > > > > >  inherit deploy python3native
> > > > > > > >  require optee.inc
> > > > > > > >
> > > > > > > > -DEPENDS = "python3-pycrypto-native python3-pyelftools-native
> > > > > > > > python3-pycryptodomex-native"
> > > > > > > > +DEPENDS = "python3-pycryptodome-native python3-pycryptodomex-native
> > > > > > > > python3-pyelftools-native"
> > > > > > > >
> > > > > > > >  SRCREV = "023e33656e2c9557ce50ad63a98b2e2c9b51c118"
> > > > > > > >  SRC_URI = " \
> > > > > > > > -- 
> > > > > > > > 2.7.4
> > > > > > > > 
> > > > > > > >
> > > > > > 
> > > > > > > 
> > > > > > 
> > > > > 
> > > > > > 
> > > > > 
> > > > 
> > > > > 
> > > > 
> > > 
> > > > 
> > > 
> > 
> > > 
> > 

>