From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504F4C433DF for ; Fri, 31 Jul 2020 21:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BED32087C for ; Fri, 31 Jul 2020 21:30:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596231033; bh=NHsr3aFIVXcbgVNcABj+122r90mMVIkb6+W2zQXbddw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=JmIhRV6pA927+8V4O5blsoQGf7KtF60pVvPH9TS/wW9yYsJuG1ZRC0yKQ78Sc3SA5 mV4JI4Cp9sHgM+KlOK8OiexICxQ2I7Q6J+Grq3lLfggJDkGdXkEcYgg0W07DSyTHRz TzMgiL3iCd7Evb7iqKDBYBa3bK5vYw/XvjcJB4GI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728541AbgGaVac (ORCPT ); Fri, 31 Jul 2020 17:30:32 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:45066 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727995AbgGaVab (ORCPT ); Fri, 31 Jul 2020 17:30:31 -0400 Received: by mail-io1-f68.google.com with SMTP id e64so33030323iof.12; Fri, 31 Jul 2020 14:30:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+1TGdSM7ebRYhzsfJccNqgk5kV9sG3dUDdM4DYu83Fw=; b=lsed4E8QbpJ03lvZjtNhqd5CJOiGre4CupwB1JlneF1/lcQcSXWktjaN3kWrZb+/OP 79gp8QSW0irq1Xukqug4O9KndQKSVYTaetvHBaraNxMf5fQfctCM9z8XBE5sqklZh1Bm aUCj9GUBgChXoCf0v0n7rbbKBHW4X4GrKXxC69GlSk8kv09nIRo5qzXxH8c9RIEJXy0s hO8D7VtB7Y0cKGbyFmz+b3OgYRAJy8hPjyQMbS37ghx8lY8wRz6W26ZVp/1qFsUz7s36 R7vzegyWiW3tIBOF4jIhYmPVAjL8K6ravpF/zUX7K23P12BNwgyY+rKtIumbXahoCgxb hf2w== X-Gm-Message-State: AOAM530gqYkufbDbT24WD1x91hYpAWTuTihr/3ACx+/iYtL8IvbUXZ4+ vKO1GlOqbpBS3WheREMDiQ== X-Google-Smtp-Source: ABdhPJxXeVS0jZueBStQpy+cdWH/c/tpvRGzhw0OjxjNfquqY5ZbETuEj8pXTjXPXY5xHhqTIYPArg== X-Received: by 2002:a02:84ac:: with SMTP id f41mr2890486jai.56.1596231030696; Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i9sm5682020ile.48.2020.07.31.14.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: (nullmailer pid 827984 invoked by uid 1000); Fri, 31 Jul 2020 21:30:28 -0000 Date: Fri, 31 Jul 2020 15:30:28 -0600 From: Rob Herring To: Codrin Ciubotariu Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller Message-ID: <20200731213028.GA824739@bogus> References: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote: > This patch adds DT bindings for the new Microchip S/PDIF TX Controller > embedded inside sama7g5 SoCs. > > Signed-off-by: Codrin Ciubotariu > --- > > Changes in v2: > - replaced https with http > - reworked example, included bindings; > > .../bindings/sound/mchp,spdiftx.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > new file mode 100644 > index 000000000000..2b7c27391f0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip S/PDIF Tx Controller Device Tree Bindings > + > +maintainers: > + - Codrin Ciubotariu > + > +description: > + The Microchip Sony/Philips Digital Interface Transmitter is a > + serial port compliant with the IEC-60958 standard. > + > +properties: > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + oneOf: > + - const: microchip,sama7g5-spdiftx No need for 'oneOf' when only 1 entry. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Peripheral Bus Clock > + - description: Generic Clock > + > + clock-names: > + items: > + - const: pclk > + - const: gclk > + > + dmas: > + description: TX DMA Channel How many? (maxItems: 1) > + > + dma-names: > + const: tx > + > + pinctrl-0: true > + > + pinctrl-names: > + const: default You can drop pinctrl props. They are always allowed. > + > +required: > + - "#sound-dai-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dmas > + - dma-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + spdiftx@e1618000 { > + #sound-dai-cells = <0>; > + compatible = "microchip,sama7g5-spdiftx"; > + reg = <0xe1618000 0x4000>; > + interrupts = ; > + dmas = <&dma0 AT91_XDMAC_DT_PERID(50)>; > + dma-names = "tx"; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 85>, <&pmc PMC_TYPE_GCK 85>; > + clock-names = "pclk", "gclk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spdiftx_default>; > + }; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391EFC433E0 for ; Fri, 31 Jul 2020 21:31:42 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B53512087C for ; Fri, 31 Jul 2020 21:31:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="T6ApAMoC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B53512087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2E8741689; Fri, 31 Jul 2020 23:30:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2E8741689 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596231100; bh=NHsr3aFIVXcbgVNcABj+122r90mMVIkb6+W2zQXbddw=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=T6ApAMoCvX1sOG+10QW+lkp+buyK3dP7HcxBuLX0YDIzchUQJrzBqDEChzJw1N2xr tNhBQDbn+fkSG7NrAGBZQgGdG2oP3Pcb1UoGuYTpd+Zy7bdx9n2imothNKkTnT8yuv XfpNZ/l12WJzOSt2rq3IB0nJI6HjJ3fRo9R8hKn8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AE590F80161; Fri, 31 Jul 2020 23:30:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87E9FF80171; Fri, 31 Jul 2020 23:30:47 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8BBF0F80111 for ; Fri, 31 Jul 2020 23:30:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8BBF0F80111 Received: by mail-io1-f66.google.com with SMTP id k23so32995644iom.10 for ; Fri, 31 Jul 2020 14:30:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+1TGdSM7ebRYhzsfJccNqgk5kV9sG3dUDdM4DYu83Fw=; b=cuv6zQxGSYau4GwhyX9MFkB+Moxn/wMaXORx3vnrUWmfmhK4kAvv9yBSC4mJ2/K+mz iSDtmJjxG43iyXKit0bbmyEnx/CsSqjNtYdRquZ/EEMxasIacXBvxBP3eJUXeiI5Etj/ ylI26o7QgZ7VJthnIjOuh+ohu9bYsc5aCmzwLGvJjJHN8SHO/OLpR4lKFlgutL77N72i Hu6l9vL8ATFQrMZY7qESxQQN5tCxUcjg2Mf9jPo/plrERh3tbMgATl/Mt3VArOpXn2d1 Nrro/jEvqoqaEblB7LuV/++0KFw5kuDBotF/kCFNScQtfC9oHmfGTV9IVAxZDzbIW2rH gpXw== X-Gm-Message-State: AOAM533x97LBr6cxifVKQutR5SY66aS09z2Lza/d3znt5UYcCH5cQ6Kv vkocgzOvtaxhvkhdmudF8w== X-Google-Smtp-Source: ABdhPJxXeVS0jZueBStQpy+cdWH/c/tpvRGzhw0OjxjNfquqY5ZbETuEj8pXTjXPXY5xHhqTIYPArg== X-Received: by 2002:a02:84ac:: with SMTP id f41mr2890486jai.56.1596231030696; Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i9sm5682020ile.48.2020.07.31.14.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: (nullmailer pid 827984 invoked by uid 1000); Fri, 31 Jul 2020 21:30:28 -0000 Date: Fri, 31 Jul 2020 15:30:28 -0600 From: Rob Herring To: Codrin Ciubotariu Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller Message-ID: <20200731213028.GA824739@bogus> References: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, alexandre.belloni@bootlin.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, ludovic.desroches@microchip.com, broonie@kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@microchip.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote: > This patch adds DT bindings for the new Microchip S/PDIF TX Controller > embedded inside sama7g5 SoCs. > > Signed-off-by: Codrin Ciubotariu > --- > > Changes in v2: > - replaced https with http > - reworked example, included bindings; > > .../bindings/sound/mchp,spdiftx.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > new file mode 100644 > index 000000000000..2b7c27391f0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip S/PDIF Tx Controller Device Tree Bindings > + > +maintainers: > + - Codrin Ciubotariu > + > +description: > + The Microchip Sony/Philips Digital Interface Transmitter is a > + serial port compliant with the IEC-60958 standard. > + > +properties: > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + oneOf: > + - const: microchip,sama7g5-spdiftx No need for 'oneOf' when only 1 entry. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Peripheral Bus Clock > + - description: Generic Clock > + > + clock-names: > + items: > + - const: pclk > + - const: gclk > + > + dmas: > + description: TX DMA Channel How many? (maxItems: 1) > + > + dma-names: > + const: tx > + > + pinctrl-0: true > + > + pinctrl-names: > + const: default You can drop pinctrl props. They are always allowed. > + > +required: > + - "#sound-dai-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dmas > + - dma-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + spdiftx@e1618000 { > + #sound-dai-cells = <0>; > + compatible = "microchip,sama7g5-spdiftx"; > + reg = <0xe1618000 0x4000>; > + interrupts = ; > + dmas = <&dma0 AT91_XDMAC_DT_PERID(50)>; > + dma-names = "tx"; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 85>, <&pmc PMC_TYPE_GCK 85>; > + clock-names = "pclk", "gclk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spdiftx_default>; > + }; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A3DC433E0 for ; Fri, 31 Jul 2020 21:32:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 423F62087C for ; Fri, 31 Jul 2020 21:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VEM0DIt6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 423F62087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YJ8gPYqOfg1r4i0gAx1tirX6WAu3a2OjlLm24kufkqU=; b=VEM0DIt6+mlySJcwOhZNbxRjQ tmd6sQpaiqToxKCfriYIUoumMkNx6CZIDWRPUKE60425+5g4N1Sda54chIPVQKgDssO4kGPsx5sD1 Xgl6OvAz0PSOOctWySj6+woORmA1Uzvz7AScJsFwC02Jt38j7fonnp5ciM9nD/TIPbj2Tx+EEjgKB ZfvOKq3nZcJe7TGuu1tiosuovv9W1M/XejTwcCK88sH/YfeLa8SVbMdhvbPB34YNxu4GOZGsdPBRz ACnUyZQHhFZIgp5TV6eZw+xqQiQoJuubeE8J5HF1lfHKQi/RwoGEiOsYIRRCA78d932GGJ4QHXIM/ Sr5/SX4yQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1cbq-00088k-RQ; Fri, 31 Jul 2020 21:30:34 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1cbn-00087y-8s for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2020 21:30:32 +0000 Received: by mail-io1-f68.google.com with SMTP id v6so17798545iow.11 for ; Fri, 31 Jul 2020 14:30:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+1TGdSM7ebRYhzsfJccNqgk5kV9sG3dUDdM4DYu83Fw=; b=GVwGAZ8joUFYFmiHaeJpnGQbaotb0TZnaTk7JnSF86+B4G1GCNQa3cLWxdeamHfuBG 4/1czCENTvBuNXhU8KD92dfBA27vQT79j/kT7NHki6wfK43628ioXvgWXMBI8w9WK7bM qT4+miwCdH5YItnXXfpa9CCLfnXTnXNMz98S2xu95HTl0ukgyGeBiimlWLBvfD2JDmlL jXri943eYqFFrq5aQjgpokiAfRKoYZ+eP2PHUU4x50uvjA7M2kSk5XechafRelMlcosF SIo0ahF+/+Mcs/ijKGVHMkfJ9x6FRqEhl3ZNJP5dFgxZZVUYN/nQpeKmqQnL86YSVqc/ +gwg== X-Gm-Message-State: AOAM532NU2fcl10ie9q+tTAnKlP7sYmHBnCWShltUmt7hw6jybZ2wQzW gaA4dELfXJSmAcSVQHf+Pw== X-Google-Smtp-Source: ABdhPJxXeVS0jZueBStQpy+cdWH/c/tpvRGzhw0OjxjNfquqY5ZbETuEj8pXTjXPXY5xHhqTIYPArg== X-Received: by 2002:a02:84ac:: with SMTP id f41mr2890486jai.56.1596231030696; Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id i9sm5682020ile.48.2020.07.31.14.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2020 14:30:30 -0700 (PDT) Received: (nullmailer pid 827984 invoked by uid 1000); Fri, 31 Jul 2020 21:30:28 -0000 Date: Fri, 31 Jul 2020 15:30:28 -0600 From: Rob Herring To: Codrin Ciubotariu Subject: Re: [PATCH v2 1/2] dt-bindings: sound: add DT bindings for Microchip S/PDIF TX Controller Message-ID: <20200731213028.GA824739@bogus> References: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200729101922.3033616-1-codrin.ciubotariu@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200731_173031_507976_B6F3261E X-CRM114-Status: GOOD ( 19.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, alexandre.belloni@bootlin.com, tiwai@suse.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, ludovic.desroches@microchip.com, broonie@kernel.org, perex@perex.cz, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 29, 2020 at 01:19:21PM +0300, Codrin Ciubotariu wrote: > This patch adds DT bindings for the new Microchip S/PDIF TX Controller > embedded inside sama7g5 SoCs. > > Signed-off-by: Codrin Ciubotariu > --- > > Changes in v2: > - replaced https with http > - reworked example, included bindings; > > .../bindings/sound/mchp,spdiftx.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > new file mode 100644 > index 000000000000..2b7c27391f0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mchp,spdiftx.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mchp,spdiftx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip S/PDIF Tx Controller Device Tree Bindings > + > +maintainers: > + - Codrin Ciubotariu > + > +description: > + The Microchip Sony/Philips Digital Interface Transmitter is a > + serial port compliant with the IEC-60958 standard. > + > +properties: > + "#sound-dai-cells": > + const: 0 > + > + compatible: > + oneOf: > + - const: microchip,sama7g5-spdiftx No need for 'oneOf' when only 1 entry. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Peripheral Bus Clock > + - description: Generic Clock > + > + clock-names: > + items: > + - const: pclk > + - const: gclk > + > + dmas: > + description: TX DMA Channel How many? (maxItems: 1) > + > + dma-names: > + const: tx > + > + pinctrl-0: true > + > + pinctrl-names: > + const: default You can drop pinctrl props. They are always allowed. > + > +required: > + - "#sound-dai-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dmas > + - dma-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + spdiftx@e1618000 { > + #sound-dai-cells = <0>; > + compatible = "microchip,sama7g5-spdiftx"; > + reg = <0xe1618000 0x4000>; > + interrupts = ; > + dmas = <&dma0 AT91_XDMAC_DT_PERID(50)>; > + dma-names = "tx"; > + clocks = <&pmc PMC_TYPE_PERIPHERAL 85>, <&pmc PMC_TYPE_GCK 85>; > + clock-names = "pclk", "gclk"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_spdiftx_default>; > + }; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel