From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591D6C433E1 for ; Sat, 1 Aug 2020 17:12:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FAC72071E for ; Sat, 1 Aug 2020 17:12:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ldn6PBxD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbgHARM3 (ORCPT ); Sat, 1 Aug 2020 13:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbgHARM3 (ORCPT ); Sat, 1 Aug 2020 13:12:29 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5460C06174A; Sat, 1 Aug 2020 10:12:28 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id c9so1876482qvu.5; Sat, 01 Aug 2020 10:12:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2o6GVTZCy3XlmzBSwd7fA26VADSjJEkCYNl3YQKOr2M=; b=Ldn6PBxD4m7lMPymQjipKfl27zylKQuiR2k8wfxVSrmlQ5jpqIVVImGSZWjlPgIbGC hDJ7BkFuGFrS7733Sa79QeGiqV0qQCemUiXRE/QiwWnLbm5EQ82dmxs/kG3UyfU7E7n8 nL536EWJMI21gMA9GAQJpy1F9/6iR1lsI9mBQIIRfbo6g7chxN3cmdc3uVhPEga7RQ4V TEliR1I27x7f40QWq2Ktg3mUvoW/3WDyyvpBb63myjZ0gnPKNIW0MqE9glVDJBy3Bgqw In5hjK+9C4XkaeRowWu/SdcdFCcOWgZbXvoQRkQSw2xxEZumWAOjTxrQxGG+33eaNoFE aj7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=2o6GVTZCy3XlmzBSwd7fA26VADSjJEkCYNl3YQKOr2M=; b=Dlxkj4gwDa3VAZVNrv9hw1JojMt5+vpiOLB+vkYEQBPdwM9S5jDV2rIGne+HuUAQOU 7BlQ/YkXTwh/eVktZHaijfYequ8PWQge+Kk4a/24lKyW5IAq/lQuS8ylOiK2n+Ui4wQp 7EnrtXgTPfBhCPqZq4DlY58FS7qjlMRiBU9pKOHU5K6UULrmMwWLV6LUuwFR2mdNugu0 in8ILi+AU9zuXaELgilZFz8+sIOVlpLFCJDMxymC+A9W+q3wMsQiKZZM+z5nsyfuitK8 RSx21XmrDqODOHGNAu12ZpUO/S/t/hhT+CqFkLlOROoPeREm/4TrqdHi/nHqPrieo+FD 7UVA== X-Gm-Message-State: AOAM532WSU+s03VmHGTa7xM8vcen43CLZOlnvD59LN4QYCPK5lKZeCdM VXIHBrZ/aXx6iBtB9kUSxKA= X-Google-Smtp-Source: ABdhPJyvisrUtCH+yT5SZkhMZ5hRzUqOeeL+iqxCLSrjVaYvR2aM1RnsJVQsxy3ZgehzESYLcwGpwg== X-Received: by 2002:a0c:ffc6:: with SMTP id h6mr9551061qvv.251.1596301947711; Sat, 01 Aug 2020 10:12:27 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id i19sm12760874qkk.68.2020.08.01.10.12.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2020 10:12:27 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sat, 1 Aug 2020 13:12:25 -0400 To: Kees Cook Cc: Arvind Sankar , Thomas Gleixner , Will Deacon , Catalin Marinas , Mark Rutland , Ard Biesheuvel , Peter Collingbourne , James Morse , Borislav Petkov , Ingo Molnar , Russell King , Masahiro Yamada , Nick Desaulniers , Nathan Chancellor , Arnd Bergmann , x86@kernel.org, clang-built-linux@googlegroups.com, linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 32/36] x86/boot/compressed: Reorganize zero-size section asserts Message-ID: <20200801171225.GB3249534@rani.riverdale.lan> References: <20200731230820.1742553-1-keescook@chromium.org> <20200731230820.1742553-33-keescook@chromium.org> <20200801014755.GA2700342@rani.riverdale.lan> <20200801025325.GA2800311@rani.riverdale.lan> <202007312235.4A48157938@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202007312235.4A48157938@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 31, 2020 at 10:36:00PM -0700, Kees Cook wrote: > On Fri, Jul 31, 2020 at 10:53:25PM -0400, Arvind Sankar wrote: > > On Fri, Jul 31, 2020 at 09:47:55PM -0400, Arvind Sankar wrote: > > > On Fri, Jul 31, 2020 at 04:08:16PM -0700, Kees Cook wrote: > > > > For readability, move the zero-sized sections to the end after DISCARDS > > > > and mark them NOLOAD for good measure. > > > > > > > > Signed-off-by: Kees Cook > > > > --- > > > > arch/x86/boot/compressed/vmlinux.lds.S | 42 +++++++++++++++----------- > > > > 1 file changed, 25 insertions(+), 17 deletions(-) > > > > > > > > diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S > > > > index 3c2ee9a5bf43..42dea70a5091 100644 > > > > --- a/arch/x86/boot/compressed/vmlinux.lds.S > > > > +++ b/arch/x86/boot/compressed/vmlinux.lds.S > > > > @@ -42,18 +42,16 @@ SECTIONS > > > > *(.rodata.*) > > > > _erodata = . ; > > > > } > > > > - .rel.dyn : { > > > > - *(.rel.*) > > > > - } > > > > - .rela.dyn : { > > > > - *(.rela.*) > > > > - } > > > > - .got : { > > > > - *(.got) > > > > - } > > > > .got.plt : { > > > > *(.got.plt) > > > > } > > > > + ASSERT(SIZEOF(.got.plt) == 0 || > > > > +#ifdef CONFIG_X86_64 > > > > + SIZEOF(.got.plt) == 0x18, > > > > +#else > > > > + SIZEOF(.got.plt) == 0xc, > > > > +#endif > > > > + "Unexpected GOT/PLT entries detected!") > > > > > > > > .data : { > > > > _data = . ; > > > > @@ -85,13 +83,23 @@ SECTIONS > > > > ELF_DETAILS > > > > > > > > DISCARDS > > > > -} > > > > > > > > -ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!") > > > > -#ifdef CONFIG_X86_64 > > > > -ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0x18, "Unexpected GOT/PLT entries detected!") > > > > -#else > > > > -ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0xc, "Unexpected GOT/PLT entries detected!") > > > > -#endif > > > > + /* > > > > + * Sections that should stay zero sized, which is safer to > > > > + * explicitly check instead of blindly discarding. > > > > + */ > > > > + .got (NOLOAD) : { > > > > + *(.got) > > > > + } > > > > + ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!") > > > > > > > > -ASSERT(SIZEOF(.rel.dyn) == 0 && SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations detected!") > > > > + /* ld.lld does not like .rel* sections being made "NOLOAD". */ > > > > + .rel.dyn : { > > > > + *(.rel.*) > > > > + } > > > > + ASSERT(SIZEOF(.rel.dyn) == 0, "Unexpected run-time relocations (.rel) detected!") > > > > + .rela.dyn : { > > > > + *(.rela.*) > > > > + } > > > > + ASSERT(SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations (.rela) detected!") > > > > +} > > > > -- > > > > 2.25.1 > > > > > > > > > > There's no point in marking zero-size sections NOLOAD -- if the ASSERT's > > > passed, they won't be present in the file at all anyway. > > > > > > The only section for which there might be a point is .got.plt, which is > > > non-empty on 32-bit, and only if it is first moved to the end. That > > > saves a few bytes. > > > > Btw, you should move .got.plt also to the end anyway for readability, > > it's unused even if non-empty. And with the ASSERT being placed > > immediately after it, it's even more distracting from the actual section > > layout. > > ld.bfd (if I'm remembering correctly) was extraordinarily upset about it > being at the end. I will retest and report back. > > -- > Kees Cook Actually, moving it to the end also requires marking it INFO or stripping it out when creating the bzImage. Otherwise we get back to that old problem of materializing .bss/.pgtable in the bzImage. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A64C433E0 for ; Sat, 1 Aug 2020 17:14:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CDA12071E for ; Sat, 1 Aug 2020 17:14:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W6IhUXEt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ldn6PBxD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CDA12071E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Utlb9ysYRPGR8Vt89AYfBoFDSBl4X6rwmGFV1eXkuoY=; b=W6IhUXEtqoxSpVxDv+sPdbidB HHRIgkNjV6H7rSYpPR4XpTtH2K9YVhaepR+SUz/mS/MShYEvHsVp7psGIND5bLfinAZWds+fyDqi/ SBOm9+yDxeTMxc5vTDzEiw7Ef9OZj29/y7Devyn8pjV0Eo7xPAGdqhDNVe/S1uUY6RTidNaLMM/Xb 2ozpnn+77LaNXATO5MSNY8cjJ8jrjPe4fIu5PdztGcPmMpl9pdaImalXnohIUUw9IQVLRahmiDHhg UfK+gHtUqsiADm34Rlmblhq9d9yF98FPSX/IShdosG4nu3lIw3IpOz9TgfAWQhGtWHLRQUgDeVJw+ 4GMWeXzDQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1v3g-0004Ev-Fy; Sat, 01 Aug 2020 17:12:32 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k1v3d-0004Dq-Fa for linux-arm-kernel@lists.infradead.org; Sat, 01 Aug 2020 17:12:30 +0000 Received: by mail-qv1-xf44.google.com with SMTP id r19so7067363qvw.11 for ; Sat, 01 Aug 2020 10:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2o6GVTZCy3XlmzBSwd7fA26VADSjJEkCYNl3YQKOr2M=; b=Ldn6PBxD4m7lMPymQjipKfl27zylKQuiR2k8wfxVSrmlQ5jpqIVVImGSZWjlPgIbGC hDJ7BkFuGFrS7733Sa79QeGiqV0qQCemUiXRE/QiwWnLbm5EQ82dmxs/kG3UyfU7E7n8 nL536EWJMI21gMA9GAQJpy1F9/6iR1lsI9mBQIIRfbo6g7chxN3cmdc3uVhPEga7RQ4V TEliR1I27x7f40QWq2Ktg3mUvoW/3WDyyvpBb63myjZ0gnPKNIW0MqE9glVDJBy3Bgqw In5hjK+9C4XkaeRowWu/SdcdFCcOWgZbXvoQRkQSw2xxEZumWAOjTxrQxGG+33eaNoFE aj7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=2o6GVTZCy3XlmzBSwd7fA26VADSjJEkCYNl3YQKOr2M=; b=kldN4BuDlSm/KUX/R+8iPsJwu9ep5cbYBrfzMfHxd0lJ/HR/3ZAbexrl1Bn2XTcjf1 IIv7ZfG0I5NXA7n53itAw5H0jX/OVMP6G27hjgGT8SvcizTY3rvbA3stv8bcxApf1YWW xYgUaH0XGAVCX9ujsDzGsVM69HryqHVuLsU+WAcEaPihyf6SZ5XU3JvdlQ22bWOJFrbr e5guvC5enWwwTT7Nr6LizBcfXSrmsE6nWkG7LLSwOyQlo3gAC0tA68zb21V1tJrsFKne ZZYz9/YmSeiuSFqrr91edSF5j9DuyzhvboyjSNxkEh3yGLol4/wwVIfAnxeIIBF13TsF XQBw== X-Gm-Message-State: AOAM531THwW82Qka318l16yj2mjULHYstUrsB1jiOrB0WfVUjO2kKq6J 1wQ4ZEaTpXjtAJ+XEXwgG3Y= X-Google-Smtp-Source: ABdhPJyvisrUtCH+yT5SZkhMZ5hRzUqOeeL+iqxCLSrjVaYvR2aM1RnsJVQsxy3ZgehzESYLcwGpwg== X-Received: by 2002:a0c:ffc6:: with SMTP id h6mr9551061qvv.251.1596301947711; Sat, 01 Aug 2020 10:12:27 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id i19sm12760874qkk.68.2020.08.01.10.12.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Aug 2020 10:12:27 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sat, 1 Aug 2020 13:12:25 -0400 To: Kees Cook Subject: Re: [PATCH v5 32/36] x86/boot/compressed: Reorganize zero-size section asserts Message-ID: <20200801171225.GB3249534@rani.riverdale.lan> References: <20200731230820.1742553-1-keescook@chromium.org> <20200731230820.1742553-33-keescook@chromium.org> <20200801014755.GA2700342@rani.riverdale.lan> <20200801025325.GA2800311@rani.riverdale.lan> <202007312235.4A48157938@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202007312235.4A48157938@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200801_131229_668141_E2731B9F X-CRM114-Status: GOOD ( 28.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, Nathan Chancellor , clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 31, 2020 at 10:36:00PM -0700, Kees Cook wrote: > On Fri, Jul 31, 2020 at 10:53:25PM -0400, Arvind Sankar wrote: > > On Fri, Jul 31, 2020 at 09:47:55PM -0400, Arvind Sankar wrote: > > > On Fri, Jul 31, 2020 at 04:08:16PM -0700, Kees Cook wrote: > > > > For readability, move the zero-sized sections to the end after DISCARDS > > > > and mark them NOLOAD for good measure. > > > > > > > > Signed-off-by: Kees Cook > > > > --- > > > > arch/x86/boot/compressed/vmlinux.lds.S | 42 +++++++++++++++----------- > > > > 1 file changed, 25 insertions(+), 17 deletions(-) > > > > > > > > diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S > > > > index 3c2ee9a5bf43..42dea70a5091 100644 > > > > --- a/arch/x86/boot/compressed/vmlinux.lds.S > > > > +++ b/arch/x86/boot/compressed/vmlinux.lds.S > > > > @@ -42,18 +42,16 @@ SECTIONS > > > > *(.rodata.*) > > > > _erodata = . ; > > > > } > > > > - .rel.dyn : { > > > > - *(.rel.*) > > > > - } > > > > - .rela.dyn : { > > > > - *(.rela.*) > > > > - } > > > > - .got : { > > > > - *(.got) > > > > - } > > > > .got.plt : { > > > > *(.got.plt) > > > > } > > > > + ASSERT(SIZEOF(.got.plt) == 0 || > > > > +#ifdef CONFIG_X86_64 > > > > + SIZEOF(.got.plt) == 0x18, > > > > +#else > > > > + SIZEOF(.got.plt) == 0xc, > > > > +#endif > > > > + "Unexpected GOT/PLT entries detected!") > > > > > > > > .data : { > > > > _data = . ; > > > > @@ -85,13 +83,23 @@ SECTIONS > > > > ELF_DETAILS > > > > > > > > DISCARDS > > > > -} > > > > > > > > -ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!") > > > > -#ifdef CONFIG_X86_64 > > > > -ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0x18, "Unexpected GOT/PLT entries detected!") > > > > -#else > > > > -ASSERT(SIZEOF(.got.plt) == 0 || SIZEOF(.got.plt) == 0xc, "Unexpected GOT/PLT entries detected!") > > > > -#endif > > > > + /* > > > > + * Sections that should stay zero sized, which is safer to > > > > + * explicitly check instead of blindly discarding. > > > > + */ > > > > + .got (NOLOAD) : { > > > > + *(.got) > > > > + } > > > > + ASSERT(SIZEOF(.got) == 0, "Unexpected GOT entries detected!") > > > > > > > > -ASSERT(SIZEOF(.rel.dyn) == 0 && SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations detected!") > > > > + /* ld.lld does not like .rel* sections being made "NOLOAD". */ > > > > + .rel.dyn : { > > > > + *(.rel.*) > > > > + } > > > > + ASSERT(SIZEOF(.rel.dyn) == 0, "Unexpected run-time relocations (.rel) detected!") > > > > + .rela.dyn : { > > > > + *(.rela.*) > > > > + } > > > > + ASSERT(SIZEOF(.rela.dyn) == 0, "Unexpected run-time relocations (.rela) detected!") > > > > +} > > > > -- > > > > 2.25.1 > > > > > > > > > > There's no point in marking zero-size sections NOLOAD -- if the ASSERT's > > > passed, they won't be present in the file at all anyway. > > > > > > The only section for which there might be a point is .got.plt, which is > > > non-empty on 32-bit, and only if it is first moved to the end. That > > > saves a few bytes. > > > > Btw, you should move .got.plt also to the end anyway for readability, > > it's unused even if non-empty. And with the ASSERT being placed > > immediately after it, it's even more distracting from the actual section > > layout. > > ld.bfd (if I'm remembering correctly) was extraordinarily upset about it > being at the end. I will retest and report back. > > -- > Kees Cook Actually, moving it to the end also requires marking it INFO or stripping it out when creating the bzImage. Otherwise we get back to that old problem of materializing .bss/.pgtable in the bzImage. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel