Hi "Saheed, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on linus/master v5.8-rc7] [cannot apply to ras/edac-for-next ide/master next-20200731] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Saheed-O-Bolarinwa/Drop-uses-of-pci_read_config_-return-value/20200801-202925 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: arc-allyesconfig (attached as .config) compiler: arc-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/net/wireless/intel/iwlwifi/pcie/trans.c: In function 'iwl_trans_pcie_dump_regs': >> drivers/net/wireless/intel/iwlwifi/pcie/trans.c:124:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 124 | for (i = 0, ptr = buf; i < PCI_DUMP_SIZE; i += 4, ptr++) | ^~~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:126:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 126 | if (*ptr == (u32)~0) | ^~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:138:3: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 138 | for (i = 0, ptr = buf; i < PCI_ERR_ROOT_COMMAND; i += 4, ptr++) | ^~~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:140:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 140 | if (*ptr == (u32)~0) | ^~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:155:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 155 | for (i = 0, ptr = buf; i < PCI_PARENT_DUMP_SIZE; i += 4, ptr++) | ^~~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:157:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 157 | if (*ptr == (u32)~0) | ^~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:170:3: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 170 | for (i = 0, ptr = buf; i <= PCI_ERR_ROOT_ERR_SRC; i += 4, ptr++) | ^~~ drivers/net/wireless/intel/iwlwifi/pcie/trans.c:172:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 172 | if (*ptr == (u32)~0) | ^~ vim +/for +124 drivers/net/wireless/intel/iwlwifi/pcie/trans.c fe45773b5baa154 drivers/net/wireless/iwlwifi/pcie/trans.c Arik Nemtsov 2014-11-17 88 4290eaad7a8a716 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Johannes Berg 2018-04-11 89 void iwl_trans_pcie_dump_regs(struct iwl_trans *trans) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 90 { c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 91 #define PCI_DUMP_SIZE 352 c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 92 #define PCI_MEM_DUMP_SIZE 64 c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 93 #define PCI_PARENT_DUMP_SIZE 524 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 94 #define PREFIX_LEN 32 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 95 struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 96 struct pci_dev *pdev = trans_pcie->pci_dev; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 97 u32 i, pos, alloc_size, *ptr, *buf; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 98 char *prefix; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 99 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 100 if (trans_pcie->pcie_dbg_dumped_once) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 101 return; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 102 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 103 /* Should be a multiple of 4 */ a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 104 BUILD_BUG_ON(PCI_DUMP_SIZE > 4096 || PCI_DUMP_SIZE & 0x3); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 105 BUILD_BUG_ON(PCI_MEM_DUMP_SIZE > 4096 || PCI_MEM_DUMP_SIZE & 0x3); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 106 BUILD_BUG_ON(PCI_PARENT_DUMP_SIZE > 4096 || PCI_PARENT_DUMP_SIZE & 0x3); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 107 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 108 /* Alloc a max size buffer */ a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 109 alloc_size = PCI_ERR_ROOT_ERR_SRC + 4 + PREFIX_LEN; c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 110 alloc_size = max_t(u32, alloc_size, PCI_DUMP_SIZE + PREFIX_LEN); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 111 alloc_size = max_t(u32, alloc_size, PCI_MEM_DUMP_SIZE + PREFIX_LEN); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 112 alloc_size = max_t(u32, alloc_size, PCI_PARENT_DUMP_SIZE + PREFIX_LEN); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 113 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 114 buf = kmalloc(alloc_size, GFP_ATOMIC); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 115 if (!buf) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 116 return; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 117 prefix = (char *)buf + alloc_size - PREFIX_LEN; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 118 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 119 IWL_ERR(trans, "iwlwifi transaction failed, dumping registers\n"); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 120 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 121 /* Print wifi device registers */ a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 122 sprintf(prefix, "iwlwifi %s: ", pci_name(pdev)); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 123 IWL_ERR(trans, "iwlwifi device config registers:\n"); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 @124 for (i = 0, ptr = buf; i < PCI_DUMP_SIZE; i += 4, ptr++) 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 125 pci_read_config_dword(pdev, i, ptr); 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 126 if (*ptr == (u32)~0) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 127 goto err_read; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 128 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 129 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 130 IWL_ERR(trans, "iwlwifi device memory mapped registers:\n"); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 131 for (i = 0, ptr = buf; i < PCI_MEM_DUMP_SIZE; i += 4, ptr++) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 132 *ptr = iwl_read32(trans, i); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 133 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 134 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 135 pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 136 if (pos) { a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 137 IWL_ERR(trans, "iwlwifi device AER capability structure:\n"); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 138 for (i = 0, ptr = buf; i < PCI_ERR_ROOT_COMMAND; i += 4, ptr++) 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 139 pci_read_config_dword(pdev, pos + i, ptr); 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 140 if (*ptr == (u32)~0) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 141 goto err_read; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 142 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 143 32, 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 144 } a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 145 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 146 /* Print parent device registers next */ a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 147 if (!pdev->bus->self) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 148 goto out; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 149 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 150 pdev = pdev->bus->self; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 151 sprintf(prefix, "iwlwifi %s: ", pci_name(pdev)); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 152 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 153 IWL_ERR(trans, "iwlwifi parent port (%s) config registers:\n", a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 154 pci_name(pdev)); c4d3f2ee66a8dd5 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Luca Coelho 2019-05-15 155 for (i = 0, ptr = buf; i < PCI_PARENT_DUMP_SIZE; i += 4, ptr++) 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 156 pci_read_config_dword(pdev, i, ptr); 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 157 if (*ptr == (u32)~0) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 158 goto err_read; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 159 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 160 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 161 /* Print root port AER registers */ a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 162 pos = 0; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 163 pdev = pcie_find_root_port(pdev); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 164 if (pdev) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 165 pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_ERR); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 166 if (pos) { a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 167 IWL_ERR(trans, "iwlwifi root port (%s) AER cap structure:\n", a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 168 pci_name(pdev)); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 169 sprintf(prefix, "iwlwifi %s: ", pci_name(pdev)); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 170 for (i = 0, ptr = buf; i <= PCI_ERR_ROOT_ERR_SRC; i += 4, ptr++) 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 171 pci_read_config_dword(pdev, pos + i, ptr); 31b06e689bc2e78 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Saheed O. Bolarinwa 2020-08-01 172 if (*ptr == (u32)~0) a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 173 goto err_read; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 174 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 175 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 176 } f3402d6d8eb084f drivers/net/wireless/intel/iwlwifi/pcie/trans.c Sara Sharon 2017-11-20 177 goto out; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 178 a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 179 err_read: a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 180 print_hex_dump(KERN_ERR, prefix, DUMP_PREFIX_OFFSET, 32, 4, buf, i, 0); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 181 IWL_ERR(trans, "Read failed@0x%X\n", i); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 182 out: a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 183 trans_pcie->pcie_dbg_dumped_once = 1; a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 184 kfree(buf); a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 185 } a6d24fad00d98e2 drivers/net/wireless/intel/iwlwifi/pcie/trans.c Rajat Jain 2017-08-17 186 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org