CC: kbuild-all(a)lists.01.org In-Reply-To: <20200801120216.8488-1-bernard@vivo.com> References: <20200801120216.8488-1-bernard@vivo.com> TO: Bernard Zhao TO: Maarten Lankhorst TO: Maxime Ripard TO: Thomas Zimmermann TO: Thierry Reding TO: Sam Ravnborg TO: David Airlie TO: Daniel Vetter TO: Linus Walleij TO: Jerry Han TO: Icenowy Zheng Hi Bernard, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc7 next-20200731] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bernard-Zhao/drm-panel-remove-return-value-of-function-drm_panel_add/20200801-200252 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7dc6fd0f3b8404542718039f5de19fe56e474578 :::::: branch date: 7 hours ago :::::: commit date: 7 hours ago config: i386-randconfig-s032-20200801 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-115-g5fc204f2-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:749:1: sparse: sparse: unused label 'unregister_backlight' drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c:218:15: sparse: sparse: symbol 'vint_table' was not declared. Should it be static? -- >> drivers/gpu/drm/panel/panel-samsung-s6e63j0x03.c:494:1: sparse: sparse: unused label 'unregister_backlight' # https://github.com/0day-ci/linux/commit/b5fd4505cdbf1b5d3fedb35fdea9a3a629d5e71c git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout b5fd4505cdbf1b5d3fedb35fdea9a3a629d5e71c vim +/unregister_backlight +749 drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 680 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 681 static int s6e3ha2_probe(struct mipi_dsi_device *dsi) ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 682 { ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 683 struct device *dev = &dsi->dev; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 684 struct s6e3ha2 *ctx; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 685 int ret; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 686 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 687 ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 688 if (!ctx) ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 689 return -ENOMEM; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 690 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 691 mipi_dsi_set_drvdata(dsi, ctx); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 692 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 693 ctx->dev = dev; e2af12bfb0ba198 Hoegeun Kwon 2017-04-18 694 ctx->desc = of_device_get_match_data(dev); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 695 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 696 dsi->lanes = 4; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 697 dsi->format = MIPI_DSI_FMT_RGB888; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 698 dsi->mode_flags = MIPI_DSI_CLOCK_NON_CONTINUOUS; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 699 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 700 ctx->supplies[0].supply = "vdd3"; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 701 ctx->supplies[1].supply = "vci"; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 702 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 703 ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 704 ctx->supplies); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 705 if (ret < 0) { ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 706 dev_err(dev, "failed to get regulators: %d\n", ret); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 707 return ret; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 708 } ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 709 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 710 ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 711 if (IS_ERR(ctx->reset_gpio)) { ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 712 dev_err(dev, "cannot get reset-gpios %ld\n", ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 713 PTR_ERR(ctx->reset_gpio)); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 714 return PTR_ERR(ctx->reset_gpio); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 715 } ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 716 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 717 ctx->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 718 if (IS_ERR(ctx->enable_gpio)) { ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 719 dev_err(dev, "cannot get enable-gpios %ld\n", ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 720 PTR_ERR(ctx->enable_gpio)); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 721 return PTR_ERR(ctx->enable_gpio); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 722 } ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 723 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 724 ctx->bl_dev = backlight_device_register("s6e3ha2", dev, ctx, ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 725 &s6e3ha2_bl_ops, NULL); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 726 if (IS_ERR(ctx->bl_dev)) { ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 727 dev_err(dev, "failed to register backlight device\n"); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 728 return PTR_ERR(ctx->bl_dev); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 729 } ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 730 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 731 ctx->bl_dev->props.max_brightness = S6E3HA2_MAX_BRIGHTNESS; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 732 ctx->bl_dev->props.brightness = S6E3HA2_DEFAULT_BRIGHTNESS; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 733 ctx->bl_dev->props.power = FB_BLANK_POWERDOWN; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 734 9a2654c0f62a170 Laurent Pinchart 2019-09-04 735 drm_panel_init(&ctx->panel, dev, &s6e3ha2_drm_funcs, 9a2654c0f62a170 Laurent Pinchart 2019-09-04 736 DRM_MODE_CONNECTOR_DSI); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 737 b5fd4505cdbf1b5 Bernard Zhao 2020-08-01 738 drm_panel_add(&ctx->panel); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 739 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 740 ret = mipi_dsi_attach(dsi); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 741 if (ret < 0) ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 742 goto remove_panel; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 743 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 744 return ret; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 745 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 746 remove_panel: ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 747 drm_panel_remove(&ctx->panel); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 748 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 @749 unregister_backlight: ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 750 backlight_device_unregister(ctx->bl_dev); ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 751 ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 752 return ret; ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 753 } ed29f9426d9bf1b Hoegeun Kwon 2017-03-08 754 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org