From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 677D1C433E0 for ; Sun, 2 Aug 2020 11:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 484C82075B for ; Sun, 2 Aug 2020 11:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbgHBLkv (ORCPT ); Sun, 2 Aug 2020 07:40:51 -0400 Received: from mga09.intel.com ([134.134.136.24]:63624 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgHBLku (ORCPT ); Sun, 2 Aug 2020 07:40:50 -0400 IronPort-SDR: pIGuwzKufxs2akpL7Yzx78afU0RZauTKHGS6xV/4EoAVUJgZkUGUpM1NZqLberyEXO4v4ACCWR v9KyncTaziaQ== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="153201991" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="153201991" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:40:50 -0700 IronPort-SDR: zTmAvTqRF5Q/d8MAJQczFCPyOgqePoEIe4gpsyHTg45B1dHmF8LJdjZvJFUotZCyOJbim2Oxxp KUn8qpeVMTlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="366035580" Received: from cahanley-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.10.182]) by orsmga001.jf.intel.com with ESMTP; 02 Aug 2020 04:40:45 -0700 Date: Sun, 2 Aug 2020 14:40:44 +0300 From: Andi Shyti To: Tianjia Zhang Cc: , , , , , , , , , , , , Subject: Re: [PATCH] drm/i915: Fix wrong return value Message-ID: <20200802114044.GD4705@intel.intel> References: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref, > intel_engine_mask_t tmp, mask = engine->mask; > struct llist_node *first = NULL, *last = NULL; > struct intel_gt *gt = engine->gt; > - int err; > + int err = 0; you don't need the initialization here. Thanks, Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956CFC433DF for ; Sun, 2 Aug 2020 11:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7501A20738 for ; Sun, 2 Aug 2020 11:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7501A20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0A5A89C96; Sun, 2 Aug 2020 11:40:52 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BDD189C96; Sun, 2 Aug 2020 11:40:51 +0000 (UTC) IronPort-SDR: +vZxP5qq/ipmYYS9nCz4JlIndGS7vjJWP5cxKPu7WiVxYhMZNh3kzcoxhvNUBHPCro6jubjihP OK1+833IU7NQ== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="153201992" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="153201992" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:40:50 -0700 IronPort-SDR: zTmAvTqRF5Q/d8MAJQczFCPyOgqePoEIe4gpsyHTg45B1dHmF8LJdjZvJFUotZCyOJbim2Oxxp KUn8qpeVMTlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="366035580" Received: from cahanley-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.10.182]) by orsmga001.jf.intel.com with ESMTP; 02 Aug 2020 04:40:45 -0700 Date: Sun, 2 Aug 2020 14:40:44 +0300 From: Andi Shyti To: Tianjia Zhang Subject: Re: [PATCH] drm/i915: Fix wrong return value Message-ID: <20200802114044.GD4705@intel.intel> References: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, tvrtko.ursulin@intel.com, airlied@linux.ie, mika.kuoppala@linux.intel.com, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, chris@chris-wilson.co.uk, tianjia.zhang@alibaba.com, matthew.auld@intel.com, rodrigo.vivi@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref, > intel_engine_mask_t tmp, mask = engine->mask; > struct llist_node *first = NULL, *last = NULL; > struct intel_gt *gt = engine->gt; > - int err; > + int err = 0; you don't need the initialization here. Thanks, Andi _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE54C433DF for ; Sun, 2 Aug 2020 11:40:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6169020738 for ; Sun, 2 Aug 2020 11:40:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6169020738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C43B989CAF; Sun, 2 Aug 2020 11:40:52 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BDD189C96; Sun, 2 Aug 2020 11:40:51 +0000 (UTC) IronPort-SDR: +vZxP5qq/ipmYYS9nCz4JlIndGS7vjJWP5cxKPu7WiVxYhMZNh3kzcoxhvNUBHPCro6jubjihP OK1+833IU7NQ== X-IronPort-AV: E=McAfee;i="6000,8403,9700"; a="153201992" X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="153201992" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2020 04:40:50 -0700 IronPort-SDR: zTmAvTqRF5Q/d8MAJQczFCPyOgqePoEIe4gpsyHTg45B1dHmF8LJdjZvJFUotZCyOJbim2Oxxp KUn8qpeVMTlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,426,1589266800"; d="scan'208";a="366035580" Received: from cahanley-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.10.182]) by orsmga001.jf.intel.com with ESMTP; 02 Aug 2020 04:40:45 -0700 Date: Sun, 2 Aug 2020 14:40:44 +0300 From: Andi Shyti To: Tianjia Zhang Message-ID: <20200802114044.GD4705@intel.intel> References: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200802111534.5155-1-tianjia.zhang@linux.alibaba.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, chris@chris-wilson.co.uk, tianjia.zhang@alibaba.com, matthew.auld@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int i915_active_acquire_preallocate_barrier(struct i915_active *ref, > intel_engine_mask_t tmp, mask = engine->mask; > struct llist_node *first = NULL, *last = NULL; > struct intel_gt *gt = engine->gt; > - int err; > + int err = 0; you don't need the initialization here. Thanks, Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx