From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 776BBC433E0 for ; Sun, 2 Aug 2020 14:54:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56A552072A for ; Sun, 2 Aug 2020 14:54:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="bFKD1cXl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726645AbgHBOyU (ORCPT ); Sun, 2 Aug 2020 10:54:20 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:51664 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbgHBOyT (ORCPT ); Sun, 2 Aug 2020 10:54:19 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1596380058; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=0zF08kDdcZxmATNJYLTGsnic9XvBbLnvMG4xP86W4xM=; b=bFKD1cXld9+OIhdPyPPDB2SosvtsiMy4WpJrbk4/x0tiSBf1mab0TWdhwIA9JFzzp/EUeUAm 09ikoCFbMWyI5wfLmriEP72CXJTepBzM75xGUbZ7tFon6hgUi/Zi424yblsL1fvxon4Mo+u4 gdHwIj5uCwy9Zsk07yzm5QfndcA= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n18.prod.us-east-1.postgun.com with SMTP id 5f26d38aeecfc978d3930470 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sun, 02 Aug 2020 14:54:02 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1BAD0C433C6; Sun, 2 Aug 2020 14:54:02 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 83B7CC433C6; Sun, 2 Aug 2020 14:53:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 83B7CC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path From: Kalle Valo In-Reply-To: <20200723163214.995226-1-colin.king@canonical.com> References: <20200723163214.995226-1-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200802145402.1BAD0C433C6@smtp.codeaurora.org> Date: Sun, 2 Aug 2020 14:54:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variables ant_num and single_ant_path are being initialized with a > value that is never read and are being updated later with a new value. > The initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 56b06d4da812 rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path -- https://patchwork.kernel.org/patch/11681295/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Sun, 02 Aug 2020 14:54:02 +0000 Subject: Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables Message-Id: <20200802145402.1BAD0C433C6@smtp.codeaurora.org> List-Id: References: <20200723163214.995226-1-colin.king@canonical.com> In-Reply-To: <20200723163214.995226-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variables ant_num and single_ant_path are being initialized with a > value that is never read and are being updated later with a new value. > The initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 56b06d4da812 rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path -- https://patchwork.kernel.org/patch/11681295/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches