From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D89A3C433E0 for ; Sun, 2 Aug 2020 16:55:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB62B20656 for ; Sun, 2 Aug 2020 16:55:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726644AbgHBQzQ (ORCPT ); Sun, 2 Aug 2020 12:55:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39120 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbgHBQzQ (ORCPT ); Sun, 2 Aug 2020 12:55:16 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1k2HGS-007wGX-8w; Sun, 02 Aug 2020 18:55:12 +0200 Date: Sun, 2 Aug 2020 18:55:12 +0200 From: Andrew Lunn To: Adrian Pop Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com, vadimp@mellanox.com, mlxsw@mellanox.com, idosch@mellanox.com Subject: Re: [PATCH] ethtool: Add QSFP-DD support Message-ID: <20200802165512.GI1862409@lunn.ch> References: <20200731084725.7804-1-popadrian1996@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200731084725.7804-1-popadrian1996@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 31, 2020 at 11:47:25AM +0300, Adrian Pop wrote: > The Common Management Interface Specification (CMIS) for QSFP-DD shares > some similarities with other form factors such as QSFP or SFP, but due to > the fact that the module memory map is different, the current ethtool > version is not able to provide relevant information about an interface. > > This patch adds QSFP-DD support to ethtool. The changes are similar to > the ones already existing in qsfp.c, but customized to use the memory > addresses and logic as defined in the specifications document. > > Page 0x00 (lower and higher memory) are always implemented, so the ethtool > expects at least 256 bytes if the identifier matches the one for QSFP-DD. > For optical connected cables, additional pages are usually available (the > contain module defined thresholds or lane diagnostic information). In > this case, ethtool expects to receive 768 bytes in the following format: > > +----------+----------+----------+----------+----------+----------+ > | Page | Page | Page | Page | Page | Page | > | 0x00 | 0x00 | 0x01 | 0x02 | 0x10 | 0x11 | > | (lower) | (higher) | (higher) | (higher) | (higher) | (higher) | > | 128B | 128B | 128B | 128B | 128B | 128B | > +----------+----------+----------+----------+----------+---------- Hi Adrian Didn't we discuss that page 3 might be useful? I would prefer not to document that pages 0x10 and 0x11 would follow page 2 until we have a driver which does actually provide pages 0x10 and 0x11. Andrew