From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3A89C433E1 for ; Sun, 2 Aug 2020 16:57:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D9D6207BB for ; Sun, 2 Aug 2020 16:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596387479; bh=4kEI4l0aRvt5/h9g0xWJYrGj07HsmDRlUAaOJ6inO8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=lsgPgQ1oBzDlX8TyOcsYzR5lzNDxeAk9jlD61DwCIoQ1ikQXairhRqD7M6Fnu3es3 6hC0C1d2Q91JHMIRO9YDhFWa4j9zjKI2/ebkaHCD/0TOm8ghjxxfP7YM6GIV2xcPd/ UYvGr2aHFX2IZrP9k/t04PeyWKb5atSde618oLn8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727063AbgHBQ56 (ORCPT ); Sun, 2 Aug 2020 12:57:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:53438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgHBQ55 (ORCPT ); Sun, 2 Aug 2020 12:57:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 699C2206E7; Sun, 2 Aug 2020 16:57:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596387477; bh=4kEI4l0aRvt5/h9g0xWJYrGj07HsmDRlUAaOJ6inO8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y4kBPwEDJbjOZEMc2uLF1D0tsUTpknH0xW29TRuBcLEgXiLx4yHZIn2WnfIrkRR4C 4Yd3SnOSonYPM+9KKcRRRIQT7Lq6mcM0UJ4+wrbuU3aMnIXr7IoJAbsNBq/F8ax6iE TimPI9pa+I4T1t74FfpoSVs6hrOK2uVf4dFxjufk= Date: Sun, 2 Aug 2020 18:57:38 +0200 From: Greg KH To: Pavel Machek Cc: Qiwu Huang , sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com, Qiwu Huang Subject: Re: [PATCH v4 1/4] power: supply: core: add quick charge type property Message-ID: <20200802165738.GA293244@kroah.com> References: <20200802120015.GA1289@bug> <20200802123742.GA257810@kroah.com> <20200802142825.GA20261@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200802142825.GA20261@amd> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 02, 2020 at 04:28:25PM +0200, Pavel Machek wrote: > On Sun 2020-08-02 14:37:42, Greg KH wrote: > > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > > > From: Qiwu Huang > > > > > > > > Reports the kind of quick charge type based on > > > > different adapter power. > > > > > > > > Signed-off-by: Qiwu Huang > > > > --- > > > > Documentation/ABI/testing/sysfs-class-power | 21 +++++++++++++++++++++ > > > > drivers/power/supply/power_supply_sysfs.c | 1 + > > > > include/linux/power_supply.h | 10 ++++++++++ > > > > 3 files changed, 32 insertions(+) > > > > > > > > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power > > > > index 216d61a22f1e..dd3773dcf16a 100644 > > > > --- a/Documentation/ABI/testing/sysfs-class-power > > > > +++ b/Documentation/ABI/testing/sysfs-class-power > > > > @@ -708,3 +708,24 @@ Description: > > > > > > > > Access: Read > > > > Valid values: 1-31 > > > > + > > > > +What: /sys/class/power_supply//quick_charge_type > > > > +Date: Jul 2020 > > > > +Contact: Fei Jiang > > > > + Description: > > > > + Reports the kind of quick charge type based on different adapter power. > > > > + Different quick charge type represent different charging power. > > > > + QUICK_CHARGE_NORMAL : Charging Power <= 10W > > > > + QUICK_CHARGE_FAST : 10W < Charging Power <= 20W > > > > + QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W > > > > + QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W > > > > + QUICK_CHARGE_SUPER : Charging Power > 50W > > > > + > > > > + Access: Read-Only > > > > + Valid values: > > > > + 0: QUICK_CHARGE_NORMAL, > > > > + 1: QUICK_CHARGE_FAST, > > > > + 2: QUICK_CHARGE_FLASH, > > > > + 3: QUICK_CHARGE_TURBE, > > > > + 4: QUICK_CHARGE_SUPER. > > > > > > NAK. > > > > > > Just expose value in watts or something... People are talking about > 100W charging, no > > > need to go with fast/turbe/super/hyper/nonsense. > > > > > > BTW fast charge is already "well defined", and what you call Normal is usually fast charge. > > > > I think these names come from the Qi charging spec, right? So lets use > > what is given to us. > > There are other standards, and this should better be generic. What standard? Why not go with this one, it's documented and out there and being used. > Simply expose value in watts. What if you do not know the watts, you just know these ranges. thanks, greg k-h