From: David Miller <davem@davemloft.net>
To: hongbo.wang@nxp.com
Cc: xiaoliang.yang_1@nxp.com, allan.nielsen@microchip.com,
po.liu@nxp.com, claudiu.manoil@nxp.com,
alexandru.marginean@nxp.com, vladimir.oltean@nxp.com,
leoyang.li@nxp.com, mingkai.hu@nxp.com, andrew@lunn.ch,
f.fainelli@gmail.com, vivien.didelot@gmail.com, jiri@resnulli.us,
idosch@idosch.org, kuba@kernel.org, vinicius.gomes@intel.com,
nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
horatiu.vultur@microchip.com, alexandre.belloni@bootlin.com,
UNGLinuxDriver@microchip.com, ivecera@redhat.com
Subject: Re: [PATCH v4 2/2] net: dsa: ocelot: Add support for QinQ Operation
Date: Mon, 03 Aug 2020 14:58:43 -0700 (PDT) [thread overview]
Message-ID: <20200803.145843.2285407129021498421.davem@davemloft.net> (raw)
In-Reply-To: <20200730102505.27039-3-hongbo.wang@nxp.com>
From: hongbo.wang@nxp.com
Date: Thu, 30 Jul 2020 18:25:05 +0800
> + if (vlan->proto == ETH_P_8021AD) {
> + ocelot->enable_qinq = true;
> + ocelot_port->qinq_mode = true;
> + }
...
> + if (vlan->proto == ETH_P_8021AD) {
> + ocelot->enable_qinq = false;
> + ocelot_port->qinq_mode = false;
> + }
> +
I don't understand how this can work just by using a boolean to track
the state.
This won't work properly if you are handling multiple QinQ VLAN entries.
Also, I need Andrew and Florian to review and ACK the DSA layer changes
that add the protocol value to the device notifier block.
next prev parent reply other threads:[~2020-08-03 21:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 10:25 [PATCH v4 0/2] Add 802.1AD protocol support for dsa switch and ocelot driver hongbo.wang
2020-07-30 10:25 ` [PATCH v4 1/2] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch port hongbo.wang
2020-08-03 22:38 ` Florian Fainelli
2020-08-04 7:24 ` [EXT] " Hongbo Wang
2020-07-30 10:25 ` [PATCH v4 2/2] net: dsa: ocelot: Add support for QinQ Operation hongbo.wang
2020-08-03 21:58 ` David Miller [this message]
2020-08-04 6:36 ` [EXT] " Hongbo Wang
2020-08-04 16:38 ` Florian Fainelli
2020-08-05 2:32 ` Hongbo Wang
2020-08-06 4:04 ` Hongbo Wang
2020-08-03 22:47 ` Florian Fainelli
2020-08-04 8:13 ` [EXT] " Hongbo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.145843.2285407129021498421.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.marginean@nxp.com \
--cc=allan.nielsen@microchip.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=hongbo.wang@nxp.com \
--cc=horatiu.vultur@microchip.com \
--cc=idosch@idosch.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingkai.hu@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=po.liu@nxp.com \
--cc=roopa@cumulusnetworks.com \
--cc=vinicius.gomes@intel.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.