From: David Miller <davem@davemloft.net>
To: florent.fourcot@wifirst.fr
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv6/addrconf: call addrconf_ifdown with consistent values
Date: Mon, 03 Aug 2020 15:24:55 -0700 (PDT) [thread overview]
Message-ID: <20200803.152455.19876741177260422.davem@davemloft.net> (raw)
In-Reply-To: <20200731133207.26964-1-florent.fourcot@wifirst.fr>
From: Florent Fourcot <florent.fourcot@wifirst.fr>
Date: Fri, 31 Jul 2020 15:32:06 +0200
> Second parameter of addrconf_ifdown "how" is used as a boolean
> internally. It does not make sense to call it with something different
> of 0 or 1.
>
> This value is set to 2 in all git history.
>
> Signed-off-by: Florent Fourcot <florent.fourcot@wifirst.fr>
The value '2' had a special meaning a very long time ago.
prev parent reply other threads:[~2020-08-03 22:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 13:32 [PATCH net-next 1/2] ipv6/addrconf: call addrconf_ifdown with consistent values Florent Fourcot
2020-07-31 13:32 ` [PATCH net-next 2/2] ipv6/addrconf: use a boolean to choose between UNREGISTER/DOWN Florent Fourcot
2020-08-03 22:25 ` David Miller
2020-08-03 22:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200803.152455.19876741177260422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florent.fourcot@wifirst.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.